From: Harman Kalra <harman4linux@gmail.com>
To: gregkh@linuxfoundation.org, sudipm.mukherjee@gmail.co
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Harman Kalra <harman4linux@gmail.com>
Subject: [PATCH] staging: i4l: icn: fixed some errors and warnings caught by checkpatch.pl
Date: Wed, 5 Oct 2016 02:23:22 +0530 [thread overview]
Message-ID: <1475614403-6426-1-git-send-email-harman4linux@gmail.com> (raw)
2 errors "open brace { should be on the previous line" are fixed.
Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed
Few line more tahn 80 character warnings fixed
Signed-off-by: Harman Kalra <harman4linux@gmail.com>
---
drivers/staging/i4l/icn/icn.c | 3 +--
drivers/staging/i4l/icn/icn.h | 7 ++++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c
index 514bfc2..3750ba3 100644
--- a/drivers/staging/i4l/icn/icn.c
+++ b/drivers/staging/i4l/icn/icn.c
@@ -411,8 +411,7 @@
int action;
} icn_stat;
/* *INDENT-OFF* */
-static icn_stat icn_stat_table[] =
-{
+static icn_stat icn_stat_table[] = {
{"BCON_", ISDN_STAT_BCONN, 1}, /* B-Channel connected */
{"BDIS_", ISDN_STAT_BHUP, 2}, /* B-Channel disconnected */
/*
diff --git a/drivers/staging/i4l/icn/icn.h b/drivers/staging/i4l/icn/icn.h
index f8f2e76..1e5a487 100644
--- a/drivers/staging/i4l/icn/icn.h
+++ b/drivers/staging/i4l/icn/icn.h
@@ -54,7 +54,8 @@
/* some useful macros for debugging */
#ifdef ICN_DEBUG_PORT
-#define OUTB_P(v, p) {printk(KERN_DEBUG "icn: outb_p(0x%02x,0x%03x)\n", v, p); outb_p(v, p);}
+#define OUTB_P(v, p) \
+ {pr_debug("icn: outb_p(0x%02x,0x%03x)\n", v, p); outb_p(v, p); }
#else
#define OUTB_P outb
#endif
@@ -186,8 +187,8 @@
#ifdef __KERNEL__
static icn_card *cards = (icn_card *) 0;
-static u_char chan2bank[] =
-{0, 4, 8, 12}; /* for icn_map_channel() */
+static u_char chan2bank[] = {
+ 0, 4, 8, 12}; /* for icn_map_channel() */
static icn_dev dev;
--
1.7.9.5
next reply other threads:[~2016-10-04 20:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 20:53 Harman Kalra [this message]
2016-10-05 6:52 ` [PATCH] staging: i4l: icn: fixed some errors and warnings caught by checkpatch.pl Greg KH
2016-10-07 16:57 ` [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed Harman Kalra
2016-10-07 16:57 ` [PATCH 2/3] Staging: i4l: Error "open brace { should be on the previous line" fixed Harman Kalra
2016-10-09 15:00 ` Greg KH
2016-10-09 15:35 ` [PATCH 1/3] Staging: i4l: icn: Fixed open brace should be on previous line error Harman Kalra
2016-10-09 15:35 ` [PATCH 2/3] Staging: i4l: icn: prefer pr_* instead of printk Harman Kalra
2016-10-09 15:35 ` [PATCH 3/3] Staging: i4l: icn: Fixed open brace should be on previous line error Harman Kalra
2016-10-07 16:57 ` [PATCH 3/3] Staging: i4l: Error "open brace { should be on the previous line" fixed Harman Kalra
2016-10-09 14:59 ` Greg KH
2016-10-07 20:49 ` [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed Joe Perches
2016-10-09 14:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475614403-6426-1-git-send-email-harman4linux@gmail.com \
--to=harman4linux@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.co \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.