From: Joe Perches <joe@perches.com>
To: Harman Kalra <harman4linux@gmail.com>,
gregkh@linuxfoundation.org, sudipm.mukherjee@gmail.co
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed
Date: Fri, 07 Oct 2016 13:49:47 -0700 [thread overview]
Message-ID: <1475873387.1945.23.camel@perches.com> (raw)
In-Reply-To: <1475859476-3524-1-git-send-email-harman4linux@gmail.com>
On Fri, 2016-10-07 at 22:27 +0530, Harman Kalra wrote:
> Warning "Prefer "pr_debug over printk(KERN_DEBUG... " and "few line more than 80 character" fixed
The commit subject and message doesn't match the code change.
> diff --git a/drivers/staging/i4l/icn/icn.h b/drivers/staging/i4l/icn/icn.h
[]
> @@ -54,7 +54,8 @@
>
> /* some useful macros for debugging */
> #ifdef ICN_DEBUG_PORT
> -#define OUTB_P(v, p) {printk(KERN_DEBUG "icn: outb_p(0x%02x,0x%03x)\n", v, p); outb_p(v, p);}
> +#define OUTB_P(v, p) \
> + {printk(KERN_DEBUG "icn: outb_p(0x%02x,0x%03x)\n", v, p); outb_p(v, p); }
This would be better with a do {...} while (0) guard
next prev parent reply other threads:[~2016-10-07 20:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 20:53 [PATCH] staging: i4l: icn: fixed some errors and warnings caught by checkpatch.pl Harman Kalra
2016-10-05 6:52 ` Greg KH
2016-10-07 16:57 ` [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed Harman Kalra
2016-10-07 16:57 ` [PATCH 2/3] Staging: i4l: Error "open brace { should be on the previous line" fixed Harman Kalra
2016-10-09 15:00 ` Greg KH
2016-10-09 15:35 ` [PATCH 1/3] Staging: i4l: icn: Fixed open brace should be on previous line error Harman Kalra
2016-10-09 15:35 ` [PATCH 2/3] Staging: i4l: icn: prefer pr_* instead of printk Harman Kalra
2016-10-09 15:35 ` [PATCH 3/3] Staging: i4l: icn: Fixed open brace should be on previous line error Harman Kalra
2016-10-07 16:57 ` [PATCH 3/3] Staging: i4l: Error "open brace { should be on the previous line" fixed Harman Kalra
2016-10-09 14:59 ` Greg KH
2016-10-07 20:49 ` Joe Perches [this message]
2016-10-09 14:59 ` [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475873387.1945.23.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harman4linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.co \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.