From: Greg KH <gregkh@linuxfoundation.org>
To: Harman Kalra <harman4linux@gmail.com>
Cc: sudipm.mukherjee@gmail.co, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: i4l: icn: fixed some errors and warnings caught by checkpatch.pl
Date: Wed, 5 Oct 2016 08:52:19 +0200 [thread overview]
Message-ID: <20161005065219.GD11013@kroah.com> (raw)
In-Reply-To: <1475614403-6426-1-git-send-email-harman4linux@gmail.com>
On Wed, Oct 05, 2016 at 02:23:22AM +0530, Harman Kalra wrote:
> 2 errors "open brace { should be on the previous line" are fixed.
> Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed
> Few line more tahn 80 character warnings fixed
That's three different things, please make three different patches,
don't do multiple things in the same patch.
thanks,
greg k-h
next prev parent reply other threads:[~2016-10-05 6:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 20:53 [PATCH] staging: i4l: icn: fixed some errors and warnings caught by checkpatch.pl Harman Kalra
2016-10-05 6:52 ` Greg KH [this message]
2016-10-07 16:57 ` [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed Harman Kalra
2016-10-07 16:57 ` [PATCH 2/3] Staging: i4l: Error "open brace { should be on the previous line" fixed Harman Kalra
2016-10-09 15:00 ` Greg KH
2016-10-09 15:35 ` [PATCH 1/3] Staging: i4l: icn: Fixed open brace should be on previous line error Harman Kalra
2016-10-09 15:35 ` [PATCH 2/3] Staging: i4l: icn: prefer pr_* instead of printk Harman Kalra
2016-10-09 15:35 ` [PATCH 3/3] Staging: i4l: icn: Fixed open brace should be on previous line error Harman Kalra
2016-10-07 16:57 ` [PATCH 3/3] Staging: i4l: Error "open brace { should be on the previous line" fixed Harman Kalra
2016-10-09 14:59 ` Greg KH
2016-10-07 20:49 ` [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed Joe Perches
2016-10-09 14:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161005065219.GD11013@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=harman4linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.co \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.