All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: linux-acpi@vger.kernel.org, rjw@rjwysocki.net,
	bhelgaas@google.com, ravikanth.nalla@hpe.com,
	linux@rainbow-software.org, timur@codeaurora.org,
	cov@codeaurora.org, jcm@redhat.com, alex.williamson@redhat.com
Cc: linux-pci@vger.kernel.org, agross@codeaurora.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, wim@djo.tudelft.nl,
	Sinan Kaya <okaya@codeaurora.org>, Len Brown <lenb@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH V2 2/3] ACPI, PCI IRQ: add PCI_USING penalty for ISA interrupts
Date: Tue,  4 Oct 2016 17:15:18 -0400	[thread overview]
Message-ID: <1475615720-31047-3-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1475615720-31047-1-git-send-email-okaya@codeaurora.org>

The change introduced in commit 103544d86976 ("ACPI,PCI,IRQ: reduce
resource requirements") removed PCI_USING penalty from
acpi_pci_link_allocate function as there is no longer a fixed size penalty
array for both PCI and IRQ interrupts.

We need to add the PCI_USING penalty for ISA interrupts too if the link is
in use and matches our ISA IRQ number.

Tested-by: Jonathan Liu <net147@gmail.com>
Tested-by: Ondrej Zary <linux@rainbow-software.org>
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/acpi/pci_link.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
index f3792f4..06c2a11 100644
--- a/drivers/acpi/pci_link.c
+++ b/drivers/acpi/pci_link.c
@@ -620,6 +620,10 @@ static int acpi_pci_link_allocate(struct acpi_pci_link *link)
 			    acpi_device_bid(link->device));
 		return -ENODEV;
 	} else {
+		if (link->irq.active < ACPI_MAX_IRQS)
+			acpi_irq_penalty[link->irq.active] +=
+				PIRQ_PENALTY_PCI_USING;
+
 		printk(KERN_WARNING PREFIX "%s [%s] enabled at IRQ %d\n",
 		       acpi_device_name(link->device),
 		       acpi_device_bid(link->device), link->irq.active);
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/3] ACPI, PCI IRQ: add PCI_USING penalty for ISA interrupts
Date: Tue,  4 Oct 2016 17:15:18 -0400	[thread overview]
Message-ID: <1475615720-31047-3-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1475615720-31047-1-git-send-email-okaya@codeaurora.org>

The change introduced in commit 103544d86976 ("ACPI,PCI,IRQ: reduce
resource requirements") removed PCI_USING penalty from
acpi_pci_link_allocate function as there is no longer a fixed size penalty
array for both PCI and IRQ interrupts.

We need to add the PCI_USING penalty for ISA interrupts too if the link is
in use and matches our ISA IRQ number.

Tested-by: Jonathan Liu <net147@gmail.com>
Tested-by: Ondrej Zary <linux@rainbow-software.org>
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/acpi/pci_link.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
index f3792f4..06c2a11 100644
--- a/drivers/acpi/pci_link.c
+++ b/drivers/acpi/pci_link.c
@@ -620,6 +620,10 @@ static int acpi_pci_link_allocate(struct acpi_pci_link *link)
 			    acpi_device_bid(link->device));
 		return -ENODEV;
 	} else {
+		if (link->irq.active < ACPI_MAX_IRQS)
+			acpi_irq_penalty[link->irq.active] +=
+				PIRQ_PENALTY_PCI_USING;
+
 		printk(KERN_WARNING PREFIX "%s [%s] enabled at IRQ %d\n",
 		       acpi_device_name(link->device),
 		       acpi_device_bid(link->device), link->irq.active);
-- 
1.9.1

  parent reply	other threads:[~2016-10-04 21:16 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-04 21:15 [PATCH V2 0/3] ACPI,PCI,IRQ: revert penalty calculation for SCI Sinan Kaya
2016-10-04 21:15 ` Sinan Kaya
2016-10-04 21:15 ` [PATCH V2 1/3] Revert "ACPI,PCI,IRQ: reduce static IRQ array size to 16" Sinan Kaya
2016-10-04 21:15   ` [PATCH V2 1/3] Revert "ACPI, PCI, IRQ: " Sinan Kaya
2016-10-12 22:13   ` [PATCH V2 1/3] Revert "ACPI,PCI,IRQ: " Bjorn Helgaas
2016-10-12 22:13     ` Bjorn Helgaas
2016-10-12 22:46     ` Sinan Kaya
2016-10-12 22:46       ` [PATCH V2 1/3] Revert "ACPI, PCI, IRQ: " Sinan Kaya
2016-10-13 18:15       ` [PATCH V2 1/3] Revert "ACPI,PCI,IRQ: " Bjorn Helgaas
2016-10-13 18:15         ` Bjorn Helgaas
2016-10-13 18:15         ` Bjorn Helgaas
2016-10-13 18:15         ` Bjorn Helgaas
2016-10-13 19:36         ` [PATCH V2 1/3] Revert "ACPI, PCI, IRQ: " Sinan Kaya
2016-10-13 19:36           ` Sinan Kaya
2016-10-13 19:36           ` [PATCH V2 1/3] Revert "ACPI,PCI,IRQ: " Sinan Kaya
2016-10-13 20:02           ` Bjorn Helgaas
2016-10-13 20:02             ` Bjorn Helgaas
2016-10-13 20:16             ` [PATCH V2 1/3] Revert "ACPI, PCI, IRQ: " Sinan Kaya
2016-10-13 20:16               ` Sinan Kaya
2016-10-13 20:16               ` [PATCH V2 1/3] Revert "ACPI,PCI,IRQ: " Sinan Kaya
2016-10-13 21:01               ` Rafael J. Wysocki
2016-10-13 21:01                 ` [PATCH V2 1/3] Revert "ACPI, PCI, IRQ: " Rafael J. Wysocki
2016-10-15  3:50       ` Sinan Kaya
2016-10-15  3:50         ` Sinan Kaya
2016-10-15  3:50         ` [PATCH V2 1/3] Revert "ACPI,PCI,IRQ: " Sinan Kaya
2016-10-04 21:15 ` Sinan Kaya [this message]
2016-10-04 21:15   ` [PATCH V2 2/3] ACPI, PCI IRQ: add PCI_USING penalty for ISA interrupts Sinan Kaya
2016-10-12 19:07   ` Bjorn Helgaas
2016-10-12 19:07     ` Bjorn Helgaas
2016-10-04 21:15 ` [PATCH V2 3/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function" Sinan Kaya
2016-10-04 21:15   ` Sinan Kaya
2016-10-05 13:38   ` Thomas Gleixner
2016-10-05 13:38     ` Thomas Gleixner
2016-10-13 18:25   ` Bjorn Helgaas
2016-10-13 18:25     ` Bjorn Helgaas
2016-10-13 18:25     ` Bjorn Helgaas
2016-10-13 18:25     ` Bjorn Helgaas
2016-10-11 21:55 ` [PATCH V2 0/3] ACPI,PCI,IRQ: revert penalty calculation for SCI Rafael J. Wysocki
2016-10-11 21:55   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475615720-31047-3-git-send-email-okaya@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=agross@codeaurora.org \
    --cc=alex.williamson@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=cov@codeaurora.org \
    --cc=jcm@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    --cc=ravikanth.nalla@hpe.com \
    --cc=rjw@rjwysocki.net \
    --cc=timur@codeaurora.org \
    --cc=wim@djo.tudelft.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.