From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "loberman@redhat.com" <loberman@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"tom.leiming@gmail.com" <tom.leiming@gmail.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"hch@lst.de" <hch@lst.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"roger.pau@citrix.com" <roger.pau@citrix.com>,
"axboe@fb.com" <axboe@fb.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"keith.busch@intel.com" <keith.busch@intel.com>,
"dledford@redhat.com" <dledford@redhat.com>
Subject: Re: [PATCH v5 14/14] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code
Date: Mon, 31 Oct 2016 15:10:36 +0000 [thread overview]
Message-ID: <1477926635.2511.1.camel@sandisk.com> (raw)
In-Reply-To: <540193784.5466628.1477921998345.JavaMail.zimbra@redhat.com>
T24gTW9uLCAyMDE2LTEwLTMxIGF0IDA5OjUzIC0wNDAwLCBMYXVyZW5jZSBPYmVybWFuIHdyb3Rl
Og0KPiBBcHBsaWVkIGFsbCAxNCBwYXRjaGVzLCBhbHNvIGNvcnJlY3RlZCB0aGUgcGFydCBvZiB0
aGUgeGVuLWJsa2Zyb250LmMgDQo+IGJsa2lmX3JlY292ZXIgcGF0Y2ggaW4gcGF0Y2h2NS01LzE0
Lg0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvYmxvY2sveGVuLWJsa2Zyb250LmMgYi9kcml2
ZXJzL2Jsb2NrL3hlbi0NCj4gYmxrZnJvbnQuYw0KPiBpbmRleCA5OTA4NTk3Li42MGZmZjk5IDEw
MDY0NA0KPiAtLS0gYS9kcml2ZXJzL2Jsb2NrL3hlbi1ibGtmcm9udC5jDQo+ICsrKyBiL2RyaXZl
cnMvYmxvY2sveGVuLWJsa2Zyb250LmMNCj4gQEAgLTIwNDUsNiArMjA0NSw3IEBAIHN0YXRpYyBp
bnQgYmxraWZfcmVjb3ZlcihzdHJ1Y3QgYmxrZnJvbnRfaW5mbw0KPiAqaW5mbykNCj4gwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoEJVR19PTihyZXEtPm5yX3BoeXNfc2VnbWVudHMg
PiBzZWdzKTsNCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGJsa19tcV9yZXF1
ZXVlX3JlcXVlc3QocmVxKTsNCj4gwqDCoMKgwqDCoMKgwqDCoMKgfQ0KPiArwqDCoMKgwqDCoMKg
wqDCoGJsa19tcV9zdGFydF9zdG9wcGVkX2h3X3F1ZXVlcyhpbmZycSwNCj4gdHJ1ZSk7wqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCoqKiBDb3JyZWN0ZWQNCj4gwqDCoMKg
wqDCoMKgwqDCoMKgYmxrX21xX2tpY2tfcmVxdWV1ZV9saXN0KGluZnJxKTsNCj4gwqANCj4gwqDC
oMKgwqDCoMKgwqDCoMKgd2hpbGUgKChiaW8gPSBiaW9fbGlzdF9wb3AoJmluZmJpb19saXN0KSkg
IT0gTlVMTCkgew0KDQpIZWxsbyBMYXVyZW5jZSwNCg0KU29ycnkgZm9yIHRoZSBidWlsZCBmYWls
dXJlLiBUaGUgd2F5IHlvdSBjaGFuZ2VkIHhlbi1ibGtmcm9udCBpcyBpbmRlZWQNCndoYXQgSSBp
bnRlbmRlZC4gQXBwYXJlbnRseSBJIGZvcmdvdCB0byBlbmFibGUgWGVuIGluIG15IGtlcm5lbCBj
b25maWcNCi4uLg0KDQpCYXJ0Lg==
WARNING: multiple messages have this Message-ID (diff)
From: Bart.VanAssche@sandisk.com (Bart Van Assche)
Subject: [PATCH v5 14/14] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code
Date: Mon, 31 Oct 2016 15:10:36 +0000 [thread overview]
Message-ID: <1477926635.2511.1.camel@sandisk.com> (raw)
In-Reply-To: <540193784.5466628.1477921998345.JavaMail.zimbra@redhat.com>
On Mon, 2016-10-31@09:53 -0400, Laurence Oberman wrote:
> Applied all 14 patches, also corrected the part of the xen-blkfront.c
> blkif_recover patch in patchv5-5/14.
>
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-
> blkfront.c
> index 9908597..60fff99 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -2045,6 +2045,7 @@ static int blkif_recover(struct blkfront_info
> *info)
> ?????????????????BUG_ON(req->nr_phys_segments > segs);
> ?????????????????blk_mq_requeue_request(req);
> ?????????}
> +????????blk_mq_start_stopped_hw_queues(infrq,
> true);????????????????????*** Corrected
> ?????????blk_mq_kick_requeue_list(infrq);
> ?
> ?????????while ((bio = bio_list_pop(&infbio_list)) != NULL) {
Hello Laurence,
Sorry for the build failure. The way you changed xen-blkfront is indeed
what I intended. Apparently I forgot to enable Xen in my kernel config
...
Bart.
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "loberman@redhat.com" <loberman@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"tom.leiming@gmail.com" <tom.leiming@gmail.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"hch@lst.de" <hch@lst.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"roger.pau@citrix.com" <roger.pau@citrix.com>,
"axboe@fb.com" <axboe@fb.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"keith.busch@intel.com" <keith.busch@intel.com>,
"dledford@redhat.com" <dledford@redhat.com>
Subject: Re: [PATCH v5 14/14] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code
Date: Mon, 31 Oct 2016 15:10:36 +0000 [thread overview]
Message-ID: <1477926635.2511.1.camel@sandisk.com> (raw)
In-Reply-To: <540193784.5466628.1477921998345.JavaMail.zimbra@redhat.com>
On Mon, 2016-10-31 at 09:53 -0400, Laurence Oberman wrote:
> Applied all 14 patches, also corrected the part of the xen-blkfront.c
> blkif_recover patch in patchv5-5/14.
>
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-
> blkfront.c
> index 9908597..60fff99 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -2045,6 +2045,7 @@ static int blkif_recover(struct blkfront_info
> *info)
> BUG_ON(req->nr_phys_segments > segs);
> blk_mq_requeue_request(req);
> }
> + blk_mq_start_stopped_hw_queues(infrq,
> true); *** Corrected
> blk_mq_kick_requeue_list(infrq);
>
> while ((bio = bio_list_pop(&infbio_list)) != NULL) {
Hello Laurence,
Sorry for the build failure. The way you changed xen-blkfront is indeed
what I intended. Apparently I forgot to enable Xen in my kernel config
...
Bart.
next prev parent reply other threads:[~2016-10-31 15:10 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 0:18 [PATCH v5 0/14] Fix race conditions related to stopping block layer queues Bart Van Assche
2016-10-29 0:18 ` Bart Van Assche
2016-10-29 0:18 ` [PATCH v5 01/14] blk-mq: Do not invoke .queue_rq() for a stopped queue Bart Van Assche
2016-10-29 0:18 ` Bart Van Assche
2016-10-29 0:19 ` [PATCH v5 02/14] blk-mq: Introduce blk_mq_hctx_stopped() Bart Van Assche
2016-10-29 0:19 ` Bart Van Assche
2016-10-29 0:19 ` [PATCH v5 03/14] blk-mq: Introduce blk_mq_queue_stopped() Bart Van Assche
2016-10-29 0:19 ` Bart Van Assche
2016-10-29 0:20 ` [PATCH v5 04/14] blk-mq: Move more code into blk_mq_direct_issue_request() Bart Van Assche
2016-10-29 0:20 ` Bart Van Assche
2016-10-29 0:20 ` [PATCH v5 05/14] blk-mq: Avoid that requeueing starts stopped queues Bart Van Assche
2016-10-29 0:20 ` Bart Van Assche
2016-10-29 0:20 ` Bart Van Assche
2016-11-01 16:01 ` Sagi Grimberg
2016-11-01 16:01 ` Sagi Grimberg
2016-11-01 16:01 ` Sagi Grimberg
2016-10-29 0:20 ` [PATCH v5 06/14] blk-mq: Remove blk_mq_cancel_requeue_work() Bart Van Assche
2016-10-29 0:20 ` Bart Van Assche
2016-10-29 0:20 ` Bart Van Assche
2016-11-01 16:01 ` Sagi Grimberg
2016-11-01 16:01 ` Sagi Grimberg
2016-10-29 0:21 ` [PATCH v5 07/14] blk-mq: Introduce blk_mq_quiesce_queue() Bart Van Assche
2016-10-29 0:21 ` Bart Van Assche
2016-10-29 0:21 ` Bart Van Assche
2016-11-01 16:02 ` Sagi Grimberg
2016-11-01 16:02 ` Sagi Grimberg
2016-11-02 2:08 ` Ming Lei
2016-11-02 2:08 ` Ming Lei
2016-11-02 2:08 ` Ming Lei
2016-10-29 0:21 ` [PATCH v5 08/14] blk-mq: Add a kick_requeue_list argument to blk_mq_requeue_request() Bart Van Assche
2016-10-29 0:21 ` Bart Van Assche
2016-10-29 0:21 ` Bart Van Assche
2016-11-01 16:02 ` Sagi Grimberg
2016-11-01 16:02 ` Sagi Grimberg
2016-10-29 0:22 ` [PATCH v5 09/14] dm: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code Bart Van Assche
2016-10-29 0:22 ` Bart Van Assche
2016-10-29 0:22 ` [PATCH v5 10/14] dm: Fix a race condition related to stopping and starting queues Bart Van Assche
2016-10-29 0:22 ` Bart Van Assche
2016-10-29 0:22 ` [PATCH v5 11/14] SRP transport: Move queuecommand() wait code to SCSI core Bart Van Assche
2016-10-29 0:22 ` Bart Van Assche
2016-11-01 16:03 ` Sagi Grimberg
2016-11-01 16:03 ` Sagi Grimberg
2016-11-01 16:11 ` Martin K. Petersen
2016-11-01 16:11 ` Martin K. Petersen
2016-11-01 16:11 ` Martin K. Petersen
2016-10-29 0:23 ` [PATCH v5 12/14] SRP transport, scsi-mq: Wait for .queue_rq() if necessary Bart Van Assche
2016-10-29 0:23 ` Bart Van Assche
2016-11-01 16:03 ` Sagi Grimberg
2016-11-01 16:03 ` Sagi Grimberg
2016-11-01 16:03 ` Sagi Grimberg
2016-11-01 16:12 ` Martin K. Petersen
2016-11-01 16:12 ` Martin K. Petersen
2016-10-29 0:23 ` [PATCH v5 13/14] nvme: Fix a race condition related to stopping queues Bart Van Assche
2016-10-29 0:23 ` Bart Van Assche
2016-10-29 0:23 ` Bart Van Assche
2016-11-01 16:03 ` Sagi Grimberg
2016-11-01 16:03 ` Sagi Grimberg
2016-10-29 0:23 ` [PATCH v5 14/14] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code Bart Van Assche
2016-10-29 0:23 ` Bart Van Assche
2016-10-31 13:53 ` Laurence Oberman
2016-10-31 13:53 ` Laurence Oberman
2016-10-31 13:59 ` Bart Van Assche
2016-10-31 13:59 ` Bart Van Assche
2016-10-31 13:59 ` Bart Van Assche
2016-10-31 15:10 ` Bart Van Assche [this message]
2016-10-31 15:10 ` Bart Van Assche
2016-10-31 15:10 ` Bart Van Assche
2016-11-02 15:17 ` [PATCH v5 0/14] Fix race conditions related to stopping block layer queues Christoph Hellwig
2016-11-02 15:17 ` Christoph Hellwig
2016-11-02 18:52 ` Jens Axboe
2016-11-02 18:52 ` Jens Axboe
2016-11-02 18:52 ` Jens Axboe
2016-11-02 19:35 ` Bart Van Assche
2016-11-02 19:35 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477926635.2511.1.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@fb.com \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=keith.busch@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=roger.pau@citrix.com \
--cc=snitzer@redhat.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.