All of lore.kernel.org
 help / color / mirror / Atom feed
From: Caesar Wang <wxt@rock-chips.com>
To: seanpaul@chromium.org
Cc: zain wang <wzz@rock-chips.com>,
	tomeu.vizoso@collabora.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org, marcheu@chromium.org,
	Caesar Wang <wxt@rock-chips.com>
Subject: drm/bridge: analogix_dp: clear psr_support when disable_bridge
Date: Wed,  9 Nov 2016 11:53:34 +0800	[thread overview]
Message-ID: <1478663614-9914-1-git-send-email-wxt@rock-chips.com> (raw)

From: zain wang <wzz@rock-chips.com>

Don't run psr work during enabling bridge when you restart ui, it may make
link training fail since there is a race between them in AUX CH resource.

Signed-off-by: zain wang <wzz@rock-chips.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Sean Paul <seanpaul@chromium.org>

---
BTW:
- The training issue is gone with this patch,
  there are four machines have passed the 10000 cycles with S2R tests.
- Verified on ChromeOS kernelv4.4.

 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 6e0447f..4431f62 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1117,6 +1117,7 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge)
 	if (ret)
 		DRM_ERROR("failed to setup the panel ret = %d\n", ret);
 
+	dp->psr_support = false;
 	dp->dpms_mode = DRM_MODE_DPMS_OFF;
 }
 
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Caesar Wang <wxt@rock-chips.com>
To: seanpaul@chromium.org
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	tomeu.vizoso@collabora.com, linux-rockchip@lists.infradead.org,
	marcheu@chromium.org, zain wang <wzz@rock-chips.com>,
	Caesar Wang <wxt@rock-chips.com>
Subject: drm/bridge: analogix_dp: clear psr_support when disable_bridge
Date: Wed,  9 Nov 2016 11:53:34 +0800	[thread overview]
Message-ID: <1478663614-9914-1-git-send-email-wxt@rock-chips.com> (raw)

From: zain wang <wzz@rock-chips.com>

Don't run psr work during enabling bridge when you restart ui, it may make
link training fail since there is a race between them in AUX CH resource.

Signed-off-by: zain wang <wzz@rock-chips.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Sean Paul <seanpaul@chromium.org>

---
BTW:
- The training issue is gone with this patch,
  there are four machines have passed the 10000 cycles with S2R tests.
- Verified on ChromeOS kernelv4.4.

 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 6e0447f..4431f62 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1117,6 +1117,7 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge)
 	if (ret)
 		DRM_ERROR("failed to setup the panel ret = %d\n", ret);
 
+	dp->psr_support = false;
 	dp->dpms_mode = DRM_MODE_DPMS_OFF;
 }
 
-- 
2.7.4

             reply	other threads:[~2016-11-09  3:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09  3:53 Caesar Wang [this message]
2016-11-09  3:53 ` drm/bridge: analogix_dp: clear psr_support when disable_bridge Caesar Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478663614-9914-1-git-send-email-wxt@rock-chips.com \
    --to=wxt@rock-chips.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=marcheu@chromium.org \
    --cc=seanpaul@chromium.org \
    --cc=tomeu.vizoso@collabora.com \
    --cc=wzz@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.