All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>,
	Theodore Ts'o <tytso@mit.edu>
Cc: linux-media@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	ksummit-discuss@lists.linuxfoundation.org,
	linux-doc@vger.kernel.org
Subject: Re: [Ksummit-discuss] Including images on Sphinx documents
Date: Thu, 17 Nov 2016 11:25:38 -0500	[thread overview]
Message-ID: <1479399938.4225.28.camel@HansenPartnership.com> (raw)
In-Reply-To: <20161117131651.467943e0@vento.lan>

On Thu, 2016-11-17 at 13:16 -0200, Mauro Carvalho Chehab wrote:
> Hi Ted,
> 
> Em Thu, 17 Nov 2016 09:52:44 -0500
> Theodore Ts'o <tytso@mit.edu> escreveu:
> 
> > On Thu, Nov 17, 2016 at 12:07:15PM +0100, Arnd Bergmann wrote:
> > > [adding Linus for clarification]
> > > 
> > > I understood the concern as being about binary files that you
> > > cannot
> > > modify with classic 'patch', which is a separate issue.  
> > 
> > I think the other complaint is that the image files aren't "source"
> > in
> > the proper term, since they are *not* the preferred form for
> > modification --- that's the svg files.  Beyond the license
> > compliance
> > issues (which are satisified because the .svg files are included in
> > the git tree), there is the SCM cleaniless argument of not
> > including
> > generated files in the distribution, since this increases the
> > opportunites for the "real" source file and the generated source
> > file
> > to get out of sync.  (As just one example, if the patch can't
> > represent the change to binary file.)
> > 
> > I do check in generated files on occasion --- usually because I
> > don't
> > trust autoconf to be a stable in terms of generating a correct
> > configure file from a configure.in across different versions of
> > autoconf and different macro libraries that might be installed on
> > the
> > system.  So this isn't a hard and fast rule by any means (although
> > Linus may be more strict than I on that issue).
> > 
> > I don't understand why it's so terrible to have generate the image
> > file from the .svg file in a Makefile rule, and then copy it
> > somewhere
> > else if Sphinx is too dumb to fetch it from the normal location?
> 
> The images whose source are in .svg are now generated via Makefile
> for the PDF output (after my patches, already applied to the docs
> -next
> tree).
> 
> So, the problem that remains is for those images whose source
> is a bitmap. If we want to stick with the Sphinx supported formats,
> we have only two options for bitmaps: jpg or png. We could eventually
> use uuencode or base64 to make sure that the patches won't use
> git binary diff extension, or, as Arnd proposed, use a portable
> bitmap format, in ascii, converting via Makefile, but losing
> the alpha channel with makes the background transparent.

If it can use svg, why not use that?  SVG files can be a simple xml
wrapper around a wide variety of graphic image formats which are
embedded in the svg using the data-uri format, you know ...

Anything that handles SVGs should be able to handle all the embeddable
image formats, which should give you a way around image restrictions
whatever it is would otherwise have.

James

WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>,
	Theodore Ts'o <tytso@mit.edu>
Cc: ksummit-discuss@lists.linuxfoundation.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-media@vger.kernel.org
Subject: Re: [Ksummit-discuss] Including images on Sphinx documents
Date: Thu, 17 Nov 2016 11:25:38 -0500	[thread overview]
Message-ID: <1479399938.4225.28.camel@HansenPartnership.com> (raw)
In-Reply-To: <20161117131651.467943e0@vento.lan>

On Thu, 2016-11-17 at 13:16 -0200, Mauro Carvalho Chehab wrote:
> Hi Ted,
> 
> Em Thu, 17 Nov 2016 09:52:44 -0500
> Theodore Ts'o <tytso@mit.edu> escreveu:
> 
> > On Thu, Nov 17, 2016 at 12:07:15PM +0100, Arnd Bergmann wrote:
> > > [adding Linus for clarification]
> > > 
> > > I understood the concern as being about binary files that you
> > > cannot
> > > modify with classic 'patch', which is a separate issue.  
> > 
> > I think the other complaint is that the image files aren't "source"
> > in
> > the proper term, since they are *not* the preferred form for
> > modification --- that's the svg files.  Beyond the license
> > compliance
> > issues (which are satisified because the .svg files are included in
> > the git tree), there is the SCM cleaniless argument of not
> > including
> > generated files in the distribution, since this increases the
> > opportunites for the "real" source file and the generated source
> > file
> > to get out of sync.  (As just one example, if the patch can't
> > represent the change to binary file.)
> > 
> > I do check in generated files on occasion --- usually because I
> > don't
> > trust autoconf to be a stable in terms of generating a correct
> > configure file from a configure.in across different versions of
> > autoconf and different macro libraries that might be installed on
> > the
> > system.  So this isn't a hard and fast rule by any means (although
> > Linus may be more strict than I on that issue).
> > 
> > I don't understand why it's so terrible to have generate the image
> > file from the .svg file in a Makefile rule, and then copy it
> > somewhere
> > else if Sphinx is too dumb to fetch it from the normal location?
> 
> The images whose source are in .svg are now generated via Makefile
> for the PDF output (after my patches, already applied to the docs
> -next
> tree).
> 
> So, the problem that remains is for those images whose source
> is a bitmap. If we want to stick with the Sphinx supported formats,
> we have only two options for bitmaps: jpg or png. We could eventually
> use uuencode or base64 to make sure that the patches won't use
> git binary diff extension, or, as Arnd proposed, use a portable
> bitmap format, in ascii, converting via Makefile, but losing
> the alpha channel with makes the background transparent.

If it can use svg, why not use that?  SVG files can be a simple xml
wrapper around a wide variety of graphic image formats which are
embedded in the svg using the data-uri format, you know ...

Anything that handles SVGs should be able to handle all the embeddable
image formats, which should give you a way around image restrictions
whatever it is would otherwise have.

James


  parent reply	other threads:[~2016-11-17 16:25 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07  9:55 [Ksummit-discuss] Including images on Sphinx documents Mauro Carvalho Chehab
2016-11-07  9:55 ` Mauro Carvalho Chehab
2016-11-07 10:53 ` [Ksummit-discuss] " Jani Nikula
2016-11-07 10:53   ` Jani Nikula
2016-11-07 11:46   ` [Ksummit-discuss] " Mauro Carvalho Chehab
2016-11-07 11:46     ` Mauro Carvalho Chehab
2016-11-07 17:05     ` [Ksummit-discuss] " Josh Triplett
2016-11-07 17:05       ` Josh Triplett
2016-11-08 10:50       ` Mauro Carvalho Chehab
2016-11-08 10:50         ` Mauro Carvalho Chehab
2016-11-16 16:03         ` Arnd Bergmann
2016-11-16 16:03           ` Arnd Bergmann
2016-11-16 20:26           ` Mauro Carvalho Chehab
2016-11-16 20:26             ` Mauro Carvalho Chehab
2016-11-17 11:07             ` Arnd Bergmann
2016-11-17 11:07               ` Arnd Bergmann
2016-11-17 11:28               ` Jani Nikula
2016-11-17 11:28                 ` Jani Nikula
2016-11-17 12:39                 ` Mauro Carvalho Chehab
2016-11-17 12:39                   ` Mauro Carvalho Chehab
2016-11-17 14:52               ` Theodore Ts'o
2016-11-17 14:52                 ` Theodore Ts'o
2016-11-17 15:16                 ` Mauro Carvalho Chehab
2016-11-17 15:16                   ` Mauro Carvalho Chehab
2016-11-17 15:28                   ` Johannes Berg
2016-11-17 15:28                     ` Johannes Berg
2016-11-17 16:25                   ` James Bottomley [this message]
2016-11-17 16:25                     ` James Bottomley
2016-11-17 15:32               ` Mauro Carvalho Chehab
2016-11-17 15:32                 ` Mauro Carvalho Chehab
2016-11-17 16:02               ` Linus Torvalds
2016-11-17 16:02                 ` Linus Torvalds
2016-11-17 16:04                 ` Linus Torvalds
2016-11-17 16:04                   ` Linus Torvalds
2016-11-18  9:15                 ` Jani Nikula
2016-11-18  9:15                   ` Jani Nikula
2016-11-18 10:23                   ` Daniel Vetter
2016-11-18 10:23                     ` Daniel Vetter
2016-11-19 17:15                 ` Jonathan Corbet
2016-11-19 17:15                   ` Jonathan Corbet
2016-11-19 17:38                   ` Andrew Lunn
2016-11-19 17:38                     ` Andrew Lunn
2016-11-19 17:50                   ` Bart Van Assche
2016-11-19 17:50                     ` Bart Van Assche
2016-11-19 17:55                   ` David Woodhouse
2016-11-19 17:55                     ` David Woodhouse
2016-11-19 18:45                     ` Linus Torvalds
2016-11-19 18:45                       ` Linus Torvalds
2016-11-19 22:59                       ` David Woodhouse
2016-11-19 22:59                         ` David Woodhouse
2016-11-20 14:26                         ` Mauro Carvalho Chehab
2016-11-20 14:26                           ` Mauro Carvalho Chehab
2016-11-19 20:54                   ` Mauro Carvalho Chehab
2016-11-19 20:54                     ` Mauro Carvalho Chehab
2016-11-19 21:09                     ` Linus Torvalds
2016-11-19 21:09                       ` Linus Torvalds
2016-11-21 10:39                   ` Johannes Berg
2016-11-21 10:39                     ` Johannes Berg
2016-11-21 14:06                     ` Mauro Carvalho Chehab
2016-11-21 14:06                       ` Mauro Carvalho Chehab
2016-11-21 15:41                       ` James Bottomley
2016-11-21 15:41                         ` James Bottomley
2016-11-21 15:44                         ` Johannes Berg
2016-11-21 15:44                           ` Johannes Berg
2016-11-21 15:47                           ` Jani Nikula
2016-11-21 15:47                             ` Jani Nikula
2016-11-21 19:48                           ` Mauro Carvalho Chehab
2016-11-21 19:48                             ` Mauro Carvalho Chehab
2016-11-13 21:00     ` Jonathan Corbet
2016-11-13 21:00       ` Jonathan Corbet
2016-11-14 14:16       ` [Ksummit-discuss] " Mauro Carvalho Chehab
2016-11-14 14:16         ` Mauro Carvalho Chehab
2016-11-09 12:27   ` [Ksummit-discuss] " Mauro Carvalho Chehab
2016-11-09 12:27     ` Mauro Carvalho Chehab
2016-11-07 17:01 ` [Ksummit-discuss] " Josh Triplett
2016-11-07 17:01   ` Josh Triplett
2016-11-09  9:22   ` Markus Heiser
2016-11-09  9:22     ` Markus Heiser
2016-11-09 11:16     ` Jani Nikula
2016-11-09 11:16       ` Jani Nikula
2016-11-09 11:27       ` Mauro Carvalho Chehab
2016-11-09 11:27         ` Mauro Carvalho Chehab
2016-11-09 11:45         ` Jani Nikula
2016-11-09 11:45           ` Jani Nikula
2016-11-09 11:27       ` Markus Heiser
2016-11-09 11:27         ` Markus Heiser
2016-11-09 11:58         ` Jani Nikula
2016-11-09 11:58           ` Jani Nikula
2016-11-09 22:11           ` Markus Heiser
2016-11-09 22:11             ` Markus Heiser
2016-11-10 10:35             ` Jani Nikula
2016-11-10 10:35               ` Jani Nikula
2016-11-11 11:22               ` Jani Nikula
2016-11-11 11:22                 ` Jani Nikula
2016-11-11 11:45                 ` Markus Heiser
2016-11-11 11:45                   ` Markus Heiser
2016-11-11  9:34           ` Mauro Carvalho Chehab
2016-11-11  9:34             ` Mauro Carvalho Chehab
2016-11-13 19:52 ` Jonathan Corbet
2016-11-13 19:52   ` Jonathan Corbet
2016-11-14 13:30   ` [Ksummit-discuss] " Mauro Carvalho Chehab
2016-11-14 13:30     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479399938.4225.28.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.