All of lore.kernel.org
 help / color / mirror / Atom feed
From: tomas.hlavacek@nic.cz (tomas.hlavacek at nic.cz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] ARM: dts: add support for Turris Omnia
Date: Wed, 23 Nov 2016 23:45:20 +0100	[thread overview]
Message-ID: <1479941120.10840.13@smtp.gmail.com> (raw)
In-Reply-To: <20161123145916.GL14947@lunn.ch>

Hi Andrew!

On Wed, Nov 23, 2016 at 3:59 PM, Andrew Lunn <andrew@lunn.ch> wrote:
>>  >CZ11NIC12 is indicated on my board.
>> 
>>  :-( Well, this board version has wrongly matched length of some
>>  differential pairs, IRQ from 88E1514 is connected differently, there
>>  are slight differences in power supplies and (if I am not mistaken)
>>  something changed in RTC support circuitry. It looks like a huge
>>  mistake on our side.
> 
> Hi Tomas
> 
> Would these problems also explain why the Ethernet links to the switch
> don't work? Maybe the differential pairs?

I do not think so. The ethernet links to the switch are RGMII, not 
differential pairs. Differential pair is used only for the eth2 to link 
either SFP+ or 88E1514 (via a high-speed switch that selects one or 
another). So the problems with differential pairs affect only WAN 
interface.

> 
> 
>>  It seems that libphy is probed before pca9538 and we end up with:
>>  [    4.217550] libphy: orion_mdio_bus: probed
>>  [    4.221777] irq: no irq domain found for
>>  /soc/internal-regs/i2c at 11000/i2cmux at 70/i2c at 7/gpio at 71 !
>> 
>>  Any clue where to look in order to defer probing libphy or at least
>>  orion_mdio_bus?
> 
> I think there is a known phylib problem here. Somewhere in the call
> chain there is a void function, so the EPROBE_DEFFER gets
> discarded. But i could be remembering this wrongly.

Oh yes, I thought that and I tried to find exactly this type of problem 
yesterday, but I didn't succeed. But I think that we agreed that we are 
going to stick with PHY polling rather then experimenting with 
unreliable IRQ over the GPIO expander, so we can leave this unresolved.

I will look into the I2C mux concerns, fix the remaining comments 
regarding my version and test RTC more extensively - Uwe's board is 
still not ticking, mine does, so we have to rule out that it is a 
common problem.

Tomas

WARNING: multiple messages have this Message-ID (diff)
From: tomas.hlavacek@nic.cz
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	marex@denx.de, "Jason Cooper" <jason@lakedaemon.net>,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>,
	devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
	"Gregory Clement" <gregory.clement@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH RFC] ARM: dts: add support for Turris Omnia
Date: Wed, 23 Nov 2016 23:45:20 +0100	[thread overview]
Message-ID: <1479941120.10840.13@smtp.gmail.com> (raw)
In-Reply-To: <20161123145916.GL14947@lunn.ch>

Hi Andrew!

On Wed, Nov 23, 2016 at 3:59 PM, Andrew Lunn <andrew@lunn.ch> wrote:
>>  >CZ11NIC12 is indicated on my board.
>> 
>>  :-( Well, this board version has wrongly matched length of some
>>  differential pairs, IRQ from 88E1514 is connected differently, there
>>  are slight differences in power supplies and (if I am not mistaken)
>>  something changed in RTC support circuitry. It looks like a huge
>>  mistake on our side.
> 
> Hi Tomas
> 
> Would these problems also explain why the Ethernet links to the switch
> don't work? Maybe the differential pairs?

I do not think so. The ethernet links to the switch are RGMII, not 
differential pairs. Differential pair is used only for the eth2 to link 
either SFP+ or 88E1514 (via a high-speed switch that selects one or 
another). So the problems with differential pairs affect only WAN 
interface.

> 
> 
>>  It seems that libphy is probed before pca9538 and we end up with:
>>  [    4.217550] libphy: orion_mdio_bus: probed
>>  [    4.221777] irq: no irq domain found for
>>  /soc/internal-regs/i2c@11000/i2cmux@70/i2c@7/gpio@71 !
>> 
>>  Any clue where to look in order to defer probing libphy or at least
>>  orion_mdio_bus?
> 
> I think there is a known phylib problem here. Somewhere in the call
> chain there is a void function, so the EPROBE_DEFFER gets
> discarded. But i could be remembering this wrongly.

Oh yes, I thought that and I tried to find exactly this type of problem 
yesterday, but I didn't succeed. But I think that we agreed that we are 
going to stick with PHY polling rather then experimenting with 
unreliable IRQ over the GPIO expander, so we can leave this unresolved.

I will look into the I2C mux concerns, fix the remaining comments 
regarding my version and test RTC more extensively - Uwe's board is 
still not ticking, mine does, so we have to rule out that it is a 
common problem.

Tomas

  parent reply	other threads:[~2016-11-23 22:45 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-05 20:38 [PATCH RFC] ARM: dts: add support for Turris Omnia Uwe Kleine-König
2016-11-05 20:38 ` Uwe Kleine-König
2016-11-05 21:04 ` Andrew Lunn
2016-11-05 21:04   ` Andrew Lunn
2016-11-05 22:08   ` Uwe Kleine-König
2016-11-05 22:08     ` Uwe Kleine-König
2016-11-06 10:19     ` Andrew Lunn
2016-11-06 10:19       ` Andrew Lunn
2016-11-05 21:23 ` Andrew Lunn
2016-11-05 21:23   ` Andrew Lunn
2016-11-05 21:27   ` Uwe Kleine-König
2016-11-05 21:27     ` Uwe Kleine-König
2016-11-05 21:37     ` Andrew Lunn
2016-11-05 21:37       ` Andrew Lunn
     [not found]     ` <20161106104534.lsdyppz5qcnjcqe4@perseus.defre.kleine-koenig.org>
     [not found]       ` <20161106111109.GD9617@lunn.ch>
     [not found]         ` <20161106141716.fwgje74rhhixnixq@perseus.defre.kleine-koenig.org>
     [not found]           ` <20161106162809.GA14042@lunn.ch>
2016-11-06 19:32             ` Uwe Kleine-König
2016-11-06 19:32               ` Uwe Kleine-König
2016-11-07  7:41     ` Martin Strbačka
2016-11-07  7:41       ` Martin Strbačka
2016-11-14 12:23 ` tomas.hlavacek at nic.cz
2016-11-14 12:23   ` tomas.hlavacek-x+rMaJPWets
2016-11-14 13:10   ` Andrew Lunn
2016-11-14 13:10     ` Andrew Lunn
2016-11-14 14:51     ` tomas.hlavacek
2016-11-14 14:59     ` tomas.hlavacek at nic.cz
2016-11-14 14:59       ` tomas.hlavacek
2016-11-14 20:16   ` Uwe Kleine-König
2016-11-14 20:16     ` Uwe Kleine-König
2016-11-14 20:28     ` Andrew Lunn
2016-11-14 20:28       ` Andrew Lunn
2016-11-19 20:09       ` tomas.hlavacek at nic.cz
2016-11-19 20:09         ` tomas.hlavacek-x+rMaJPWets
2016-11-20 20:30         ` Uwe Kleine-König
2016-11-20 20:30           ` Uwe Kleine-König
2016-11-22 21:59           ` tomas.hlavacek at nic.cz
2016-11-22 21:59             ` tomas.hlavacek
2016-11-23  0:09             ` [RFC PATCH] ARM: dts: Add " Tomas Hlavacek
2016-11-23  0:09               ` Tomas Hlavacek
2016-11-23  0:09               ` Tomas Hlavacek
2016-11-23  0:35               ` Andrew Lunn
2016-11-23  0:35                 ` Andrew Lunn
2016-11-24  8:37                 ` Uwe Kleine-König
2016-11-24  8:37                   ` Uwe Kleine-König
2016-11-24 15:07                   ` Andrew Lunn
2016-11-24 15:07                     ` Andrew Lunn
2016-11-25 12:49                     ` Tomas Hlavacek
2016-11-25 12:49                       ` Tomas Hlavacek
2016-11-25 12:49                       ` Tomas Hlavacek
2016-11-25 14:34                       ` Uwe Kleine-König
2016-12-10  8:16                       ` Pavel Machek
2016-12-10  8:16                         ` Pavel Machek
2016-12-10  8:16                         ` Pavel Machek
2016-11-23  8:19               ` Uwe Kleine-König
2016-11-23  8:19                 ` Uwe Kleine-König
2016-11-23  8:19                 ` Uwe Kleine-König
2016-11-23  0:27             ` [PATCH RFC] ARM: dts: add " tomas.hlavacek at nic.cz
2016-11-23  0:27               ` tomas.hlavacek-x+rMaJPWets
2016-11-23  1:39               ` Andrew Lunn
2016-11-23  1:39                 ` Andrew Lunn
2016-11-23 14:59             ` Andrew Lunn
2016-11-23 14:59               ` Andrew Lunn
2016-11-23 18:36               ` Uwe Kleine-König
2016-11-23 18:36                 ` Uwe Kleine-König
2016-11-23 22:45               ` tomas.hlavacek at nic.cz [this message]
2016-11-23 22:45                 ` tomas.hlavacek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479941120.10840.13@smtp.gmail.com \
    --to=tomas.hlavacek@nic.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.