All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: dts: Add support for Turris Omnia
Date: Wed, 23 Nov 2016 01:35:05 +0100	[thread overview]
Message-ID: <20161123003505.GL2691@lunn.ch> (raw)
In-Reply-To: <1479859770-9375-1-git-send-email-tmshlvck@gmail.com>

> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -0,0 +1,279 @@
> +/*
> + * Device Tree file for the Turris Omnia
> + * Schematic available at https://www.turris.cz/doc/_media/rtrom01-schema.pdf

Hi Tomas

Cool that there is a link to the schematics. But please could you put
it lower down. It is more likely to be seen if it comes after the
copyright and license section.

> +			sdhci at d8000 {
> +				pinctrl-names = "default";
> +				pinctrl-0 = <&sdhci_pins>;
> +				status = "okay";
> +
> +				bus-width = <8>;
> +				no-1-8-v;
> +				non-removable;
> +			};

> +&i2c0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&i2c0_pins>;
> +	status = "okay";
> +
> +	i2cmux at 70 {
> +		compatible = "nxp,pca9547";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <0x70>;
> +		status = "okay";
> +
> +		/* Channel 1: Routed to PCIe0/mSATA connector (CN7A).
> +		 * Channel 2: Routed to PCIe1/USB2 connector (CN61A).
> +		 * Channel 3: Routed to PCIe2 connector (CN62A).
> +		 * Channel 4: Routed to SFP+.
> +		 * Channel 5: ATSHA204A at address 0x64.
> +		 * Channel 6: Routed to user pin header CN11.
> +		 */

I've not looked at how the pca9547 works.... Will it instantiate a bus
only if there is a node in the device tree with a reg property?

What i'm thinking is that it is possible to indicate to the i2c core
that a device is on a bus using echo to a file. But this only works if
the bus exists. You could for example say using echo that there is an
at24 EEPROM on channel 4 and get access to the EEPROM inside the SFP
module. But that only works if the i2c bus exists. Does it?

No leds? No buttons via gpio-keys?

   Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Tomas Hlavacek <tmshlvck@gmail.com>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Jason Cooper" <jason@lakedaemon.net>,
	"Gregory Clement" <gregory.clement@free-electrons.com>,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] ARM: dts: Add support for Turris Omnia
Date: Wed, 23 Nov 2016 01:35:05 +0100	[thread overview]
Message-ID: <20161123003505.GL2691@lunn.ch> (raw)
In-Reply-To: <1479859770-9375-1-git-send-email-tmshlvck@gmail.com>

> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -0,0 +1,279 @@
> +/*
> + * Device Tree file for the Turris Omnia
> + * Schematic available at https://www.turris.cz/doc/_media/rtrom01-schema.pdf

Hi Tomas

Cool that there is a link to the schematics. But please could you put
it lower down. It is more likely to be seen if it comes after the
copyright and license section.

> +			sdhci@d8000 {
> +				pinctrl-names = "default";
> +				pinctrl-0 = <&sdhci_pins>;
> +				status = "okay";
> +
> +				bus-width = <8>;
> +				no-1-8-v;
> +				non-removable;
> +			};

> +&i2c0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&i2c0_pins>;
> +	status = "okay";
> +
> +	i2cmux@70 {
> +		compatible = "nxp,pca9547";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <0x70>;
> +		status = "okay";
> +
> +		/* Channel 1: Routed to PCIe0/mSATA connector (CN7A).
> +		 * Channel 2: Routed to PCIe1/USB2 connector (CN61A).
> +		 * Channel 3: Routed to PCIe2 connector (CN62A).
> +		 * Channel 4: Routed to SFP+.
> +		 * Channel 5: ATSHA204A at address 0x64.
> +		 * Channel 6: Routed to user pin header CN11.
> +		 */

I've not looked at how the pca9547 works.... Will it instantiate a bus
only if there is a node in the device tree with a reg property?

What i'm thinking is that it is possible to indicate to the i2c core
that a device is on a bus using echo to a file. But this only works if
the bus exists. You could for example say using echo that there is an
at24 EEPROM on channel 4 and get access to the EEPROM inside the SFP
module. But that only works if the i2c bus exists. Does it?

No leds? No buttons via gpio-keys?

   Andrew

  reply	other threads:[~2016-11-23  0:35 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-05 20:38 [PATCH RFC] ARM: dts: add support for Turris Omnia Uwe Kleine-König
2016-11-05 20:38 ` Uwe Kleine-König
2016-11-05 21:04 ` Andrew Lunn
2016-11-05 21:04   ` Andrew Lunn
2016-11-05 22:08   ` Uwe Kleine-König
2016-11-05 22:08     ` Uwe Kleine-König
2016-11-06 10:19     ` Andrew Lunn
2016-11-06 10:19       ` Andrew Lunn
2016-11-05 21:23 ` Andrew Lunn
2016-11-05 21:23   ` Andrew Lunn
2016-11-05 21:27   ` Uwe Kleine-König
2016-11-05 21:27     ` Uwe Kleine-König
2016-11-05 21:37     ` Andrew Lunn
2016-11-05 21:37       ` Andrew Lunn
     [not found]     ` <20161106104534.lsdyppz5qcnjcqe4@perseus.defre.kleine-koenig.org>
     [not found]       ` <20161106111109.GD9617@lunn.ch>
     [not found]         ` <20161106141716.fwgje74rhhixnixq@perseus.defre.kleine-koenig.org>
     [not found]           ` <20161106162809.GA14042@lunn.ch>
2016-11-06 19:32             ` Uwe Kleine-König
2016-11-06 19:32               ` Uwe Kleine-König
2016-11-07  7:41     ` Martin Strbačka
2016-11-07  7:41       ` Martin Strbačka
2016-11-14 12:23 ` tomas.hlavacek at nic.cz
2016-11-14 12:23   ` tomas.hlavacek-x+rMaJPWets
2016-11-14 13:10   ` Andrew Lunn
2016-11-14 13:10     ` Andrew Lunn
2016-11-14 14:51     ` tomas.hlavacek
2016-11-14 14:59     ` tomas.hlavacek at nic.cz
2016-11-14 14:59       ` tomas.hlavacek
2016-11-14 20:16   ` Uwe Kleine-König
2016-11-14 20:16     ` Uwe Kleine-König
2016-11-14 20:28     ` Andrew Lunn
2016-11-14 20:28       ` Andrew Lunn
2016-11-19 20:09       ` tomas.hlavacek at nic.cz
2016-11-19 20:09         ` tomas.hlavacek-x+rMaJPWets
2016-11-20 20:30         ` Uwe Kleine-König
2016-11-20 20:30           ` Uwe Kleine-König
2016-11-22 21:59           ` tomas.hlavacek at nic.cz
2016-11-22 21:59             ` tomas.hlavacek
2016-11-23  0:09             ` [RFC PATCH] ARM: dts: Add " Tomas Hlavacek
2016-11-23  0:09               ` Tomas Hlavacek
2016-11-23  0:09               ` Tomas Hlavacek
2016-11-23  0:35               ` Andrew Lunn [this message]
2016-11-23  0:35                 ` Andrew Lunn
2016-11-24  8:37                 ` Uwe Kleine-König
2016-11-24  8:37                   ` Uwe Kleine-König
2016-11-24 15:07                   ` Andrew Lunn
2016-11-24 15:07                     ` Andrew Lunn
2016-11-25 12:49                     ` Tomas Hlavacek
2016-11-25 12:49                       ` Tomas Hlavacek
2016-11-25 12:49                       ` Tomas Hlavacek
2016-11-25 14:34                       ` Uwe Kleine-König
2016-12-10  8:16                       ` Pavel Machek
2016-12-10  8:16                         ` Pavel Machek
2016-12-10  8:16                         ` Pavel Machek
2016-11-23  8:19               ` Uwe Kleine-König
2016-11-23  8:19                 ` Uwe Kleine-König
2016-11-23  8:19                 ` Uwe Kleine-König
2016-11-23  0:27             ` [PATCH RFC] ARM: dts: add " tomas.hlavacek at nic.cz
2016-11-23  0:27               ` tomas.hlavacek-x+rMaJPWets
2016-11-23  1:39               ` Andrew Lunn
2016-11-23  1:39                 ` Andrew Lunn
2016-11-23 14:59             ` Andrew Lunn
2016-11-23 14:59               ` Andrew Lunn
2016-11-23 18:36               ` Uwe Kleine-König
2016-11-23 18:36                 ` Uwe Kleine-König
2016-11-23 22:45               ` tomas.hlavacek at nic.cz
2016-11-23 22:45                 ` tomas.hlavacek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161123003505.GL2691@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.