From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging: bcm2835-audio: fix trailing statements
Date: Fri, 10 Feb 2017 09:18:46 -0800 [thread overview]
Message-ID: <1486747126.2192.7.camel@perches.com> (raw)
In-Reply-To: <20170210161425.5711-1-abdallah.meziti.pro@gmail.com>
On Fri, 2017-02-10 at 17:14 +0100, AbdAllah-MEZITI wrote:
> Trailing statements should be on next line.
[]
> diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
[]
> @@ -563,7 +563,8 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip)
> } else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) {
> LOG_ERR("Couldn't set the controls for stream %d\n", i);
> ret = -1;
> - } else LOG_DBG(" Controls set for stream %d\n", i);
> + } else
> + LOG_DBG(" Controls set for stream %d\n", i);
> }
> }
> LOG_DBG(" .. OUT ret=%d\n", ret);
It's curious that checkpatch doesn't catch this and
ideally this would also use braces for the last else.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>,
gregkh@linuxfoundation.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>,
Michael Zoran <mzoran@crowfest.net>,
Dan Carpenter <dan.carpenter@oracle.com>,
Michael Rupprecht <mail.michaelrupprecht@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
Seraphime Kirkovski <kirkseraph@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
devel@driverdev.osuosl.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: bcm2835-audio: fix trailing statements
Date: Fri, 10 Feb 2017 09:18:46 -0800 [thread overview]
Message-ID: <1486747126.2192.7.camel@perches.com> (raw)
In-Reply-To: <20170210161425.5711-1-abdallah.meziti.pro@gmail.com>
On Fri, 2017-02-10 at 17:14 +0100, AbdAllah-MEZITI wrote:
> Trailing statements should be on next line.
[]
> diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
[]
> @@ -563,7 +563,8 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip)
> } else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) {
> LOG_ERR("Couldn't set the controls for stream %d\n", i);
> ret = -1;
> - } else LOG_DBG(" Controls set for stream %d\n", i);
> + } else
> + LOG_DBG(" Controls set for stream %d\n", i);
> }
> }
> LOG_DBG(" .. OUT ret=%d\n", ret);
It's curious that checkpatch doesn't catch this and
ideally this would also use braces for the last else.
next prev parent reply other threads:[~2017-02-10 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 16:14 [PATCH] staging: bcm2835-audio: fix trailing statements AbdAllah-MEZITI
2017-02-10 16:14 ` AbdAllah-MEZITI
2017-02-10 17:18 ` Joe Perches [this message]
2017-02-10 17:18 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486747126.2192.7.camel@perches.com \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.