* [PATCH] staging: bcm2835-audio: fix trailing statements @ 2017-02-10 16:14 ` AbdAllah-MEZITI 0 siblings, 0 replies; 4+ messages in thread From: AbdAllah-MEZITI @ 2017-02-10 16:14 UTC (permalink / raw) To: linux-arm-kernel Trailing statements should be on next line. Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com> --- drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c index 6578246..95ad58c 100644 --- a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c +++ b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c @@ -563,7 +563,8 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip) } else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) { LOG_ERR("Couldn't set the controls for stream %d\n", i); ret = -1; - } else LOG_DBG(" Controls set for stream %d\n", i); + } else + LOG_DBG(" Controls set for stream %d\n", i); } } LOG_DBG(" .. OUT ret=%d\n", ret); -- 2.9.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] staging: bcm2835-audio: fix trailing statements @ 2017-02-10 16:14 ` AbdAllah-MEZITI 0 siblings, 0 replies; 4+ messages in thread From: AbdAllah-MEZITI @ 2017-02-10 16:14 UTC (permalink / raw) To: gregkh Cc: Florian Fainelli, Ray Jui, Scott Branden, bcm-kernel-feedback-list, Stephen Warren, Lee Jones, Eric Anholt, Michael Zoran, Dan Carpenter, Michael Rupprecht, Colin Ian King, Seraphime Kirkovski, Arnd Bergmann, devel, linux-rpi-kernel, linux-arm-kernel, linux-kernel Trailing statements should be on next line. Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com> --- drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c index 6578246..95ad58c 100644 --- a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c +++ b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c @@ -563,7 +563,8 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip) } else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) { LOG_ERR("Couldn't set the controls for stream %d\n", i); ret = -1; - } else LOG_DBG(" Controls set for stream %d\n", i); + } else + LOG_DBG(" Controls set for stream %d\n", i); } } LOG_DBG(" .. OUT ret=%d\n", ret); -- 2.9.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] staging: bcm2835-audio: fix trailing statements 2017-02-10 16:14 ` AbdAllah-MEZITI @ 2017-02-10 17:18 ` Joe Perches -1 siblings, 0 replies; 4+ messages in thread From: Joe Perches @ 2017-02-10 17:18 UTC (permalink / raw) To: linux-arm-kernel On Fri, 2017-02-10 at 17:14 +0100, AbdAllah-MEZITI wrote: > Trailing statements should be on next line. [] > diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c [] > @@ -563,7 +563,8 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip) > } else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) { > LOG_ERR("Couldn't set the controls for stream %d\n", i); > ret = -1; > - } else LOG_DBG(" Controls set for stream %d\n", i); > + } else > + LOG_DBG(" Controls set for stream %d\n", i); > } > } > LOG_DBG(" .. OUT ret=%d\n", ret); It's curious that checkpatch doesn't catch this and ideally this would also use braces for the last else. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: bcm2835-audio: fix trailing statements @ 2017-02-10 17:18 ` Joe Perches 0 siblings, 0 replies; 4+ messages in thread From: Joe Perches @ 2017-02-10 17:18 UTC (permalink / raw) To: AbdAllah-MEZITI, gregkh Cc: Florian Fainelli, Ray Jui, Scott Branden, bcm-kernel-feedback-list, Stephen Warren, Lee Jones, Eric Anholt, Michael Zoran, Dan Carpenter, Michael Rupprecht, Colin Ian King, Seraphime Kirkovski, Arnd Bergmann, devel, linux-rpi-kernel, linux-arm-kernel, linux-kernel On Fri, 2017-02-10 at 17:14 +0100, AbdAllah-MEZITI wrote: > Trailing statements should be on next line. [] > diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c [] > @@ -563,7 +563,8 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip) > } else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) { > LOG_ERR("Couldn't set the controls for stream %d\n", i); > ret = -1; > - } else LOG_DBG(" Controls set for stream %d\n", i); > + } else > + LOG_DBG(" Controls set for stream %d\n", i); > } > } > LOG_DBG(" .. OUT ret=%d\n", ret); It's curious that checkpatch doesn't catch this and ideally this would also use braces for the last else. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-10 17:20 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-02-10 16:14 [PATCH] staging: bcm2835-audio: fix trailing statements AbdAllah-MEZITI 2017-02-10 16:14 ` AbdAllah-MEZITI 2017-02-10 17:18 ` Joe Perches 2017-02-10 17:18 ` Joe Perches
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.