* [PATCH] Staging: ks7010: There should be no spaces at the start of a line @ 2017-02-18 16:40 Arushi Singhal 2017-02-18 16:57 ` Greg KH 2017-02-18 17:00 ` [Outreachy kernel] " Julia Lawall 0 siblings, 2 replies; 7+ messages in thread From: Arushi Singhal @ 2017-02-18 16:40 UTC (permalink / raw) To: gregkh; +Cc: devel, linux-kernel, outreachy-kernel The following patch the checkpatch.pl warning: drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the start of a line Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 819e08b5fa91..3b2e28749b63 100644 --- a/drivers/staging/ks7010/ks_hostif.c +++ b/drivers/staging/ks7010/ks_hostif.c @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) } DPRINTK(4, "\n Link AP\n"); DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); +essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); DPRINTK(4, "\n Link AP\n rsn.mode=%d\n rsn.size=%d\n", ap_info->rsn_mode, ap_info->rsn.size); DPRINTK(4, "\n ext_rate_set_size=%d\n rate_set_size=%d\n", -- 2.11.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Staging: ks7010: There should be no spaces at the start of a line 2017-02-18 16:40 [PATCH] Staging: ks7010: There should be no spaces at the start of a line Arushi Singhal @ 2017-02-18 16:57 ` Greg KH 2017-02-19 15:18 ` Arushi Singhal 2017-02-18 17:00 ` [Outreachy kernel] " Julia Lawall 1 sibling, 1 reply; 7+ messages in thread From: Greg KH @ 2017-02-18 16:57 UTC (permalink / raw) To: Arushi Singhal; +Cc: devel, outreachy-kernel, linux-kernel On Sat, Feb 18, 2017 at 10:10:02PM +0530, Arushi Singhal wrote: > The following patch the checkpatch.pl warning: > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > start of a line > > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> > --- > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > index 819e08b5fa91..3b2e28749b63 100644 > --- a/drivers/staging/ks7010/ks_hostif.c > +++ b/drivers/staging/ks7010/ks_hostif.c > @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) > } > DPRINTK(4, "\n Link AP\n"); > DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ > - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); > +essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); So don't just remove the spaces, fix it correctly with the proper indentation please. thanks, greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Staging: ks7010: There should be no spaces at the start of a line 2017-02-18 16:57 ` Greg KH @ 2017-02-19 15:18 ` Arushi Singhal 2017-02-19 15:34 ` [Outreachy kernel] " Julia Lawall 0 siblings, 1 reply; 7+ messages in thread From: Arushi Singhal @ 2017-02-19 15:18 UTC (permalink / raw) To: outreachy-kernel; +Cc: arushisinghal19971997, devel, linux-kernel [-- Attachment #1.1: Type: text/plain, Size: 2158 bytes --] Hi Greg I think we cannot indent the text otherwise, the print statement will be different as it should be Thanks On Saturday, February 18, 2017 at 10:27:19 PM UTC+5:30, gregkh wrote: > > On Sat, Feb 18, 2017 at 10:10:02PM +0530, Arushi Singhal wrote: > > The following patch the checkpatch.pl warning: > > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > > start of a line > > > > Signed-off-by: Arushi Singhal <arushising...@gmail.com> > > --- > > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/ks7010/ks_hostif.c > b/drivers/staging/ks7010/ks_hostif.c > > index 819e08b5fa91..3b2e28749b63 100644 > > --- a/drivers/staging/ks7010/ks_hostif.c > > +++ b/drivers/staging/ks7010/ks_hostif.c > > @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, > struct link_ap_info_t *ap_info) > > } > > DPRINTK(4, "\n Link AP\n"); > > DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ > > - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n > channel=%d\n \ > > - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], > ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], > &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], > ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], > ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], > ap->channel, ap->rssi, ap->sq, ap->capability); > > +essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n > channel=%d\n \ > > +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], > ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], > &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], > ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], > ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], > ap->channel, ap->rssi, ap->sq, ap->capability); > > So don't just remove the spaces, fix it correctly with the proper > indentation please. > > thanks, > > greg k-h > [-- Attachment #1.2: Type: text/html, Size: 2734 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Staging: ks7010: There should be no spaces at the start of a line 2017-02-19 15:18 ` Arushi Singhal @ 2017-02-19 15:34 ` Julia Lawall 0 siblings, 0 replies; 7+ messages in thread From: Julia Lawall @ 2017-02-19 15:34 UTC (permalink / raw) To: Arushi Singhal; +Cc: outreachy-kernel, devel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 3314 bytes --] On Sun, 19 Feb 2017, Arushi Singhal wrote: > > Hi Greg > I think we cannot indent the text otherwise, the print statement will be > different as it should be There are newlines in the printed string. I suspect that there is no need to print them all at once. Actually, your change removed spaces inside a string, so it did change the form of the poutput. Also, remember not to top post :) julia > Thanks > > On Saturday, February 18, 2017 at 10:27:19 PM UTC+5:30, gregkh wrote: > On Sat, Feb 18, 2017 at 10:10:02PM +0530, Arushi Singhal wrote: > > The following patch the checkpatch.pl warning: > > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces > at the > > start of a line > > > > Signed-off-by: Arushi Singhal <arushising...@gmail.com> > > --- > > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/ks7010/ks_hostif.c > b/drivers/staging/ks7010/ks_hostif.c > > index 819e08b5fa91..3b2e28749b63 100644 > > --- a/drivers/staging/ks7010/ks_hostif.c > > +++ b/drivers/staging/ks7010/ks_hostif.c > > @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private > *priv, struct link_ap_info_t *ap_info) > > } > > DPRINTK(4, "\n Link AP\n"); > > DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n > \ > > - essid=%s\n > rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n > channel=%d\n \ > > - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], > ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], > ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], > ap->rate_set.body[1], ap->rate_set.body[2], > ap->rate_set.body[3], ap->rate_set.body[4], > ap->rate_set.body[5], ap->rate_set.body[6], > ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, > ap->capability); > > +essid=%s\n > rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n > channel=%d\n \ > > +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], > ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], > ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], > ap->rate_set.body[1], ap->rate_set.body[2], > ap->rate_set.body[3], ap->rate_set.body[4], > ap->rate_set.body[5], ap->rate_set.body[6], > ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, > ap->capability); > > So don't just remove the spaces, fix it correctly with the > proper > indentation please. > > thanks, > > greg k-h > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/df1dbfa6-0823-4899-b1b7- > 4358b18575be%40googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: ks7010: There should be no spaces at the start of a line 2017-02-18 16:40 [PATCH] Staging: ks7010: There should be no spaces at the start of a line Arushi Singhal 2017-02-18 16:57 ` Greg KH @ 2017-02-18 17:00 ` Julia Lawall 2017-02-19 18:27 ` Joe Perches 1 sibling, 1 reply; 7+ messages in thread From: Julia Lawall @ 2017-02-18 17:00 UTC (permalink / raw) To: Arushi Singhal; +Cc: gregkh, devel, linux-kernel, outreachy-kernel On Sat, 18 Feb 2017, Arushi Singhal wrote: > The following patch the checkpatch.pl warning: > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > start of a line > > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> > --- > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > index 819e08b5fa91..3b2e28749b63 100644 > --- a/drivers/staging/ks7010/ks_hostif.c > +++ b/drivers/staging/ks7010/ks_hostif.c > @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) > } > DPRINTK(4, "\n Link AP\n"); > DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ > - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); > +essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); The code looks like a mess. How about breaking up the call at the newlines, and then propagating the arguments to the appropriate calls. There is also a checkpatch error about strings on more than one line, that this also violates. julia > DPRINTK(4, "\n Link AP\n rsn.mode=%d\n rsn.size=%d\n", > ap_info->rsn_mode, ap_info->rsn.size); > DPRINTK(4, "\n ext_rate_set_size=%d\n rate_set_size=%d\n", > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218164002.GA7269%40arushi-HP-Pavilion-Notebook. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: ks7010: There should be no spaces at the start of a line 2017-02-18 17:00 ` [Outreachy kernel] " Julia Lawall @ 2017-02-19 18:27 ` Joe Perches 0 siblings, 0 replies; 7+ messages in thread From: Joe Perches @ 2017-02-19 18:27 UTC (permalink / raw) To: Julia Lawall, Arushi Singhal Cc: gregkh, devel, linux-kernel, outreachy-kernel On Sat, 2017-02-18 at 18:00 +0100, Julia Lawall wrote: > On Sat, 18 Feb 2017, Arushi Singhal wrote: > > The following patch the checkpatch.pl warning: > > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > > start of a line [] > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c [] > > @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) > > } > > DPRINTK(4, "\n Link AP\n"); > > DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ > > - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > > - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid > > +essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > > +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); > > The code looks like a mess. How about breaking up the call at the > newlines, and then propagating the arguments to the appropriate calls. > > There is also a checkpatch error about strings on more than one line, that > this also violates. There are also vsprintf %p<foo> extensions that would simplify the code for this output and for many others. see Documentation/printk-formats.txt something like: DPRINTK(4, " bssid=%pM\n",�ap->bssid); DPRINTK(4, " essid=%s\n", ap->ssid.body); DPRINTK(4, " rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n", ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7]); DPRINTK(4, " channel=%d\n",�ap->channel); DPRINTK(4, " rssi=%d\n",�ap->rssi); DPRINTK(4, " sq=%d\n",�ap->sq); DPRINTK(4, " capability=%04X\n",�ap->capability); ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: ks7010: There should be no spaces at the start of a line @ 2017-02-19 18:27 ` Joe Perches 0 siblings, 0 replies; 7+ messages in thread From: Joe Perches @ 2017-02-19 18:27 UTC (permalink / raw) To: Julia Lawall, Arushi Singhal Cc: gregkh, devel, linux-kernel, outreachy-kernel On Sat, 2017-02-18 at 18:00 +0100, Julia Lawall wrote: > On Sat, 18 Feb 2017, Arushi Singhal wrote: > > The following patch the checkpatch.pl warning: > > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > > start of a line [] > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c [] > > @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) > > } > > DPRINTK(4, "\n Link AP\n"); > > DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ > > - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > > - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid > > +essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > > +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); > > The code looks like a mess. How about breaking up the call at the > newlines, and then propagating the arguments to the appropriate calls. > > There is also a checkpatch error about strings on more than one line, that > this also violates. There are also vsprintf %p<foo> extensions that would simplify the code for this output and for many others. see Documentation/printk-formats.txt something like: DPRINTK(4, " bssid=%pM\n", ap->bssid); DPRINTK(4, " essid=%s\n", ap->ssid.body); DPRINTK(4, " rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n", ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7]); DPRINTK(4, " channel=%d\n", ap->channel); DPRINTK(4, " rssi=%d\n", ap->rssi); DPRINTK(4, " sq=%d\n", ap->sq); DPRINTK(4, " capability=%04X\n", ap->capability); ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-02-19 18:53 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-02-18 16:40 [PATCH] Staging: ks7010: There should be no spaces at the start of a line Arushi Singhal 2017-02-18 16:57 ` Greg KH 2017-02-19 15:18 ` Arushi Singhal 2017-02-19 15:34 ` [Outreachy kernel] " Julia Lawall 2017-02-18 17:00 ` [Outreachy kernel] " Julia Lawall 2017-02-19 18:27 ` Joe Perches 2017-02-19 18:27 ` Joe Perches
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.