From: Alexey.Brodkin@synopsys.com (Alexey Brodkin)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property
Date: Fri, 3 Mar 2017 17:48:19 +0000 [thread overview]
Message-ID: <1488563298.2940.33.camel@synopsys.com> (raw)
In-Reply-To: <20170303162837.GO917@e110455-lin.cambridge.arm.com>
Hi Liviu,
On Fri, 2017-03-03@16:28 +0000, Liviu Dudau wrote:
> On Fri, Mar 03, 2017@06:19:24PM +0300, Alexey Brodkin wrote:
> >
> > - /* find the encoder node and initialize it */
> > - encoder_node = of_parse_phandle(drm->dev->of_node, "encoder-slave", 0);
> > - if (encoder_node) {
> > - ret = arcpgu_drm_hdmi_init(drm, encoder_node);
> > - of_node_put(encoder_node);
> > + /* There is only one output port inside each device, find it */
> > + port = of_graph_get_next_endpoint(pdev->dev.of_node, NULL);
> > +
> > + if (port) {
> > + if (of_device_is_available(port))
> > + encoder = of_graph_get_remote_port_parent(port);
> > + of_node_put(port);
> > + }
>
> You must've been looking at some old version. Current version in -next uses
> of_graph_get_remote_node() to replace all those lines you have added (see Rob
> Herring's series to introduce of_graph_get_remote_node() function)
Hm, I'm not on Linus' master tree [1] and so I thought I was quite up to date :)
Still I made a check of linux-next and don't see any changes in
"drivers/gpu/drm/arm" compared to Linus' tree.
[1]?http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642
[2]?http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642
Could you please clarify which exact tree did you mean?
Anyways I just tried to rebase my patch on top of linux-next tree and now
video output is broken for me - I only see some garbage on top of the screen
so I'll need to investigate it first before moving forward with stuff you
proposed :)
-Alexey
WARNING: multiple messages have this Message-ID (diff)
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "Liviu.Dudau@arm.com" <Liviu.Dudau@arm.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"airlied@linux.ie" <airlied@linux.ie>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property
Date: Fri, 3 Mar 2017 17:48:19 +0000 [thread overview]
Message-ID: <1488563298.2940.33.camel@synopsys.com> (raw)
In-Reply-To: <20170303162837.GO917@e110455-lin.cambridge.arm.com>
Hi Liviu,
On Fri, 2017-03-03 at 16:28 +0000, Liviu Dudau wrote:
> On Fri, Mar 03, 2017 at 06:19:24PM +0300, Alexey Brodkin wrote:
> >
> > - /* find the encoder node and initialize it */
> > - encoder_node = of_parse_phandle(drm->dev->of_node, "encoder-slave", 0);
> > - if (encoder_node) {
> > - ret = arcpgu_drm_hdmi_init(drm, encoder_node);
> > - of_node_put(encoder_node);
> > + /* There is only one output port inside each device, find it */
> > + port = of_graph_get_next_endpoint(pdev->dev.of_node, NULL);
> > +
> > + if (port) {
> > + if (of_device_is_available(port))
> > + encoder = of_graph_get_remote_port_parent(port);
> > + of_node_put(port);
> > + }
>
> You must've been looking at some old version. Current version in -next uses
> of_graph_get_remote_node() to replace all those lines you have added (see Rob
> Herring's series to introduce of_graph_get_remote_node() function)
Hm, I'm not on Linus' master tree [1] and so I thought I was quite up to date :)
Still I made a check of linux-next and don't see any changes in
"drivers/gpu/drm/arm" compared to Linus' tree.
[1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642
[2] http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642
Could you please clarify which exact tree did you mean?
Anyways I just tried to rebase my patch on top of linux-next tree and now
video output is broken for me - I only see some garbage on top of the screen
so I'll need to investigate it first before moving forward with stuff you
proposed :)
-Alexey
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
WARNING: multiple messages have this Message-ID (diff)
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "Liviu.Dudau@arm.com" <Liviu.Dudau@arm.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"airlied@linux.ie" <airlied@linux.ie>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property
Date: Fri, 3 Mar 2017 17:48:19 +0000 [thread overview]
Message-ID: <1488563298.2940.33.camel@synopsys.com> (raw)
In-Reply-To: <20170303162837.GO917@e110455-lin.cambridge.arm.com>
Hi Liviu,
On Fri, 2017-03-03 at 16:28 +0000, Liviu Dudau wrote:
> On Fri, Mar 03, 2017 at 06:19:24PM +0300, Alexey Brodkin wrote:
> >
> > - /* find the encoder node and initialize it */
> > - encoder_node = of_parse_phandle(drm->dev->of_node, "encoder-slave", 0);
> > - if (encoder_node) {
> > - ret = arcpgu_drm_hdmi_init(drm, encoder_node);
> > - of_node_put(encoder_node);
> > + /* There is only one output port inside each device, find it */
> > + port = of_graph_get_next_endpoint(pdev->dev.of_node, NULL);
> > +
> > + if (port) {
> > + if (of_device_is_available(port))
> > + encoder = of_graph_get_remote_port_parent(port);
> > + of_node_put(port);
> > + }
>
> You must've been looking at some old version. Current version in -next uses
> of_graph_get_remote_node() to replace all those lines you have added (see Rob
> Herring's series to introduce of_graph_get_remote_node() function)
Hm, I'm not on Linus' master tree [1] and so I thought I was quite up to date :)
Still I made a check of linux-next and don't see any changes in
"drivers/gpu/drm/arm" compared to Linus' tree.
[1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642
[2] http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642
Could you please clarify which exact tree did you mean?
Anyways I just tried to rebase my patch on top of linux-next tree and now
video output is broken for me - I only see some garbage on top of the screen
so I'll need to investigate it first before moving forward with stuff you
proposed :)
-Alexey
next prev parent reply other threads:[~2017-03-03 17:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 15:19 [PATCH] drm/arcpgu: Get rid of "encoder-slave" property Alexey Brodkin
2017-03-03 15:19 ` Alexey Brodkin
2017-03-03 15:19 ` Alexey Brodkin
2017-03-03 16:28 ` Liviu Dudau
2017-03-03 16:28 ` Liviu Dudau
2017-03-03 16:28 ` Liviu Dudau
2017-03-03 17:48 ` Alexey Brodkin [this message]
2017-03-03 17:48 ` Alexey Brodkin
2017-03-03 17:48 ` Alexey Brodkin
2017-03-03 18:21 ` Liviu.Dudau
2017-03-03 18:21 ` Liviu.Dudau
2017-03-03 18:21 ` Liviu.Dudau
2017-03-29 13:34 ` Alexey Brodkin
2017-03-29 13:34 ` Alexey Brodkin
2017-03-29 13:34 ` Alexey Brodkin
2017-03-29 13:48 ` Liviu.Dudau
2017-03-29 13:48 ` Liviu.Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488563298.2940.33.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.