From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: [PATCH v2 2/5] iommu/arm-smmu: Install bypass S2CRs for IOMMU_DOMAIN_IDENTITY domains
Date: Fri, 10 Mar 2017 20:49:33 +0000 [thread overview]
Message-ID: <1489178976-15353-3-git-send-email-will.deacon@arm.com> (raw)
In-Reply-To: <1489178976-15353-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
In preparation for allowing the default domain type to be overridden,
this patch adds support for IOMMU_DOMAIN_IDENTITY domains to the
ARM SMMU driver.
An identity domain is created by placing the corresponding S2CR
registers into "bypass" mode, which allows transactions to flow through
the SMMU without any translation.
Reviewed-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
Signed-off-by: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
---
drivers/iommu/arm-smmu.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index 6426819348be..04530e968132 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -416,6 +416,7 @@ enum arm_smmu_domain_stage {
ARM_SMMU_DOMAIN_S1 = 0,
ARM_SMMU_DOMAIN_S2,
ARM_SMMU_DOMAIN_NESTED,
+ ARM_SMMU_DOMAIN_BYPASS,
};
struct arm_smmu_domain {
@@ -838,6 +839,12 @@ static int arm_smmu_init_domain_context(struct iommu_domain *domain,
if (smmu_domain->smmu)
goto out_unlock;
+ if (domain->type == IOMMU_DOMAIN_IDENTITY) {
+ smmu_domain->stage = ARM_SMMU_DOMAIN_BYPASS;
+ smmu_domain->smmu = smmu;
+ goto out_unlock;
+ }
+
/*
* Mapping the requested stage onto what we support is surprisingly
* complicated, mainly because the spec allows S1+S2 SMMUs without
@@ -998,7 +1005,7 @@ static void arm_smmu_destroy_domain_context(struct iommu_domain *domain)
void __iomem *cb_base;
int irq;
- if (!smmu)
+ if (!smmu || domain->type == IOMMU_DOMAIN_IDENTITY)
return;
/*
@@ -1021,7 +1028,9 @@ static struct iommu_domain *arm_smmu_domain_alloc(unsigned type)
{
struct arm_smmu_domain *smmu_domain;
- if (type != IOMMU_DOMAIN_UNMANAGED && type != IOMMU_DOMAIN_DMA)
+ if (type != IOMMU_DOMAIN_UNMANAGED &&
+ type != IOMMU_DOMAIN_DMA &&
+ type != IOMMU_DOMAIN_IDENTITY)
return NULL;
/*
* Allocate the domain and initialise some of its data structures.
@@ -1250,10 +1259,15 @@ static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain,
{
struct arm_smmu_device *smmu = smmu_domain->smmu;
struct arm_smmu_s2cr *s2cr = smmu->s2crs;
- enum arm_smmu_s2cr_type type = S2CR_TYPE_TRANS;
u8 cbndx = smmu_domain->cfg.cbndx;
+ enum arm_smmu_s2cr_type type;
int i, idx;
+ if (smmu_domain->stage == ARM_SMMU_DOMAIN_BYPASS)
+ type = S2CR_TYPE_BYPASS;
+ else
+ type = S2CR_TYPE_TRANS;
+
for_each_cfg_sme(fwspec, i, idx) {
if (type == s2cr[idx].type && cbndx == s2cr[idx].cbndx)
continue;
--
2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] iommu/arm-smmu: Install bypass S2CRs for IOMMU_DOMAIN_IDENTITY domains
Date: Fri, 10 Mar 2017 20:49:33 +0000 [thread overview]
Message-ID: <1489178976-15353-3-git-send-email-will.deacon@arm.com> (raw)
In-Reply-To: <1489178976-15353-1-git-send-email-will.deacon@arm.com>
In preparation for allowing the default domain type to be overridden,
this patch adds support for IOMMU_DOMAIN_IDENTITY domains to the
ARM SMMU driver.
An identity domain is created by placing the corresponding S2CR
registers into "bypass" mode, which allows transactions to flow through
the SMMU without any translation.
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
drivers/iommu/arm-smmu.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index 6426819348be..04530e968132 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -416,6 +416,7 @@ enum arm_smmu_domain_stage {
ARM_SMMU_DOMAIN_S1 = 0,
ARM_SMMU_DOMAIN_S2,
ARM_SMMU_DOMAIN_NESTED,
+ ARM_SMMU_DOMAIN_BYPASS,
};
struct arm_smmu_domain {
@@ -838,6 +839,12 @@ static int arm_smmu_init_domain_context(struct iommu_domain *domain,
if (smmu_domain->smmu)
goto out_unlock;
+ if (domain->type == IOMMU_DOMAIN_IDENTITY) {
+ smmu_domain->stage = ARM_SMMU_DOMAIN_BYPASS;
+ smmu_domain->smmu = smmu;
+ goto out_unlock;
+ }
+
/*
* Mapping the requested stage onto what we support is surprisingly
* complicated, mainly because the spec allows S1+S2 SMMUs without
@@ -998,7 +1005,7 @@ static void arm_smmu_destroy_domain_context(struct iommu_domain *domain)
void __iomem *cb_base;
int irq;
- if (!smmu)
+ if (!smmu || domain->type == IOMMU_DOMAIN_IDENTITY)
return;
/*
@@ -1021,7 +1028,9 @@ static struct iommu_domain *arm_smmu_domain_alloc(unsigned type)
{
struct arm_smmu_domain *smmu_domain;
- if (type != IOMMU_DOMAIN_UNMANAGED && type != IOMMU_DOMAIN_DMA)
+ if (type != IOMMU_DOMAIN_UNMANAGED &&
+ type != IOMMU_DOMAIN_DMA &&
+ type != IOMMU_DOMAIN_IDENTITY)
return NULL;
/*
* Allocate the domain and initialise some of its data structures.
@@ -1250,10 +1259,15 @@ static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain,
{
struct arm_smmu_device *smmu = smmu_domain->smmu;
struct arm_smmu_s2cr *s2cr = smmu->s2crs;
- enum arm_smmu_s2cr_type type = S2CR_TYPE_TRANS;
u8 cbndx = smmu_domain->cfg.cbndx;
+ enum arm_smmu_s2cr_type type;
int i, idx;
+ if (smmu_domain->stage == ARM_SMMU_DOMAIN_BYPASS)
+ type = S2CR_TYPE_BYPASS;
+ else
+ type = S2CR_TYPE_TRANS;
+
for_each_cfg_sme(fwspec, i, idx) {
if (type == s2cr[idx].type && cbndx == s2cr[idx].cbndx)
continue;
--
2.1.4
next prev parent reply other threads:[~2017-03-10 20:49 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 20:49 [PATCH v2 0/5] Implement SMMU passthrough using the default domain Will Deacon
2017-03-10 20:49 ` Will Deacon
[not found] ` <1489178976-15353-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-03-10 20:49 ` [PATCH v2 1/5] iommu/arm-smmu: Restrict domain attributes to UNMANAGED domains Will Deacon
2017-03-10 20:49 ` Will Deacon
2017-03-10 20:49 ` Will Deacon [this message]
2017-03-10 20:49 ` [PATCH v2 2/5] iommu/arm-smmu: Install bypass S2CRs for IOMMU_DOMAIN_IDENTITY domains Will Deacon
2017-03-10 20:49 ` [PATCH v2 3/5] iommu/arm-smmu-v3: Make arm_smmu_install_ste_for_dev return void Will Deacon
2017-03-10 20:49 ` Will Deacon
[not found] ` <1489178976-15353-4-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-03-16 16:55 ` Nate Watterson
2017-03-16 16:55 ` Nate Watterson
2017-03-10 20:49 ` [PATCH v2 4/5] iommu/arm-smmu-v3: Install bypass STEs for IOMMU_DOMAIN_IDENTITY domains Will Deacon
2017-03-10 20:49 ` Will Deacon
2017-03-16 16:24 ` Nate Watterson
2017-03-16 16:24 ` Nate Watterson
[not found] ` <420a5345344b4b574878caf3a916f1f2-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-03-16 18:19 ` Robin Murphy
2017-03-16 18:19 ` Robin Murphy
[not found] ` <7d39363e-90e8-4119-3b7e-b1c4f6250879-5wv7dgnIgG8@public.gmane.org>
2017-03-21 17:08 ` Will Deacon
2017-03-21 17:08 ` Will Deacon
[not found] ` <20170321170816.GE30948-5wv7dgnIgG8@public.gmane.org>
2017-03-21 17:33 ` Robin Murphy
2017-03-21 17:33 ` Robin Murphy
2017-03-10 20:49 ` [PATCH v2 5/5] iommu: Allow default domain type to be set on the kernel command line Will Deacon
2017-03-10 20:49 ` Will Deacon
[not found] ` <1489178976-15353-6-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-03-21 15:45 ` Joerg Roedel
2017-03-21 15:45 ` Joerg Roedel
[not found] ` <20170321154527.GB29659-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-03-21 17:21 ` Will Deacon
2017-03-21 17:21 ` Will Deacon
[not found] ` <20170321172137.GF30948-5wv7dgnIgG8@public.gmane.org>
2017-03-21 17:46 ` Robin Murphy
2017-03-21 17:46 ` Robin Murphy
[not found] ` <807ecbb0-c9d7-fc0a-25d2-93b5c4374107-5wv7dgnIgG8@public.gmane.org>
2017-03-21 18:17 ` Will Deacon
2017-03-21 18:17 ` Will Deacon
[not found] ` <20170321181729.GG30948-5wv7dgnIgG8@public.gmane.org>
2017-03-23 10:22 ` Sricharan R
2017-03-23 10:22 ` Sricharan R
2017-03-23 10:38 ` Sricharan R
2017-03-23 10:38 ` Sricharan R
2017-03-22 11:25 ` Joerg Roedel
2017-03-22 11:25 ` Joerg Roedel
2017-03-21 15:46 ` [PATCH v2 0/5] Implement SMMU passthrough using the default domain Joerg Roedel
2017-03-21 15:46 ` Joerg Roedel
[not found] ` <20170321154624.GC29659-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-03-21 16:42 ` Will Deacon
2017-03-21 16:42 ` Will Deacon
[not found] ` <20170321164241.GD30948-5wv7dgnIgG8@public.gmane.org>
2017-03-21 16:46 ` Joerg Roedel
2017-03-21 16:46 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489178976-15353-3-git-send-email-will.deacon@arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.