From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 5/5] iommu: Allow default domain type to be set on the kernel command line
Date: Wed, 22 Mar 2017 12:25:14 +0100 [thread overview]
Message-ID: <20170322112514.GL29659@8bytes.org> (raw)
In-Reply-To: <20170321172137.GF30948-5wv7dgnIgG8@public.gmane.org>
On Tue, Mar 21, 2017 at 05:21:37PM +0000, Will Deacon wrote:
> On Tue, Mar 21, 2017 at 04:45:27PM +0100, Joerg Roedel wrote:
> > On Fri, Mar 10, 2017 at 08:49:36PM +0000, Will Deacon wrote:
> > > @@ -1014,8 +1027,8 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev)
> > > * IOMMU driver.
> > > */
> > > if (!group->default_domain) {
> > > - group->default_domain = __iommu_domain_alloc(dev->bus,
> > > - IOMMU_DOMAIN_DMA);
> > > + group->default_domain =
> > > + __iommu_domain_alloc(dev->bus, iommu_def_domain_type);
> >
> > It would be good to have a fall-back here if we are talking to an IOMMU
> > driver that uses default domains, but does not support identity-mapped
> > domains (yet). Exynos and Rockchip IOMMU drivers seem to fall into this
> > category. A dev_warn() also makes sense in case allocating a identity
> > domain fails.
>
> Sure, something like the diff below?
Yes, this looks good.
Thanks,
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: joro@8bytes.org (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] iommu: Allow default domain type to be set on the kernel command line
Date: Wed, 22 Mar 2017 12:25:14 +0100 [thread overview]
Message-ID: <20170322112514.GL29659@8bytes.org> (raw)
In-Reply-To: <20170321172137.GF30948@arm.com>
On Tue, Mar 21, 2017 at 05:21:37PM +0000, Will Deacon wrote:
> On Tue, Mar 21, 2017 at 04:45:27PM +0100, Joerg Roedel wrote:
> > On Fri, Mar 10, 2017 at 08:49:36PM +0000, Will Deacon wrote:
> > > @@ -1014,8 +1027,8 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev)
> > > * IOMMU driver.
> > > */
> > > if (!group->default_domain) {
> > > - group->default_domain = __iommu_domain_alloc(dev->bus,
> > > - IOMMU_DOMAIN_DMA);
> > > + group->default_domain =
> > > + __iommu_domain_alloc(dev->bus, iommu_def_domain_type);
> >
> > It would be good to have a fall-back here if we are talking to an IOMMU
> > driver that uses default domains, but does not support identity-mapped
> > domains (yet). Exynos and Rockchip IOMMU drivers seem to fall into this
> > category. A dev_warn() also makes sense in case allocating a identity
> > domain fails.
>
> Sure, something like the diff below?
Yes, this looks good.
Thanks,
Joerg
next prev parent reply other threads:[~2017-03-22 11:25 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 20:49 [PATCH v2 0/5] Implement SMMU passthrough using the default domain Will Deacon
2017-03-10 20:49 ` Will Deacon
[not found] ` <1489178976-15353-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-03-10 20:49 ` [PATCH v2 1/5] iommu/arm-smmu: Restrict domain attributes to UNMANAGED domains Will Deacon
2017-03-10 20:49 ` Will Deacon
2017-03-10 20:49 ` [PATCH v2 2/5] iommu/arm-smmu: Install bypass S2CRs for IOMMU_DOMAIN_IDENTITY domains Will Deacon
2017-03-10 20:49 ` Will Deacon
2017-03-10 20:49 ` [PATCH v2 3/5] iommu/arm-smmu-v3: Make arm_smmu_install_ste_for_dev return void Will Deacon
2017-03-10 20:49 ` Will Deacon
[not found] ` <1489178976-15353-4-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-03-16 16:55 ` Nate Watterson
2017-03-16 16:55 ` Nate Watterson
2017-03-10 20:49 ` [PATCH v2 4/5] iommu/arm-smmu-v3: Install bypass STEs for IOMMU_DOMAIN_IDENTITY domains Will Deacon
2017-03-10 20:49 ` Will Deacon
2017-03-16 16:24 ` Nate Watterson
2017-03-16 16:24 ` Nate Watterson
[not found] ` <420a5345344b4b574878caf3a916f1f2-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-03-16 18:19 ` Robin Murphy
2017-03-16 18:19 ` Robin Murphy
[not found] ` <7d39363e-90e8-4119-3b7e-b1c4f6250879-5wv7dgnIgG8@public.gmane.org>
2017-03-21 17:08 ` Will Deacon
2017-03-21 17:08 ` Will Deacon
[not found] ` <20170321170816.GE30948-5wv7dgnIgG8@public.gmane.org>
2017-03-21 17:33 ` Robin Murphy
2017-03-21 17:33 ` Robin Murphy
2017-03-10 20:49 ` [PATCH v2 5/5] iommu: Allow default domain type to be set on the kernel command line Will Deacon
2017-03-10 20:49 ` Will Deacon
[not found] ` <1489178976-15353-6-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2017-03-21 15:45 ` Joerg Roedel
2017-03-21 15:45 ` Joerg Roedel
[not found] ` <20170321154527.GB29659-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-03-21 17:21 ` Will Deacon
2017-03-21 17:21 ` Will Deacon
[not found] ` <20170321172137.GF30948-5wv7dgnIgG8@public.gmane.org>
2017-03-21 17:46 ` Robin Murphy
2017-03-21 17:46 ` Robin Murphy
[not found] ` <807ecbb0-c9d7-fc0a-25d2-93b5c4374107-5wv7dgnIgG8@public.gmane.org>
2017-03-21 18:17 ` Will Deacon
2017-03-21 18:17 ` Will Deacon
[not found] ` <20170321181729.GG30948-5wv7dgnIgG8@public.gmane.org>
2017-03-23 10:22 ` Sricharan R
2017-03-23 10:22 ` Sricharan R
2017-03-23 10:38 ` Sricharan R
2017-03-23 10:38 ` Sricharan R
2017-03-22 11:25 ` Joerg Roedel [this message]
2017-03-22 11:25 ` Joerg Roedel
2017-03-21 15:46 ` [PATCH v2 0/5] Implement SMMU passthrough using the default domain Joerg Roedel
2017-03-21 15:46 ` Joerg Roedel
[not found] ` <20170321154624.GC29659-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-03-21 16:42 ` Will Deacon
2017-03-21 16:42 ` Will Deacon
[not found] ` <20170321164241.GD30948-5wv7dgnIgG8@public.gmane.org>
2017-03-21 16:46 ` Joerg Roedel
2017-03-21 16:46 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322112514.GL29659@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.