Potential BUG in drm/i915/execlists: Reset RING registers upon resume

Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Damian Dominik Martinez Dreyer]

[-- Attachment #1.1: Type: text/plain, Size: 662 bytes --]

I am writing regarding this kernel patch: https://git.kernel.org/pub/sc
m/linux/kernel/git/stable/stable-queue.git/tree/releases/4.9.9/drm-
i915-execlists-reset-ring-registers-upon-resume.patch .

I have identified this by bisect to be the cause of a suspend and
resume issue. Please see https://github.com/kxv/linux49.9 for the
bisect history.

After this change, a Laptop (HP Spectre x360) with Intel HD Graphics
520 will wake up from suspend to a blank screen.

Please also see this thread on the manjaro linux forum: https://forum.m
anjaro.org/t/linux-4-9-9-breaks-hibernation-4-9-8-works/17499 .


Best regards
Damian Dominik Martinez Dreyer

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Eric Blau]

That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
no recall) without the patch. The patch you reference fixed my problem
and apparently many others based on the bug reports:

https://bugs.freedesktop.org/show_bug.cgi?id=96526

I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
works.

Regards,
Eric

On Mon, Mar 13, 2017 at 6:23 PM, Damian Dominik Martinez Dreyer
<damian@mailbox.org> wrote:
> I am writing regarding this kernel patch: https://git.kernel.org/pub/sc
> m/linux/kernel/git/stable/stable-queue.git/tree/releases/4.9.9/drm-
> i915-execlists-reset-ring-registers-upon-resume.patch .
>
> I have identified this by bisect to be the cause of a suspend and
> resume issue. Please see https://github.com/kxv/linux49.9 for the
> bisect history.
>
> After this change, a Laptop (HP Spectre x360) with Intel HD Graphics
> 520 will wake up from suspend to a blank screen.
>
> Please also see this thread on the manjaro linux forum: https://forum.m
> anjaro.org/t/linux-4-9-9-breaks-hibernation-4-9-8-works/17499 .
>
>
> Best regards
> Damian Dominik Martinez Dreyer
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Jani Nikula]

On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
> That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
> failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
> no recall) without the patch. The patch you reference fixed my problem
> and apparently many others based on the bug reports:
>
> https://bugs.freedesktop.org/show_bug.cgi?id=96526
>
> I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
> for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
> works.

So I'm quite surprised

commit f2a0409a08502d64fbe3990354dff5902b08d2fb
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Sep 21 14:51:08 2016 +0100

    drm/i915/execlists: Reset RING registers upon resume
    
    commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.

ended up in v4.9.9 considering that the upstream commit is not annotated
for stable, it has no Fixes: tags, and I can't find any backport
requests or even notifications for it in my mails. (Admittedly I'm not
subscribed on stable@, but I'd expect our lists, maintainers or
developers be Cc'd.)

BR,
Jani.


>
> Regards,
> Eric
>
> On Mon, Mar 13, 2017 at 6:23 PM, Damian Dominik Martinez Dreyer
> <damian@mailbox.org> wrote:
>> I am writing regarding this kernel patch: https://git.kernel.org/pub/sc
>> m/linux/kernel/git/stable/stable-queue.git/tree/releases/4.9.9/drm-
>> i915-execlists-reset-ring-registers-upon-resume.patch .
>>
>> I have identified this by bisect to be the cause of a suspend and
>> resume issue. Please see https://github.com/kxv/linux49.9 for the
>> bisect history.
>>
>> After this change, a Laptop (HP Spectre x360) with Intel HD Graphics
>> 520 will wake up from suspend to a blank screen.
>>
>> Please also see this thread on the manjaro linux forum: https://forum.m
>> anjaro.org/t/linux-4-9-9-breaks-hibernation-4-9-8-works/17499 .
>>
>>
>> Best regards
>> Damian Dominik Martinez Dreyer
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Jani Nikula]

On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
> That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
> failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
> no recall) without the patch. The patch you reference fixed my problem
> and apparently many others based on the bug reports:
>
> https://bugs.freedesktop.org/show_bug.cgi?id=96526
>
> I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
> for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
> works.

So I'm quite surprised

commit f2a0409a08502d64fbe3990354dff5902b08d2fb
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Sep 21 14:51:08 2016 +0100

    drm/i915/execlists: Reset RING registers upon resume
    
    commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.

ended up in v4.9.9 considering that the upstream commit is not annotated
for stable, it has no Fixes: tags, and I can't find any backport
requests or even notifications for it in my mails. (Admittedly I'm not
subscribed on stable@, but I'd expect our lists, maintainers or
developers be Cc'd.)

BR,
Jani.


>
> Regards,
> Eric
>
> On Mon, Mar 13, 2017 at 6:23 PM, Damian Dominik Martinez Dreyer
> <damian@mailbox.org> wrote:
>> I am writing regarding this kernel patch: https://git.kernel.org/pub/sc
>> m/linux/kernel/git/stable/stable-queue.git/tree/releases/4.9.9/drm-
>> i915-execlists-reset-ring-registers-upon-resume.patch .
>>
>> I have identified this by bisect to be the cause of a suspend and
>> resume issue. Please see https://github.com/kxv/linux49.9 for the
>> bisect history.
>>
>> After this change, a Laptop (HP Spectre x360) with Intel HD Graphics
>> 520 will wake up from suspend to a blank screen.
>>
>> Please also see this thread on the manjaro linux forum: https://forum.m
>> anjaro.org/t/linux-4-9-9-breaks-hibernation-4-9-8-works/17499 .
>>
>>
>> Best regards
>> Damian Dominik Martinez Dreyer
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center

Re: Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Greg Kroah-Hartman]

On Mon, Mar 20, 2017 at 05:01:34PM +0200, Jani Nikula wrote:
> On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
> > That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
> > failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
> > no recall) without the patch. The patch you reference fixed my problem
> > and apparently many others based on the bug reports:
> >
> > https://bugs.freedesktop.org/show_bug.cgi?id=96526
> >
> > I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
> > for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
> > works.
> 
> So I'm quite surprised
> 
> commit f2a0409a08502d64fbe3990354dff5902b08d2fb
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Wed Sep 21 14:51:08 2016 +0100
> 
>     drm/i915/execlists: Reset RING registers upon resume
>     
>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
> 
> ended up in v4.9.9 considering that the upstream commit is not annotated
> for stable, it has no Fixes: tags, and I can't find any backport
> requests or even notifications for it in my mails. (Admittedly I'm not
> subscribed on stable@, but I'd expect our lists, maintainers or
> developers be Cc'd.)

Eric sent this to the stable list a few times, my mistake for not seeing
he hadn't also cc:ed the developer list.

Want me to revert it?

thanks,

greg k-h
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Greg Kroah-Hartman]

On Mon, Mar 20, 2017 at 05:01:34PM +0200, Jani Nikula wrote:
> On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
> > That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
> > failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
> > no recall) without the patch. The patch you reference fixed my problem
> > and apparently many others based on the bug reports:
> >
> > https://bugs.freedesktop.org/show_bug.cgi?id=96526
> >
> > I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
> > for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
> > works.
> 
> So I'm quite surprised
> 
> commit f2a0409a08502d64fbe3990354dff5902b08d2fb
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Wed Sep 21 14:51:08 2016 +0100
> 
>     drm/i915/execlists: Reset RING registers upon resume
>     
>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
> 
> ended up in v4.9.9 considering that the upstream commit is not annotated
> for stable, it has no Fixes: tags, and I can't find any backport
> requests or even notifications for it in my mails. (Admittedly I'm not
> subscribed on stable@, but I'd expect our lists, maintainers or
> developers be Cc'd.)

Eric sent this to the stable list a few times, my mistake for not seeing
he hadn't also cc:ed the developer list.

Want me to revert it?

thanks,

greg k-h

Re: Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Eric Blau]

On Mon, Mar 20, 2017 at 11:13 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Mon, Mar 20, 2017 at 05:01:34PM +0200, Jani Nikula wrote:
>> On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
>> > That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
>> > failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
>> > no recall) without the patch. The patch you reference fixed my problem
>> > and apparently many others based on the bug reports:
>> >
>> > https://bugs.freedesktop.org/show_bug.cgi?id=96526
>> >
>> > I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
>> > for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
>> > works.
>>
>> So I'm quite surprised
>>
>> commit f2a0409a08502d64fbe3990354dff5902b08d2fb
>> Author: Chris Wilson <chris@chris-wilson.co.uk>
>> Date:   Wed Sep 21 14:51:08 2016 +0100
>>
>>     drm/i915/execlists: Reset RING registers upon resume
>>
>>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
>>
>> ended up in v4.9.9 considering that the upstream commit is not annotated
>> for stable, it has no Fixes: tags, and I can't find any backport
>> requests or even notifications for it in my mails. (Admittedly I'm not
>> subscribed on stable@, but I'd expect our lists, maintainers or
>> developers be Cc'd.)
>
> Eric sent this to the stable list a few times, my mistake for not seeing
> he hadn't also cc:ed the developer list.
>
> Want me to revert it?
>
> thanks,
>
> greg k-h

My apologies. I'm new to requesting stable patches, but I thought
sending to the stable mailing lists would keep the proper folks in the
loop. Sorry about that.

The bug that the commit fixes has quite a long documentation trail:

[BAT execlists] Sporadic - gem_exec_suspend basic-s4 GPU hang after resume
https://bugs.freedesktop.org/show_bug.cgi?id=96526

I've had problems with that one and this one that is not fixed in 4.10.x stable:

[Regression BDW] kernel panic in Intel i915 module, complete system
freeze in 4.10-rc2
https://bugs.freedesktop.org/show_bug.cgi?id=99295

Thanks,
Eric
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Eric Blau]

On Mon, Mar 20, 2017 at 11:13 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Mon, Mar 20, 2017 at 05:01:34PM +0200, Jani Nikula wrote:
>> On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
>> > That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
>> > failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
>> > no recall) without the patch. The patch you reference fixed my problem
>> > and apparently many others based on the bug reports:
>> >
>> > https://bugs.freedesktop.org/show_bug.cgi?id=96526
>> >
>> > I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
>> > for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
>> > works.
>>
>> So I'm quite surprised
>>
>> commit f2a0409a08502d64fbe3990354dff5902b08d2fb
>> Author: Chris Wilson <chris@chris-wilson.co.uk>
>> Date:   Wed Sep 21 14:51:08 2016 +0100
>>
>>     drm/i915/execlists: Reset RING registers upon resume
>>
>>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
>>
>> ended up in v4.9.9 considering that the upstream commit is not annotated
>> for stable, it has no Fixes: tags, and I can't find any backport
>> requests or even notifications for it in my mails. (Admittedly I'm not
>> subscribed on stable@, but I'd expect our lists, maintainers or
>> developers be Cc'd.)
>
> Eric sent this to the stable list a few times, my mistake for not seeing
> he hadn't also cc:ed the developer list.
>
> Want me to revert it?
>
> thanks,
>
> greg k-h

My apologies. I'm new to requesting stable patches, but I thought
sending to the stable mailing lists would keep the proper folks in the
loop. Sorry about that.

The bug that the commit fixes has quite a long documentation trail:

[BAT execlists] Sporadic - gem_exec_suspend basic-s4 GPU hang after resume
https://bugs.freedesktop.org/show_bug.cgi?id=96526

I've had problems with that one and this one that is not fixed in 4.10.x stable:

[Regression BDW] kernel panic in Intel i915 module, complete system
freeze in 4.10-rc2
https://bugs.freedesktop.org/show_bug.cgi?id=99295

Thanks,
Eric

Re: [Intel-gfx] Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Greg Kroah-Hartman]

On Mon, Mar 20, 2017 at 11:24:38AM -0400, Eric Blau wrote:
> On Mon, Mar 20, 2017 at 11:13 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Mon, Mar 20, 2017 at 05:01:34PM +0200, Jani Nikula wrote:
> >> On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
> >> > That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
> >> > failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
> >> > no recall) without the patch. The patch you reference fixed my problem
> >> > and apparently many others based on the bug reports:
> >> >
> >> > https://bugs.freedesktop.org/show_bug.cgi?id=96526
> >> >
> >> > I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
> >> > for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
> >> > works.
> >>
> >> So I'm quite surprised
> >>
> >> commit f2a0409a08502d64fbe3990354dff5902b08d2fb
> >> Author: Chris Wilson <chris@chris-wilson.co.uk>
> >> Date:   Wed Sep 21 14:51:08 2016 +0100
> >>
> >>     drm/i915/execlists: Reset RING registers upon resume
> >>
> >>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
> >>
> >> ended up in v4.9.9 considering that the upstream commit is not annotated
> >> for stable, it has no Fixes: tags, and I can't find any backport
> >> requests or even notifications for it in my mails. (Admittedly I'm not
> >> subscribed on stable@, but I'd expect our lists, maintainers or
> >> developers be Cc'd.)
> >
> > Eric sent this to the stable list a few times, my mistake for not seeing
> > he hadn't also cc:ed the developer list.
> >
> > Want me to revert it?
> >
> > thanks,
> >
> > greg k-h
> 
> My apologies. I'm new to requesting stable patches, but I thought
> sending to the stable mailing lists would keep the proper folks in the
> loop. Sorry about that.
> 
> The bug that the commit fixes has quite a long documentation trail:
> 
> [BAT execlists] Sporadic - gem_exec_suspend basic-s4 GPU hang after resume
> https://bugs.freedesktop.org/show_bug.cgi?id=96526
> 
> I've had problems with that one and this one that is not fixed in 4.10.x stable:
> 
> [Regression BDW] kernel panic in Intel i915 module, complete system
> freeze in 4.10-rc2
> https://bugs.freedesktop.org/show_bug.cgi?id=99295

So, what needs to be done here?

Do I need to revert something in 4.9? Add something?  Do something else?

totally confused,

greg k-h

Re: Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Jani Nikula]

On Wed, 12 Apr 2017, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Mon, Mar 20, 2017 at 11:24:38AM -0400, Eric Blau wrote:
>> On Mon, Mar 20, 2017 at 11:13 AM, Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org> wrote:
>> > On Mon, Mar 20, 2017 at 05:01:34PM +0200, Jani Nikula wrote:
>> >> On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
>> >> > That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
>> >> > failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
>> >> > no recall) without the patch. The patch you reference fixed my problem
>> >> > and apparently many others based on the bug reports:
>> >> >
>> >> > https://bugs.freedesktop.org/show_bug.cgi?id=96526
>> >> >
>> >> > I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
>> >> > for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
>> >> > works.
>> >>
>> >> So I'm quite surprised
>> >>
>> >> commit f2a0409a08502d64fbe3990354dff5902b08d2fb
>> >> Author: Chris Wilson <chris@chris-wilson.co.uk>
>> >> Date:   Wed Sep 21 14:51:08 2016 +0100
>> >>
>> >>     drm/i915/execlists: Reset RING registers upon resume
>> >>
>> >>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
>> >>
>> >> ended up in v4.9.9 considering that the upstream commit is not annotated
>> >> for stable, it has no Fixes: tags, and I can't find any backport
>> >> requests or even notifications for it in my mails. (Admittedly I'm not
>> >> subscribed on stable@, but I'd expect our lists, maintainers or
>> >> developers be Cc'd.)
>> >
>> > Eric sent this to the stable list a few times, my mistake for not seeing
>> > he hadn't also cc:ed the developer list.
>> >
>> > Want me to revert it?
>> >
>> > thanks,
>> >
>> > greg k-h
>> 
>> My apologies. I'm new to requesting stable patches, but I thought
>> sending to the stable mailing lists would keep the proper folks in the
>> loop. Sorry about that.
>> 
>> The bug that the commit fixes has quite a long documentation trail:
>> 
>> [BAT execlists] Sporadic - gem_exec_suspend basic-s4 GPU hang after resume
>> https://bugs.freedesktop.org/show_bug.cgi?id=96526
>> 
>> I've had problems with that one and this one that is not fixed in 4.10.x stable:
>> 
>> [Regression BDW] kernel panic in Intel i915 module, complete system
>> freeze in 4.10-rc2
>> https://bugs.freedesktop.org/show_bug.cgi?id=99295
>
> So, what needs to be done here?
>
> Do I need to revert something in 4.9? Add something?  Do something else?
>
> totally confused,

I did reply to you [1]:

>> Want me to revert it?
>
> Chris says that would be the correct thing to do. I'm no expert in the
> area, but IIUC having just that commit backported is not enough,
> something more would be needed, but we're not sure yet what exactly and
> if those dependencies can easily be backported.

"it" being commit f2a0409a0850 ("drm/i915/execlists: Reset RING
registers upon resume") in 4.9.9+.

BR,
Jani.


[1] http://mid.mail-archive.com/87a88gar9c.fsf@intel.com

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Jani Nikula]

On Wed, 12 Apr 2017, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Mon, Mar 20, 2017 at 11:24:38AM -0400, Eric Blau wrote:
>> On Mon, Mar 20, 2017 at 11:13 AM, Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org> wrote:
>> > On Mon, Mar 20, 2017 at 05:01:34PM +0200, Jani Nikula wrote:
>> >> On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
>> >> > That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
>> >> > failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
>> >> > no recall) without the patch. The patch you reference fixed my problem
>> >> > and apparently many others based on the bug reports:
>> >> >
>> >> > https://bugs.freedesktop.org/show_bug.cgi?id=96526
>> >> >
>> >> > I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
>> >> > for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
>> >> > works.
>> >>
>> >> So I'm quite surprised
>> >>
>> >> commit f2a0409a08502d64fbe3990354dff5902b08d2fb
>> >> Author: Chris Wilson <chris@chris-wilson.co.uk>
>> >> Date:   Wed Sep 21 14:51:08 2016 +0100
>> >>
>> >>     drm/i915/execlists: Reset RING registers upon resume
>> >>
>> >>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
>> >>
>> >> ended up in v4.9.9 considering that the upstream commit is not annotated
>> >> for stable, it has no Fixes: tags, and I can't find any backport
>> >> requests or even notifications for it in my mails. (Admittedly I'm not
>> >> subscribed on stable@, but I'd expect our lists, maintainers or
>> >> developers be Cc'd.)
>> >
>> > Eric sent this to the stable list a few times, my mistake for not seeing
>> > he hadn't also cc:ed the developer list.
>> >
>> > Want me to revert it?
>> >
>> > thanks,
>> >
>> > greg k-h
>> 
>> My apologies. I'm new to requesting stable patches, but I thought
>> sending to the stable mailing lists would keep the proper folks in the
>> loop. Sorry about that.
>> 
>> The bug that the commit fixes has quite a long documentation trail:
>> 
>> [BAT execlists] Sporadic - gem_exec_suspend basic-s4 GPU hang after resume
>> https://bugs.freedesktop.org/show_bug.cgi?id=96526
>> 
>> I've had problems with that one and this one that is not fixed in 4.10.x stable:
>> 
>> [Regression BDW] kernel panic in Intel i915 module, complete system
>> freeze in 4.10-rc2
>> https://bugs.freedesktop.org/show_bug.cgi?id=99295
>
> So, what needs to be done here?
>
> Do I need to revert something in 4.9? Add something?  Do something else?
>
> totally confused,

I did reply to you [1]:

>> Want me to revert it?
>
> Chris says that would be the correct thing to do. I'm no expert in the
> area, but IIUC having just that commit backported is not enough,
> something more would be needed, but we're not sure yet what exactly and
> if those dependencies can easily be backported.

"it" being commit f2a0409a0850 ("drm/i915/execlists: Reset RING
registers upon resume") in 4.9.9+.

BR,
Jani.


[1] http://mid.mail-archive.com/87a88gar9c.fsf@intel.com

-- 
Jani Nikula, Intel Open Source Technology Center

Re: Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Greg Kroah-Hartman]

On Wed, Apr 12, 2017 at 04:35:47PM +0300, Jani Nikula wrote:
> On Wed, 12 Apr 2017, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > On Mon, Mar 20, 2017 at 11:24:38AM -0400, Eric Blau wrote:
> >> On Mon, Mar 20, 2017 at 11:13 AM, Greg Kroah-Hartman
> >> <gregkh@linuxfoundation.org> wrote:
> >> > On Mon, Mar 20, 2017 at 05:01:34PM +0200, Jani Nikula wrote:
> >> >> On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
> >> >> > That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
> >> >> > failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
> >> >> > no recall) without the patch. The patch you reference fixed my problem
> >> >> > and apparently many others based on the bug reports:
> >> >> >
> >> >> > https://bugs.freedesktop.org/show_bug.cgi?id=96526
> >> >> >
> >> >> > I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
> >> >> > for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
> >> >> > works.
> >> >>
> >> >> So I'm quite surprised
> >> >>
> >> >> commit f2a0409a08502d64fbe3990354dff5902b08d2fb
> >> >> Author: Chris Wilson <chris@chris-wilson.co.uk>
> >> >> Date:   Wed Sep 21 14:51:08 2016 +0100
> >> >>
> >> >>     drm/i915/execlists: Reset RING registers upon resume
> >> >>
> >> >>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
> >> >>
> >> >> ended up in v4.9.9 considering that the upstream commit is not annotated
> >> >> for stable, it has no Fixes: tags, and I can't find any backport
> >> >> requests or even notifications for it in my mails. (Admittedly I'm not
> >> >> subscribed on stable@, but I'd expect our lists, maintainers or
> >> >> developers be Cc'd.)
> >> >
> >> > Eric sent this to the stable list a few times, my mistake for not seeing
> >> > he hadn't also cc:ed the developer list.
> >> >
> >> > Want me to revert it?
> >> >
> >> > thanks,
> >> >
> >> > greg k-h
> >> 
> >> My apologies. I'm new to requesting stable patches, but I thought
> >> sending to the stable mailing lists would keep the proper folks in the
> >> loop. Sorry about that.
> >> 
> >> The bug that the commit fixes has quite a long documentation trail:
> >> 
> >> [BAT execlists] Sporadic - gem_exec_suspend basic-s4 GPU hang after resume
> >> https://bugs.freedesktop.org/show_bug.cgi?id=96526
> >> 
> >> I've had problems with that one and this one that is not fixed in 4.10.x stable:
> >> 
> >> [Regression BDW] kernel panic in Intel i915 module, complete system
> >> freeze in 4.10-rc2
> >> https://bugs.freedesktop.org/show_bug.cgi?id=99295
> >
> > So, what needs to be done here?
> >
> > Do I need to revert something in 4.9? Add something?  Do something else?
> >
> > totally confused,
> 
> I did reply to you [1]:
> 
> >> Want me to revert it?
> >
> > Chris says that would be the correct thing to do. I'm no expert in the
> > area, but IIUC having just that commit backported is not enough,
> > something more would be needed, but we're not sure yet what exactly and
> > if those dependencies can easily be backported.
> 
> "it" being commit f2a0409a0850 ("drm/i915/execlists: Reset RING
> registers upon resume") in 4.9.9+.

Ah, ok, now reverted, thanks.

greg k-h
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Greg Kroah-Hartman]

On Wed, Apr 12, 2017 at 04:35:47PM +0300, Jani Nikula wrote:
> On Wed, 12 Apr 2017, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > On Mon, Mar 20, 2017 at 11:24:38AM -0400, Eric Blau wrote:
> >> On Mon, Mar 20, 2017 at 11:13 AM, Greg Kroah-Hartman
> >> <gregkh@linuxfoundation.org> wrote:
> >> > On Mon, Mar 20, 2017 at 05:01:34PM +0200, Jani Nikula wrote:
> >> >> On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
> >> >> > That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
> >> >> > failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
> >> >> > no recall) without the patch. The patch you reference fixed my problem
> >> >> > and apparently many others based on the bug reports:
> >> >> >
> >> >> > https://bugs.freedesktop.org/show_bug.cgi?id=96526
> >> >> >
> >> >> > I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
> >> >> > for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
> >> >> > works.
> >> >>
> >> >> So I'm quite surprised
> >> >>
> >> >> commit f2a0409a08502d64fbe3990354dff5902b08d2fb
> >> >> Author: Chris Wilson <chris@chris-wilson.co.uk>
> >> >> Date:   Wed Sep 21 14:51:08 2016 +0100
> >> >>
> >> >>     drm/i915/execlists: Reset RING registers upon resume
> >> >>
> >> >>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
> >> >>
> >> >> ended up in v4.9.9 considering that the upstream commit is not annotated
> >> >> for stable, it has no Fixes: tags, and I can't find any backport
> >> >> requests or even notifications for it in my mails. (Admittedly I'm not
> >> >> subscribed on stable@, but I'd expect our lists, maintainers or
> >> >> developers be Cc'd.)
> >> >
> >> > Eric sent this to the stable list a few times, my mistake for not seeing
> >> > he hadn't also cc:ed the developer list.
> >> >
> >> > Want me to revert it?
> >> >
> >> > thanks,
> >> >
> >> > greg k-h
> >> 
> >> My apologies. I'm new to requesting stable patches, but I thought
> >> sending to the stable mailing lists would keep the proper folks in the
> >> loop. Sorry about that.
> >> 
> >> The bug that the commit fixes has quite a long documentation trail:
> >> 
> >> [BAT execlists] Sporadic - gem_exec_suspend basic-s4 GPU hang after resume
> >> https://bugs.freedesktop.org/show_bug.cgi?id=96526
> >> 
> >> I've had problems with that one and this one that is not fixed in 4.10.x stable:
> >> 
> >> [Regression BDW] kernel panic in Intel i915 module, complete system
> >> freeze in 4.10-rc2
> >> https://bugs.freedesktop.org/show_bug.cgi?id=99295
> >
> > So, what needs to be done here?
> >
> > Do I need to revert something in 4.9? Add something?  Do something else?
> >
> > totally confused,
> 
> I did reply to you [1]:
> 
> >> Want me to revert it?
> >
> > Chris says that would be the correct thing to do. I'm no expert in the
> > area, but IIUC having just that commit backported is not enough,
> > something more would be needed, but we're not sure yet what exactly and
> > if those dependencies can easily be backported.
> 
> "it" being commit f2a0409a0850 ("drm/i915/execlists: Reset RING
> registers upon resume") in 4.9.9+.

Ah, ok, now reverted, thanks.

greg k-h

Re: Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Jani Nikula]

On Mon, 20 Mar 2017, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Mon, Mar 20, 2017 at 05:01:34PM +0200, Jani Nikula wrote:
>> On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
>> > That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
>> > failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
>> > no recall) without the patch. The patch you reference fixed my problem
>> > and apparently many others based on the bug reports:
>> >
>> > https://bugs.freedesktop.org/show_bug.cgi?id=96526
>> >
>> > I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
>> > for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
>> > works.
>> 
>> So I'm quite surprised
>> 
>> commit f2a0409a08502d64fbe3990354dff5902b08d2fb
>> Author: Chris Wilson <chris@chris-wilson.co.uk>
>> Date:   Wed Sep 21 14:51:08 2016 +0100
>> 
>>     drm/i915/execlists: Reset RING registers upon resume
>>     
>>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
>> 
>> ended up in v4.9.9 considering that the upstream commit is not annotated
>> for stable, it has no Fixes: tags, and I can't find any backport
>> requests or even notifications for it in my mails. (Admittedly I'm not
>> subscribed on stable@, but I'd expect our lists, maintainers or
>> developers be Cc'd.)
>
> Eric sent this to the stable list a few times, my mistake for not seeing
> he hadn't also cc:ed the developer list.
>
> Want me to revert it?

Chris says that would be the correct thing to do. I'm no expert in the
area, but IIUC having just that commit backported is not enough,
something more would be needed, but we're not sure yet what exactly and
if those dependencies can easily be backported.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Jani Nikula]

On Mon, 20 Mar 2017, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Mon, Mar 20, 2017 at 05:01:34PM +0200, Jani Nikula wrote:
>> On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
>> > That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
>> > failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
>> > no recall) without the patch. The patch you reference fixed my problem
>> > and apparently many others based on the bug reports:
>> >
>> > https://bugs.freedesktop.org/show_bug.cgi?id=96526
>> >
>> > I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
>> > for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
>> > works.
>> 
>> So I'm quite surprised
>> 
>> commit f2a0409a08502d64fbe3990354dff5902b08d2fb
>> Author: Chris Wilson <chris@chris-wilson.co.uk>
>> Date:   Wed Sep 21 14:51:08 2016 +0100
>> 
>>     drm/i915/execlists: Reset RING registers upon resume
>>     
>>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
>> 
>> ended up in v4.9.9 considering that the upstream commit is not annotated
>> for stable, it has no Fixes: tags, and I can't find any backport
>> requests or even notifications for it in my mails. (Admittedly I'm not
>> subscribed on stable@, but I'd expect our lists, maintainers or
>> developers be Cc'd.)
>
> Eric sent this to the stable list a few times, my mistake for not seeing
> he hadn't also cc:ed the developer list.
>
> Want me to revert it?

Chris says that would be the correct thing to do. I'm no expert in the
area, but IIUC having just that commit backported is not enough,
something more would be needed, but we're not sure yet what exactly and
if those dependencies can easily be backported.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center

Re: Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Jani Nikula]

On Tue, 14 Mar 2017, Damian Dominik Martinez Dreyer <damian@mailbox.org> wrote:
> I am writing regarding this kernel patch: https://git.kernel.org/pub/sc
> m/linux/kernel/git/stable/stable-queue.git/tree/releases/4.9.9/drm-
> i915-execlists-reset-ring-registers-upon-resume.patch .

That would be

commit f2a0409a08502d64fbe3990354dff5902b08d2fb
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Sep 21 14:51:08 2016 +0100

    drm/i915/execlists: Reset RING registers upon resume
    
    commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.

in v4.9.9 not just a patch.

> I have identified this by bisect to be the cause of a suspend and
> resume issue. Please see https://github.com/kxv/linux49.9 for the
> bisect history.
>
> After this change, a Laptop (HP Spectre x360) with Intel HD Graphics
> 520 will wake up from suspend to a blank screen.
>
> Please also see this thread on the manjaro linux forum: https://forum.m
> anjaro.org/t/linux-4-9-9-breaks-hibernation-4-9-8-works/17499 .

Please file a bug over at [1], with the information added to the bug.

Also mention if v4.10 works for you; that's where the commit was
backported to v4.9.9 from.

BR,
Jani.

[1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Potential BUG in drm/i915/execlists: Reset RING registers upon resume

[Damian Dominik Martinez Dreyer]

[-- Attachment #1.1: Type: text/plain, Size: 858 bytes --]

Am Dienstag, den 14.03.2017, 13:19 +0200 schrieb Jani Nikula:
> 
> That would be
> 
> commit f2a0409a08502d64fbe3990354dff5902b08d2fb
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Wed Sep 21 14:51:08 2016 +0100
> 
>     drm/i915/execlists: Reset RING registers upon resume
>     
>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
> 
> in v4.9.9 not just a patch.
> 
> Please file a bug over at [1], with the information added to the bug.
> 
> Also mention if v4.10 works for you; that's where the commit was
> backported to v4.9.9 from.
> 
> BR,
> Jani.
> 
> [1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=
> DRM/Intel
> 

Thank you for your quick answer.
I have opened a bug report: https://bugs.freedesktop.org/show_bug.cgi?i
d=100221

Best Regards,
Damian


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx