From: Joe Perches <joe@perches.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 02/15] mm: page_alloc: align arguments to parenthesis
Date: Thu, 16 Mar 2017 03:29:27 -0700 [thread overview]
Message-ID: <1489660167.13953.1.camel@perches.com> (raw)
In-Reply-To: <20170316080240.GB30501@dhcp22.suse.cz>
On Thu, 2017-03-16 at 09:02 +0100, Michal Hocko wrote:
> On Wed 15-03-17 18:59:59, Joe Perches wrote:
> > whitespace changes only - git diff -w shows no difference
>
> what is the point of this whitespace noise? Does it help readability?
Yes. Consistency helps.
> To be honest I do not think so.
Opinions always vary.
> Such a patch would make sense only if it
> was a part of a larger series where other patches would actually do
> something useful.
Do please read the 0/n introduction to this series.
And do remember to always strip the useless stuff you
unnecessarily quoted too. 66kb in this case.
There was a separate patch series 0/3 that actually did
the more useful stuff.
This patch series was purposely separated.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 02/15] mm: page_alloc: align arguments to parenthesis
Date: Thu, 16 Mar 2017 03:29:27 -0700 [thread overview]
Message-ID: <1489660167.13953.1.camel@perches.com> (raw)
In-Reply-To: <20170316080240.GB30501@dhcp22.suse.cz>
On Thu, 2017-03-16 at 09:02 +0100, Michal Hocko wrote:
> On Wed 15-03-17 18:59:59, Joe Perches wrote:
> > whitespace changes only - git diff -w shows no difference
>
> what is the point of this whitespace noise? Does it help readability?
Yes. Consistency helps.
> To be honest I do not think so.
Opinions always vary.
> Such a patch would make sense only if it
> was a part of a larger series where other patches would actually do
> something useful.
Do please read the 0/n introduction to this series.
And do remember to always strip the useless stuff you
unnecessarily quoted too. 66kb in this case.
There was a separate patch series 0/3 that actually did
the more useful stuff.
This patch series was purposely separated.
next prev parent reply other threads:[~2017-03-16 10:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 1:59 [PATCH 00/15] mm: page_alloc: style neatenings Joe Perches
2017-03-16 1:59 ` Joe Perches
2017-03-16 1:59 ` [PATCH 01/15] mm: page_alloc: whitespace neatening Joe Perches
2017-03-16 1:59 ` Joe Perches
2017-03-16 1:59 ` [PATCH 02/15] mm: page_alloc: align arguments to parenthesis Joe Perches
2017-03-16 1:59 ` Joe Perches
2017-03-16 8:02 ` Michal Hocko
2017-03-16 8:02 ` Michal Hocko
2017-03-16 10:29 ` Joe Perches [this message]
2017-03-16 10:29 ` Joe Perches
2017-03-16 10:33 ` Michal Hocko
2017-03-16 10:33 ` Michal Hocko
2017-03-16 2:00 ` [PATCH 03/15] mm: page_alloc: fix brace positions Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 04/15] mm: page_alloc: fix blank lines Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 05/15] mm: page_alloc: Move __meminitdata and __initdata uses Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 06/15] mm: page_alloc: Use unsigned int instead of unsigned Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 07/15] mm: page_alloc: Move labels to column 1 Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 08/15] mm: page_alloc: Fix typo acording -> according & the the -> to the Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 09/15] mm: page_alloc: Use the common commenting style Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 10/15] mm: page_alloc: 80 column neatening Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 8:59 ` Sergey Senozhatsky
2017-03-16 8:59 ` Sergey Senozhatsky
2017-03-16 2:00 ` [PATCH 11/15] mm: page_alloc: Move EXPORT_SYMBOL uses Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 12/15] mm: page_alloc: Avoid pointer comparisons to NULL Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 13/15] mm: page_alloc: Remove unnecessary parentheses Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 14/15] mm: page_alloc: Use octal permissions Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 15/15] mm: page_alloc: Move logical continuations to EOL Joe Perches
2017-03-16 2:00 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489660167.13953.1.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.