From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 00/15] mm: page_alloc: style neatenings
Date: Wed, 15 Mar 2017 18:59:57 -0700 [thread overview]
Message-ID: <cover.1489628477.git.joe@perches.com> (raw)
Just neatening. Maybe useful, maybe not. Mostly whitespace changes.
There are still many checkpatch messages that should probably
be ignored.
Before:
$ ./scripts/checkpatch.pl --strict --terse --nosummary --show-types \
-f mm/page_alloc.c | \
cut -f4 -d":" | sort | uniq -c | sort -rn
144 PARENTHESIS_ALIGNMENT
38 SPLIT_STRING
36 LINE_SPACING
32 LONG_LINE
28 SPACING
14 LONG_LINE_COMMENT
14 BRACES
13 LOGGING_CONTINUATION
12 PREFER_PR_LEVEL
8 MISPLACED_INIT
7 EXPORT_SYMBOL
7 AVOID_BUG
6 UNSPECIFIED_INT
5 MACRO_ARG_PRECEDENCE
4 MULTIPLE_ASSIGNMENTS
4 LOGICAL_CONTINUATIONS
4 COMPARISON_TO_NULL
4 CAMELCASE
3 UNNECESSARY_PARENTHESES
3 PRINTK_WITHOUT_KERN_LEVEL
3 MACRO_ARG_REUSE
2 UNDOCUMENTED_SETUP
2 MEMORY_BARRIER
2 BLOCK_COMMENT_STYLE
1 VOLATILE
1 TYPO_SPELLING
1 SYMBOLIC_PERMS
1 SUSPECT_CODE_INDENT
1 SPACE_BEFORE_TAB
1 FUNCTION_ARGUMENTS
1 CONSTANT_COMPARISON
1 CONSIDER_KSTRTO
After:
$ ./scripts/checkpatch.pl --strict --terse --nosummary --show-types \
-f mm/page_alloc.c | \
cut -f4 -d":" | sort | uniq -c | sort -rn
43 SPLIT_STRING
21 LONG_LINE
14 LONG_LINE_COMMENT
13 LOGGING_CONTINUATION
12 PREFER_PR_LEVEL
8 PRINTK_WITHOUT_KERN_LEVEL
7 AVOID_BUG
5 MACRO_ARG_PRECEDENCE
4 MULTIPLE_ASSIGNMENTS
4 CAMELCASE
3 MACRO_ARG_REUSE
2 UNDOCUMENTED_SETUP
2 MEMORY_BARRIER
2 LEADING_SPACE
1 VOLATILE
1 SPACING
1 FUNCTION_ARGUMENTS
1 EXPORT_SYMBOL
1 CONSTANT_COMPARISON
1 CONSIDER_KSTRTO
Joe Perches (15):
mm: page_alloc: whitespace neatening
mm: page_alloc: align arguments to parenthesis
mm: page_alloc: fix brace positions
mm: page_alloc: fix blank lines
mm: page_alloc: Move __meminitdata and __initdata uses
mm: page_alloc: Use unsigned int instead of unsigned
mm: page_alloc: Move labels to column 1
mm: page_alloc: Fix typo acording -> according & the the -> to the
mm: page_alloc: Use the common commenting style
mm: page_alloc: 80 column neatening
mm: page_alloc: Move EXPORT_SYMBOL uses
mm: page_alloc: Avoid pointer comparisons to NULL
mm: page_alloc: Remove unnecessary parentheses
mm: page_alloc: Use octal permissions
mm: page_alloc: Move logical continuations to EOL
mm/page_alloc.c | 845 ++++++++++++++++++++++++++++++--------------------------
1 file changed, 458 insertions(+), 387 deletions(-)
--
2.10.0.rc2.1.g053435c
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 00/15] mm: page_alloc: style neatenings
Date: Wed, 15 Mar 2017 18:59:57 -0700 [thread overview]
Message-ID: <cover.1489628477.git.joe@perches.com> (raw)
Just neatening. Maybe useful, maybe not. Mostly whitespace changes.
There are still many checkpatch messages that should probably
be ignored.
Before:
$ ./scripts/checkpatch.pl --strict --terse --nosummary --show-types \
-f mm/page_alloc.c | \
cut -f4 -d":" | sort | uniq -c | sort -rn
144 PARENTHESIS_ALIGNMENT
38 SPLIT_STRING
36 LINE_SPACING
32 LONG_LINE
28 SPACING
14 LONG_LINE_COMMENT
14 BRACES
13 LOGGING_CONTINUATION
12 PREFER_PR_LEVEL
8 MISPLACED_INIT
7 EXPORT_SYMBOL
7 AVOID_BUG
6 UNSPECIFIED_INT
5 MACRO_ARG_PRECEDENCE
4 MULTIPLE_ASSIGNMENTS
4 LOGICAL_CONTINUATIONS
4 COMPARISON_TO_NULL
4 CAMELCASE
3 UNNECESSARY_PARENTHESES
3 PRINTK_WITHOUT_KERN_LEVEL
3 MACRO_ARG_REUSE
2 UNDOCUMENTED_SETUP
2 MEMORY_BARRIER
2 BLOCK_COMMENT_STYLE
1 VOLATILE
1 TYPO_SPELLING
1 SYMBOLIC_PERMS
1 SUSPECT_CODE_INDENT
1 SPACE_BEFORE_TAB
1 FUNCTION_ARGUMENTS
1 CONSTANT_COMPARISON
1 CONSIDER_KSTRTO
After:
$ ./scripts/checkpatch.pl --strict --terse --nosummary --show-types \
-f mm/page_alloc.c | \
cut -f4 -d":" | sort | uniq -c | sort -rn
43 SPLIT_STRING
21 LONG_LINE
14 LONG_LINE_COMMENT
13 LOGGING_CONTINUATION
12 PREFER_PR_LEVEL
8 PRINTK_WITHOUT_KERN_LEVEL
7 AVOID_BUG
5 MACRO_ARG_PRECEDENCE
4 MULTIPLE_ASSIGNMENTS
4 CAMELCASE
3 MACRO_ARG_REUSE
2 UNDOCUMENTED_SETUP
2 MEMORY_BARRIER
2 LEADING_SPACE
1 VOLATILE
1 SPACING
1 FUNCTION_ARGUMENTS
1 EXPORT_SYMBOL
1 CONSTANT_COMPARISON
1 CONSIDER_KSTRTO
Joe Perches (15):
mm: page_alloc: whitespace neatening
mm: page_alloc: align arguments to parenthesis
mm: page_alloc: fix brace positions
mm: page_alloc: fix blank lines
mm: page_alloc: Move __meminitdata and __initdata uses
mm: page_alloc: Use unsigned int instead of unsigned
mm: page_alloc: Move labels to column 1
mm: page_alloc: Fix typo acording -> according & the the -> to the
mm: page_alloc: Use the common commenting style
mm: page_alloc: 80 column neatening
mm: page_alloc: Move EXPORT_SYMBOL uses
mm: page_alloc: Avoid pointer comparisons to NULL
mm: page_alloc: Remove unnecessary parentheses
mm: page_alloc: Use octal permissions
mm: page_alloc: Move logical continuations to EOL
mm/page_alloc.c | 845 ++++++++++++++++++++++++++++++--------------------------
1 file changed, 458 insertions(+), 387 deletions(-)
--
2.10.0.rc2.1.g053435c
next reply other threads:[~2017-03-16 2:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 1:59 Joe Perches [this message]
2017-03-16 1:59 ` [PATCH 00/15] mm: page_alloc: style neatenings Joe Perches
2017-03-16 1:59 ` [PATCH 01/15] mm: page_alloc: whitespace neatening Joe Perches
2017-03-16 1:59 ` Joe Perches
2017-03-16 1:59 ` [PATCH 02/15] mm: page_alloc: align arguments to parenthesis Joe Perches
2017-03-16 1:59 ` Joe Perches
2017-03-16 8:02 ` Michal Hocko
2017-03-16 8:02 ` Michal Hocko
2017-03-16 10:29 ` Joe Perches
2017-03-16 10:29 ` Joe Perches
2017-03-16 10:33 ` Michal Hocko
2017-03-16 10:33 ` Michal Hocko
2017-03-16 2:00 ` [PATCH 03/15] mm: page_alloc: fix brace positions Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 04/15] mm: page_alloc: fix blank lines Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 05/15] mm: page_alloc: Move __meminitdata and __initdata uses Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 06/15] mm: page_alloc: Use unsigned int instead of unsigned Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 07/15] mm: page_alloc: Move labels to column 1 Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 08/15] mm: page_alloc: Fix typo acording -> according & the the -> to the Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 09/15] mm: page_alloc: Use the common commenting style Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 10/15] mm: page_alloc: 80 column neatening Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 8:59 ` Sergey Senozhatsky
2017-03-16 8:59 ` Sergey Senozhatsky
2017-03-16 2:00 ` [PATCH 11/15] mm: page_alloc: Move EXPORT_SYMBOL uses Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 12/15] mm: page_alloc: Avoid pointer comparisons to NULL Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 13/15] mm: page_alloc: Remove unnecessary parentheses Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 14/15] mm: page_alloc: Use octal permissions Joe Perches
2017-03-16 2:00 ` Joe Perches
2017-03-16 2:00 ` [PATCH 15/15] mm: page_alloc: Move logical continuations to EOL Joe Perches
2017-03-16 2:00 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1489628477.git.joe@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.