All of lore.kernel.org
 help / color / mirror / Atom feed
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2, 3/3] tty/serial: meson_uart: add the core clock handling to the driver
Date: Tue, 28 Mar 2017 21:16:02 +0200	[thread overview]
Message-ID: <1490728562.20764.9.camel@baylibre.com> (raw)
In-Reply-To: <20170328092545.4644-4-hgkr.klein@gmail.com>

On Tue, 2017-03-28 at 11:25 +0200, Helmut Klein wrote:
> This patch gets the core clock as provided by the DT and enables it.
> The code was taken from Amlogic's serial driver, and was tested on my
> board.
> 
> Signed-off-by: Helmut Klein <hgkr.klein@gmail.com>
> ---
> ?drivers/tty/serial/meson_uart.c | 10 ++++++++++
> ?1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 60f16795d16b..cb99112288eb 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -600,6 +600,7 @@ static int meson_uart_probe(struct platform_device *pdev)
> ?	struct resource *res_mem, *res_irq;
> ?	struct uart_port *port;
> ?	struct clk *clk;
> +	struct clk *core_clk;
> ?	int ret = 0;
> 
> ?	if (pdev->dev.of_node)
> @@ -625,6 +626,15 @@ static int meson_uart_probe(struct platform_device *pdev)
> ?	if (!port)
> ?		return -ENOMEM;
> 
> +	core_clk = devm_clk_get(&pdev->dev, "core");
> +	if (!IS_ERR(core_clk)) {
> +		ret = clk_prepare_enable(core_clk);
> +		if (ret) {
> +			dev_err(&pdev->dev, "couldn't enable clkc\n");
> +			return ret;
> +		}
> +	}
> +
> ?	clk = clk_get(&pdev->dev, NULL);
Now that you have 2 clocks, shouldn't this be named as well ?

> ?	if (IS_ERR(clk))
> ?		return PTR_ERR(clk);
> --
> 2.11.0
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Helmut Klein <hgkr.klein@gmail.com>,
	gregkh@linuxfoundation.org, carlo@caione.org,
	khilman@baylibre.com
Cc: linux-amlogic@lists.infradead.org, linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2, 3/3] tty/serial: meson_uart: add the core clock handling to the driver
Date: Tue, 28 Mar 2017 21:16:02 +0200	[thread overview]
Message-ID: <1490728562.20764.9.camel@baylibre.com> (raw)
In-Reply-To: <20170328092545.4644-4-hgkr.klein@gmail.com>

On Tue, 2017-03-28 at 11:25 +0200, Helmut Klein wrote:
> This patch gets the core clock as provided by the DT and enables it.
> The code was taken from Amlogic's serial driver, and was tested on my
> board.
> 
> Signed-off-by: Helmut Klein <hgkr.klein@gmail.com>
> ---
>  drivers/tty/serial/meson_uart.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 60f16795d16b..cb99112288eb 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -600,6 +600,7 @@ static int meson_uart_probe(struct platform_device *pdev)
>  	struct resource *res_mem, *res_irq;
>  	struct uart_port *port;
>  	struct clk *clk;
> +	struct clk *core_clk;
>  	int ret = 0;
> 
>  	if (pdev->dev.of_node)
> @@ -625,6 +626,15 @@ static int meson_uart_probe(struct platform_device *pdev)
>  	if (!port)
>  		return -ENOMEM;
> 
> +	core_clk = devm_clk_get(&pdev->dev, "core");
> +	if (!IS_ERR(core_clk)) {
> +		ret = clk_prepare_enable(core_clk);
> +		if (ret) {
> +			dev_err(&pdev->dev, "couldn't enable clkc\n");
> +			return ret;
> +		}
> +	}
> +
>  	clk = clk_get(&pdev->dev, NULL);
Now that you have 2 clocks, shouldn't this be named as well ?

>  	if (IS_ERR(clk))
>  		return PTR_ERR(clk);
> --
> 2.11.0
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2, 3/3] tty/serial: meson_uart: add the core clock handling to the driver
Date: Tue, 28 Mar 2017 21:16:02 +0200	[thread overview]
Message-ID: <1490728562.20764.9.camel@baylibre.com> (raw)
In-Reply-To: <20170328092545.4644-4-hgkr.klein@gmail.com>

On Tue, 2017-03-28 at 11:25 +0200, Helmut Klein wrote:
> This patch gets the core clock as provided by the DT and enables it.
> The code was taken from Amlogic's serial driver, and was tested on my
> board.
> 
> Signed-off-by: Helmut Klein <hgkr.klein@gmail.com>
> ---
> ?drivers/tty/serial/meson_uart.c | 10 ++++++++++
> ?1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 60f16795d16b..cb99112288eb 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -600,6 +600,7 @@ static int meson_uart_probe(struct platform_device *pdev)
> ?	struct resource *res_mem, *res_irq;
> ?	struct uart_port *port;
> ?	struct clk *clk;
> +	struct clk *core_clk;
> ?	int ret = 0;
> 
> ?	if (pdev->dev.of_node)
> @@ -625,6 +626,15 @@ static int meson_uart_probe(struct platform_device *pdev)
> ?	if (!port)
> ?		return -ENOMEM;
> 
> +	core_clk = devm_clk_get(&pdev->dev, "core");
> +	if (!IS_ERR(core_clk)) {
> +		ret = clk_prepare_enable(core_clk);
> +		if (ret) {
> +			dev_err(&pdev->dev, "couldn't enable clkc\n");
> +			return ret;
> +		}
> +	}
> +
> ?	clk = clk_get(&pdev->dev, NULL);
Now that you have 2 clocks, shouldn't this be named as well ?

> ?	if (IS_ERR(clk))
> ?		return PTR_ERR(clk);
> --
> 2.11.0
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Helmut Klein <hgkr.klein@gmail.com>,
	gregkh@linuxfoundation.org, carlo@caione.org,
	khilman@baylibre.com
Cc: linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2, 3/3] tty/serial: meson_uart: add the core clock handling to the driver
Date: Tue, 28 Mar 2017 21:16:02 +0200	[thread overview]
Message-ID: <1490728562.20764.9.camel@baylibre.com> (raw)
In-Reply-To: <20170328092545.4644-4-hgkr.klein@gmail.com>

On Tue, 2017-03-28 at 11:25 +0200, Helmut Klein wrote:
> This patch gets the core clock as provided by the DT and enables it.
> The code was taken from Amlogic's serial driver, and was tested on my
> board.
> 
> Signed-off-by: Helmut Klein <hgkr.klein@gmail.com>
> ---
>  drivers/tty/serial/meson_uart.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 60f16795d16b..cb99112288eb 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -600,6 +600,7 @@ static int meson_uart_probe(struct platform_device *pdev)
>  	struct resource *res_mem, *res_irq;
>  	struct uart_port *port;
>  	struct clk *clk;
> +	struct clk *core_clk;
>  	int ret = 0;
> 
>  	if (pdev->dev.of_node)
> @@ -625,6 +626,15 @@ static int meson_uart_probe(struct platform_device *pdev)
>  	if (!port)
>  		return -ENOMEM;
> 
> +	core_clk = devm_clk_get(&pdev->dev, "core");
> +	if (!IS_ERR(core_clk)) {
> +		ret = clk_prepare_enable(core_clk);
> +		if (ret) {
> +			dev_err(&pdev->dev, "couldn't enable clkc\n");
> +			return ret;
> +		}
> +	}
> +
>  	clk = clk_get(&pdev->dev, NULL);
Now that you have 2 clocks, shouldn't this be named as well ?

>  	if (IS_ERR(clk))
>  		return PTR_ERR(clk);
> --
> 2.11.0
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2017-03-28 19:16 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28  9:25 [PATCH v2, 0/3] tty/serial: meson_uart: add support for core clock handling Helmut Klein
2017-03-28  9:25 ` [PATCH v2,0/3] " Helmut Klein
2017-03-28  9:25 ` [PATCH v2, 0/3] " Helmut Klein
2017-03-28  9:25 ` Helmut Klein
2017-03-28  9:25 ` Helmut Klein
2017-03-28  9:25 ` [PATCH v2,1/3] meson_uart: expose CLKID_UARTx Helmut Klein
2017-03-28  9:25   ` Helmut Klein
2017-03-28  9:25   ` Helmut Klein
2017-03-28  9:25   ` Helmut Klein
2017-03-28 15:51   ` Jerome Brunet
2017-03-28 15:51     ` Jerome Brunet
2017-03-28 15:51     ` Jerome Brunet
2017-03-28 15:51     ` Jerome Brunet
2017-03-28 18:18     ` Helmut Klein
2017-03-28 18:18       ` Helmut Klein
2017-03-28 18:18       ` Helmut Klein
2017-03-28 18:18       ` Helmut Klein
2017-03-28 19:14       ` Jerome Brunet
2017-03-28 19:14         ` Jerome Brunet
2017-03-28 19:14         ` Jerome Brunet
2017-03-28 21:24         ` Martin Blumenstingl
2017-03-28 21:24           ` Martin Blumenstingl
2017-03-28 21:24           ` Martin Blumenstingl
2017-03-28 21:24           ` Martin Blumenstingl
2017-03-29  6:21           ` Jerome Brunet
2017-03-29  6:21             ` Jerome Brunet
2017-03-29  6:21             ` Jerome Brunet
2017-03-29 20:21           ` Kevin Hilman
2017-03-29 20:21             ` Kevin Hilman
2017-03-29 20:21             ` Kevin Hilman
2017-03-29 20:21             ` Kevin Hilman
2017-03-31 15:37             ` Jerome Brunet
2017-03-31 15:37               ` Jerome Brunet
2017-03-31 15:37               ` Jerome Brunet
2017-03-31 17:03               ` Helmut Klein
2017-03-31 17:03                 ` Helmut Klein
2017-03-31 17:03                 ` Helmut Klein
2017-03-28  9:25 ` [PATCH v2, 2/3] tty/serial: meson_uart: add documentation for the dt-bindings Helmut Klein
2017-03-28  9:25   ` [PATCH v2,2/3] " Helmut Klein
2017-03-28  9:25   ` [PATCH v2, 2/3] " Helmut Klein
2017-03-28  9:25   ` Helmut Klein
2017-03-28 10:05   ` Mark Rutland
2017-03-28 10:05     ` [PATCH v2,2/3] " Mark Rutland
2017-03-28 10:05     ` Mark Rutland
2017-03-28 10:05     ` [PATCH v2, 2/3] " Mark Rutland
2017-03-28 18:20     ` Helmut Klein
2017-03-28 18:20       ` [PATCH v2,2/3] " Helmut Klein
2017-03-28 18:20       ` [PATCH v2, 2/3] " Helmut Klein
2017-03-28 18:20       ` Helmut Klein
2017-03-28  9:25 ` [PATCH v2, 3/3] tty/serial: meson_uart: add the core clock handling to the driver Helmut Klein
2017-03-28  9:25   ` [PATCH v2,3/3] " Helmut Klein
2017-03-28  9:25   ` [PATCH v2, 3/3] " Helmut Klein
2017-03-28  9:25   ` Helmut Klein
2017-03-28 19:16   ` Jerome Brunet [this message]
2017-03-28 19:16     ` Jerome Brunet
2017-03-28 19:16     ` Jerome Brunet
2017-03-28 19:16     ` Jerome Brunet
2017-03-29  9:47     ` Helmut Klein
2017-03-29  9:47       ` Helmut Klein
2017-03-29  9:47       ` Helmut Klein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490728562.20764.9.camel@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.