From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: pablo@netfilter.org
Subject: Re: [RFC 2/3] genetlink: pass extended error report down
Date: Fri, 07 Apr 2017 21:12:23 +0200 [thread overview]
Message-ID: <1491592343.5800.8.camel@sipsolutions.net> (raw)
In-Reply-To: <25e1fb8c-22e0-d7a2-13a7-d0def5432c9e@candelatech.com>
On Fri, 2017-04-07 at 11:37 -0700, Ben Greear wrote:
>
> I guess the error string must be constant and always available in
> memory in this implementation?
Yes.
> I think it would be nice to dynamically create strings (malloc,
> snprintf, etc) and have the err_str logic free it when done?
We can think about that later, but I don't actually think it makes a
lot of sense - if we point to the attribute and/or offset you really
ought to have enough info to figure out what's up.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: Ben Greear <greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org
Subject: Re: [RFC 2/3] genetlink: pass extended error report down
Date: Fri, 07 Apr 2017 21:12:23 +0200 [thread overview]
Message-ID: <1491592343.5800.8.camel@sipsolutions.net> (raw)
In-Reply-To: <25e1fb8c-22e0-d7a2-13a7-d0def5432c9e-my8/4N5VtI7c+919tysfdA@public.gmane.org>
On Fri, 2017-04-07 at 11:37 -0700, Ben Greear wrote:
>
> I guess the error string must be constant and always available in
> memory in this implementation?
Yes.
> I think it would be nice to dynamically create strings (malloc,
> snprintf, etc) and have the err_str logic free it when done?
We can think about that later, but I don't actually think it makes a
lot of sense - if we point to the attribute and/or offset you really
ought to have enough info to figure out what's up.
johannes
next prev parent reply other threads:[~2017-04-07 19:12 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 18:26 [RFC 0/3] netlink: extended error reporting Johannes Berg
2017-04-07 18:26 ` [RFC 1/3] " Johannes Berg
2017-04-07 19:41 ` Johannes Berg
2017-04-07 18:26 ` [RFC 2/3] genetlink: pass extended error report down Johannes Berg
2017-04-07 18:37 ` Ben Greear
2017-04-07 19:12 ` Johannes Berg [this message]
2017-04-07 19:12 ` Johannes Berg
2017-04-07 19:27 ` Ben Greear
2017-04-07 18:26 ` [RFC 3/3] nl80211: add a few extended error strings Johannes Berg
2017-04-07 18:26 ` Johannes Berg
2017-04-07 18:53 ` [RFC 0/3] netlink: extended error reporting David Miller
2017-04-07 18:53 ` David Miller
2017-04-07 18:59 ` Johannes Berg
2017-04-07 18:59 ` Johannes Berg
2017-04-07 19:06 ` Pablo Neira Ayuso
2017-04-07 19:06 ` Pablo Neira Ayuso
2017-04-07 19:09 ` Johannes Berg
2017-04-07 19:09 ` Johannes Berg
2017-04-07 19:21 ` Pablo Neira Ayuso
2017-04-07 19:29 ` Johannes Berg
2017-04-07 19:29 ` Johannes Berg
2017-04-07 19:45 ` Pablo Neira Ayuso
2017-04-07 19:45 ` Pablo Neira Ayuso
2017-04-07 19:47 ` Johannes Berg
2017-04-07 19:34 ` David Miller
2017-04-07 19:34 ` David Miller
2017-04-07 19:22 ` David Miller
2017-04-07 19:27 ` Pablo Neira Ayuso
2017-04-07 19:27 ` Pablo Neira Ayuso
2017-04-07 19:29 ` Johannes Berg
2017-04-07 19:29 ` Johannes Berg
2017-04-07 19:34 ` David Miller
2017-04-07 19:34 ` David Miller
2017-04-07 19:20 ` David Miller
2017-04-07 19:26 ` Johannes Berg
2017-04-07 19:35 ` Pablo Neira Ayuso
2017-04-07 19:43 ` David Miller
2017-04-07 19:46 ` Johannes Berg
2017-04-07 19:46 ` Johannes Berg
2017-04-07 19:55 ` David Miller
2017-04-07 19:55 ` David Miller
2017-04-07 20:27 ` Johannes Berg
2017-04-07 20:27 ` Johannes Berg
2017-04-07 19:02 ` Pablo Neira Ayuso
2017-04-07 19:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491592343.5800.8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.