All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: David Miller <davem@davemloft.net>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC 0/3] netlink: extended error reporting
Date: Fri, 7 Apr 2017 21:06:01 +0200	[thread overview]
Message-ID: <20170407190601.GA22991@salvia> (raw)
In-Reply-To: <1491591552.5800.1.camel@sipsolutions.net>

On Fri, Apr 07, 2017 at 08:59:12PM +0200, Johannes Berg wrote:
[...]
> Heh. I think I really want to solve - at least partially - nla_parse()
> to see that it can be done this way. It'd be nice to even transform all
> the callers (I generated half of these patches with spatch anyway) to
> have at least that.

We can just have a modified version of nla_parse that deals with this.
We can probably use struct nla_policy to place the extended error code
or the string (as we discussed I don't need string errors, but I'm
fine if other people find it useful).

Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC 0/3] netlink: extended error reporting
Date: Fri, 7 Apr 2017 21:06:01 +0200	[thread overview]
Message-ID: <20170407190601.GA22991@salvia> (raw)
In-Reply-To: <1491591552.5800.1.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>

On Fri, Apr 07, 2017 at 08:59:12PM +0200, Johannes Berg wrote:
[...]
> Heh. I think I really want to solve - at least partially - nla_parse()
> to see that it can be done this way. It'd be nice to even transform all
> the callers (I generated half of these patches with spatch anyway) to
> have at least that.

We can just have a modified version of nla_parse that deals with this.
We can probably use struct nla_policy to place the extended error code
or the string (as we discussed I don't need string errors, but I'm
fine if other people find it useful).

Thanks!

  reply	other threads:[~2017-04-07 19:06 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07 18:26 [RFC 0/3] netlink: extended error reporting Johannes Berg
2017-04-07 18:26 ` [RFC 1/3] " Johannes Berg
2017-04-07 19:41   ` Johannes Berg
2017-04-07 18:26 ` [RFC 2/3] genetlink: pass extended error report down Johannes Berg
2017-04-07 18:37   ` Ben Greear
2017-04-07 19:12     ` Johannes Berg
2017-04-07 19:12       ` Johannes Berg
2017-04-07 19:27       ` Ben Greear
2017-04-07 18:26 ` [RFC 3/3] nl80211: add a few extended error strings Johannes Berg
2017-04-07 18:26   ` Johannes Berg
2017-04-07 18:53 ` [RFC 0/3] netlink: extended error reporting David Miller
2017-04-07 18:53   ` David Miller
2017-04-07 18:59   ` Johannes Berg
2017-04-07 18:59     ` Johannes Berg
2017-04-07 19:06     ` Pablo Neira Ayuso [this message]
2017-04-07 19:06       ` Pablo Neira Ayuso
2017-04-07 19:09       ` Johannes Berg
2017-04-07 19:09         ` Johannes Berg
2017-04-07 19:21         ` Pablo Neira Ayuso
2017-04-07 19:29           ` Johannes Berg
2017-04-07 19:29             ` Johannes Berg
2017-04-07 19:45             ` Pablo Neira Ayuso
2017-04-07 19:45               ` Pablo Neira Ayuso
2017-04-07 19:47               ` Johannes Berg
2017-04-07 19:34           ` David Miller
2017-04-07 19:34             ` David Miller
2017-04-07 19:22         ` David Miller
2017-04-07 19:27           ` Pablo Neira Ayuso
2017-04-07 19:27             ` Pablo Neira Ayuso
2017-04-07 19:29             ` Johannes Berg
2017-04-07 19:29               ` Johannes Berg
2017-04-07 19:34             ` David Miller
2017-04-07 19:34               ` David Miller
2017-04-07 19:20     ` David Miller
2017-04-07 19:26       ` Johannes Berg
2017-04-07 19:35       ` Pablo Neira Ayuso
2017-04-07 19:43         ` David Miller
2017-04-07 19:46           ` Johannes Berg
2017-04-07 19:46             ` Johannes Berg
2017-04-07 19:55             ` David Miller
2017-04-07 19:55               ` David Miller
2017-04-07 20:27               ` Johannes Berg
2017-04-07 20:27                 ` Johannes Berg
2017-04-07 19:02   ` Pablo Neira Ayuso
2017-04-07 19:06     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170407190601.GA22991@salvia \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.