From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>
Subject: Re: new warning at net/wireless/util.c:1236
Date: Thu, 4 May 2017 06:06:18 +0000 [thread overview]
Message-ID: <1493877978.14233.85.camel@intel.com> (raw)
In-Reply-To: <87o9v99r3g.fsf@purkki.adurom.net>
T24gVGh1LCAyMDE3LTA1LTA0IGF0IDA3OjM1ICswMzAwLCBLYWxsZSBWYWxvIHdyb3RlOg0KPiBM
aW51cyBUb3J2YWxkcyA8dG9ydmFsZHNAbGludXgtZm91bmRhdGlvbi5vcmc+IHdyaXRlczoNCj4g
DQo+ID4gU28gbXkgRGVsbCBYUFMgMTMgc2VlbXMgdG8gaGF2ZSBncm93biBhIG5ldyB3YXJuaW5n
IGFzIG9mIHRoZQ0KPiA+IG5ldHdvcmtpbmcgbWVyZ2UgeWVzdGVyZGF5Lg0KPiA+IA0KPiA+IFRo
aW5ncyBzdGlsbCB3b3JrLCBidXQgd2hlbiBpdCBzdGFydHMgd2FybmluZywgaXQgZ2VuZXJhdGVz
IGEgKmxvdCogb2YNCj4gPiBub2lzZSAoSSBnb3QgMzYgb2YgdGhlc2Ugd2l0aGluIGFib3V0IHRl
biBtaW51dGVzKS4NCj4gPiANCj4gPiBJIGhhdmUgbm8gaWRlYSB3aGF0IHRyaWdnZXJlZCBpdCwg
YmVjYXVzZSB3aGVuIEkgcmVib290ZWQgKG5vdCBiZWNhdXNlDQo+ID4gb2YgdGhpcyBpc3N1ZSwg
YnV0IGp1c3QgdG8gcmVib290IGludG8gYSBuZXdlciBrZXJuZWwpIEkgZG9uJ3Qgc2VlIGl0DQo+
ID4gYWdhaW4uDQo+ID4gDQo+ID4gVGhpcyBpcyBhbGwgcHJldHR5IHJlZ3VsYXIgd2lyZWxlc3Mg
LSBpdCdzIGludGVsIDgyNjAgd2lyZWxlc3MgaW4gYQ0KPiA+IGZhaXJseSBub3JtYWwgbGFwdG9w
Lg0KPiA+IA0KPiA+IFRoaW5ncyBzdGlsbCBzZWVtIHRvICp3b3JrKiBvaywgc28gdGhlIG9ubHkg
cHJvYmxlbSBoZXJlIGlzIHRoZSBvdmVybHkNCj4gPiB2ZXJib3NlIGFuZCB1c2VsZXNzIFdBUk5f
T04uIEl0IGRvZXNuJ3QgZXZlbiBwcmludCBvdXQgKndoaWNoKiByYXRlIGl0DQo+ID4gaXMgd2Fy
bmluZyBhYm91dCwgaXQganVzdCBkb2VzIHRoYXQgc3R1cGlkIHVuY29uZGl0aW9uYWwgV0FSTl9P
TigpDQo+ID4gd2l0aG91dCBldmVyIHNodXR0aW5nIHVwIGFib3V0IGl0Li4NCj4gPiANCj4gPiBU
aGUgV0FSTl9PTigpIHNlZW1zIHRvIGJlIG9sZCwgYnV0IG15IGxvZ3MgZG9uJ3Qgc2VlbSB0byBo
YXZlIGFueQ0KPiA+IG1lbnRpb24gb2YgdGhpcyB1bnRpbCB0b2RheSwgc28gdGhlcmUncyBzb21l
dGhpbmcgdGhhdCBoYXMgY2hhbmdlZA0KPiA+IHRoYXQgbm93IHRyaWdnZXJzIGl0Lg0KPiA+IA0K
PiA+IElkZWFzPw0KPiA+IA0KPiA+ICAgICAgICAgICAgICAgICAgIExpbnVzDQo+ID4gDQo+ID4g
LS0tDQo+ID4gDQo+ID4gV0FSTklORzogQ1BVOiAzIFBJRDogMTEzOCBhdCBuZXQvd2lyZWxlc3Mv
dXRpbC5jOjEyMzYNCj4gPiBjZmc4MDIxMV9jYWxjdWxhdGVfYml0cmF0ZSsweDEzOS8weDE3MCBb
Y2ZnODAyMTFdDQo+IA0KPiBBcyB0aGlzIGlzIHdpdGggaXdsd2lmaSBhZGRpbmcgYWxzbyBMdWNh
LiBUaGVyZSB3ZXJlIHNvbWUgcmF0ZSBoYW5kbGluZw0KPiBjaGFuZ2VzIGluIGl3bHdpZmksIGxp
a2UgY29tbWl0IDc3ZTQwOTQ1NWY0MSwgYnV0IGRvbid0IGtub3cgaWYgdGhhdA0KPiBjb3VsZCBj
YXVzZSB0aGlzLg0KDQpUaGFua3MgS2FsbGUuICBJIGRvbid0IHNlZSBhbnl0aGluZyBpbiB0aGUg
aXdsd2lmaSBkcml2ZXIgdGhhdCBjb3VsZCBiZQ0KY2F1c2luZyB0aGlzLiAgSm9oYW5uZXMgc3Vz
cGVjdHMgc29tZSBSWCByYXRlIGNoYW5nZXMgaGUgbWFkZSBpbg0KbWFjODAyMTEuLi4NCg0KLS0N
Ckx1Y2Eu
WARNING: multiple messages have this Message-ID (diff)
From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>
Subject: Re: new warning at net/wireless/util.c:1236
Date: Thu, 4 May 2017 06:06:18 +0000 [thread overview]
Message-ID: <1493877978.14233.85.camel@intel.com> (raw)
In-Reply-To: <87o9v99r3g.fsf@purkki.adurom.net>
On Thu, 2017-05-04 at 07:35 +0300, Kalle Valo wrote:
> Linus Torvalds <torvalds@linux-foundation.org> writes:
>
> > So my Dell XPS 13 seems to have grown a new warning as of the
> > networking merge yesterday.
> >
> > Things still work, but when it starts warning, it generates a *lot* of
> > noise (I got 36 of these within about ten minutes).
> >
> > I have no idea what triggered it, because when I rebooted (not because
> > of this issue, but just to reboot into a newer kernel) I don't see it
> > again.
> >
> > This is all pretty regular wireless - it's intel 8260 wireless in a
> > fairly normal laptop.
> >
> > Things still seem to *work* ok, so the only problem here is the overly
> > verbose and useless WARN_ON. It doesn't even print out *which* rate it
> > is warning about, it just does that stupid unconditional WARN_ON()
> > without ever shutting up about it..
> >
> > The WARN_ON() seems to be old, but my logs don't seem to have any
> > mention of this until today, so there's something that has changed
> > that now triggers it.
> >
> > Ideas?
> >
> > Linus
> >
> > ---
> >
> > WARNING: CPU: 3 PID: 1138 at net/wireless/util.c:1236
> > cfg80211_calculate_bitrate+0x139/0x170 [cfg80211]
>
> As this is with iwlwifi adding also Luca. There were some rate handling
> changes in iwlwifi, like commit 77e409455f41, but don't know if that
> could cause this.
Thanks Kalle. I don't see anything in the iwlwifi driver that could be
causing this. Johannes suspects some RX rate changes he made in
mac80211...
--
Luca.
WARNING: multiple messages have this Message-ID (diff)
From: "Coelho, Luciano" <luciano.coelho-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org"
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org"
<kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org"
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org"
<johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Subject: Re: new warning at net/wireless/util.c:1236
Date: Thu, 4 May 2017 06:06:18 +0000 [thread overview]
Message-ID: <1493877978.14233.85.camel@intel.com> (raw)
In-Reply-To: <87o9v99r3g.fsf-5ukZ45wKbUHoml4zekdYB16hYfS7NtTn@public.gmane.org>
On Thu, 2017-05-04 at 07:35 +0300, Kalle Valo wrote:
> Linus Torvalds <torvalds@linux-foundation.org> writes:
>
> > So my Dell XPS 13 seems to have grown a new warning as of the
> > networking merge yesterday.
> >
> > Things still work, but when it starts warning, it generates a *lot* of
> > noise (I got 36 of these within about ten minutes).
> >
> > I have no idea what triggered it, because when I rebooted (not because
> > of this issue, but just to reboot into a newer kernel) I don't see it
> > again.
> >
> > This is all pretty regular wireless - it's intel 8260 wireless in a
> > fairly normal laptop.
> >
> > Things still seem to *work* ok, so the only problem here is the overly
> > verbose and useless WARN_ON. It doesn't even print out *which* rate it
> > is warning about, it just does that stupid unconditional WARN_ON()
> > without ever shutting up about it..
> >
> > The WARN_ON() seems to be old, but my logs don't seem to have any
> > mention of this until today, so there's something that has changed
> > that now triggers it.
> >
> > Ideas?
> >
> > Linus
> >
> > ---
> >
> > WARNING: CPU: 3 PID: 1138 at net/wireless/util.c:1236
> > cfg80211_calculate_bitrate+0x139/0x170 [cfg80211]
>
> As this is with iwlwifi adding also Luca. There were some rate handling
> changes in iwlwifi, like commit 77e409455f41, but don't know if that
> could cause this.
Thanks Kalle. I don't see anything in the iwlwifi driver that could be
causing this. Johannes suspects some RX rate changes he made in
mac80211...
--
Luca.
next prev parent reply other threads:[~2017-05-04 6:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 2:28 new warning at net/wireless/util.c:1236 Linus Torvalds
2017-05-04 4:35 ` Kalle Valo
2017-05-04 6:06 ` Coelho, Luciano [this message]
2017-05-04 6:06 ` Coelho, Luciano
2017-05-04 6:06 ` Coelho, Luciano
2017-05-04 6:41 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493877978.14233.85.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.