From: Johannes Berg <johannes@sipsolutions.net>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCH v7 0/5] skb_to_sgvec hardening
Date: Tue, 09 May 2017 16:03:20 +0200 [thread overview]
Message-ID: <1494338600.2410.6.camel@sipsolutions.net> (raw)
In-Reply-To: <20170509135009.13751-1-Jason@zx2c4.com> (sfid-20170509_155352_302082_2551EB62)
On Tue, 2017-05-09 at 15:50 +0200, Jason A. Donenfeld wrote:
> The recent bug with macsec and historical one with virtio have
> indicated that letting skb_to_sgvec trounce all over an sglist
> without checking the length is probably a bad idea. And it's not
> necessary either: an sglist already explicitly marks its last
> item, and the initialization functions are diligent in doing so.
> Thus there's a clear way of avoiding future overflows.
>
> So, this patchset, from a high level, makes skb_to_sgvec return
> a potential error code, and then adjusts all callers to check
> for the error code.
Perhaps you should add __must_check annotation to the function
prototype(s)?
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v7 0/5] skb_to_sgvec hardening
Date: Tue, 09 May 2017 16:03:20 +0200 [thread overview]
Message-ID: <1494338600.2410.6.camel@sipsolutions.net> (raw)
In-Reply-To: <20170509135009.13751-1-Jason@zx2c4.com> (sfid-20170509_155352_302082_2551EB62)
On Tue, 2017-05-09 at 15:50 +0200, Jason A. Donenfeld wrote:
> The recent bug with macsec and historical one with virtio have
> indicated that letting skb_to_sgvec trounce all over an sglist
> without checking the length is probably a bad idea. And it's not
> necessary either: an sglist already explicitly marks its last
> item, and the initialization functions are diligent in doing so.
> Thus there's a clear way of avoiding future overflows.
>
> So, this patchset, from a high level, makes skb_to_sgvec return
> a potential error code, and then adjusts all callers to check
> for the error code.
Perhaps you should add __must_check annotation to the function
prototype(s)?
johannes
next prev parent reply other threads:[~2017-05-09 14:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 13:50 [kernel-hardening] [PATCH v7 0/5] skb_to_sgvec hardening Jason A. Donenfeld
2017-05-09 13:50 ` Jason A. Donenfeld
2017-05-09 13:50 ` [kernel-hardening] [PATCH v7 1/5] skbuff: return -EMSGSIZE in skb_to_sgvec to prevent overflow Jason A. Donenfeld
2017-05-09 13:50 ` Jason A. Donenfeld
2017-05-09 13:50 ` [kernel-hardening] [PATCH v7 2/5] ipsec: check return value of skb_to_sgvec always Jason A. Donenfeld
2017-05-09 13:50 ` Jason A. Donenfeld
2017-05-09 14:09 ` [kernel-hardening] " Jason A. Donenfeld
2017-05-09 14:09 ` Jason A. Donenfeld
2017-05-09 13:50 ` [kernel-hardening] [PATCH v7 3/5] rxrpc: " Jason A. Donenfeld
2017-05-09 13:50 ` Jason A. Donenfeld
2017-05-09 13:50 ` [kernel-hardening] [PATCH v7 4/5] macsec: " Jason A. Donenfeld
2017-05-09 13:50 ` Jason A. Donenfeld
2017-05-09 13:50 ` [kernel-hardening] [PATCH v7 5/5] virtio_net: " Jason A. Donenfeld
2017-05-09 13:50 ` Jason A. Donenfeld
2017-05-09 14:10 ` [kernel-hardening] " Jason A. Donenfeld
2017-05-09 14:10 ` Jason A. Donenfeld
2017-05-09 14:03 ` Johannes Berg [this message]
2017-05-09 14:03 ` [PATCH v7 0/5] skb_to_sgvec hardening Johannes Berg
2017-05-09 14:08 ` [kernel-hardening] " Jason A. Donenfeld
2017-05-09 14:08 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494338600.2410.6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.