From: Gerd Hoffmann <kraxel@redhat.com>
To: Owen Smith <owen.smith@citrix.com>, qemu-devel@nongnu.org
Cc: sstabellini@kernel.org, anthony.perard@citrix.com,
xen-devel@lists.xenproject.org
Subject: Re: [Qemu-devel] [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers
Date: Thu, 08 Jun 2017 15:39:12 +0200 [thread overview]
Message-ID: <1496929152.29761.3.camel@redhat.com> (raw)
In-Reply-To: <1496927734-29174-4-git-send-email-owen.smith@citrix.com>
diff --git a/ui/input-legacy.c b/ui/input-legacy.c
> index 7159747..fbe1ce7 100644
> --- a/ui/input-legacy.c
> +++ b/ui/input-legacy.c
> @@ -142,6 +142,18 @@ QEMUPutKbdEntry
> *qemu_add_kbd_event_handler(QEMUPutKBDEvent *func, void *opaque)
> return entry;
> }
>
> +void qemu_activate_kbd_event_handler(QEMUPutKbdEntry *entry)
Please don't add new code to input-legacy.c please.
Switch your code to use the new qemu_input_handler_*() functions
directly instead.
cheers,
Gerd
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Owen Smith <owen.smith@citrix.com>, qemu-devel@nongnu.org
Cc: anthony.perard@citrix.com, xen-devel@lists.xenproject.org,
sstabellini@kernel.org
Subject: Re: [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers
Date: Thu, 08 Jun 2017 15:39:12 +0200 [thread overview]
Message-ID: <1496929152.29761.3.camel@redhat.com> (raw)
In-Reply-To: <1496927734-29174-4-git-send-email-owen.smith@citrix.com>
diff --git a/ui/input-legacy.c b/ui/input-legacy.c
> index 7159747..fbe1ce7 100644
> --- a/ui/input-legacy.c
> +++ b/ui/input-legacy.c
> @@ -142,6 +142,18 @@ QEMUPutKbdEntry
> *qemu_add_kbd_event_handler(QEMUPutKBDEvent *func, void *opaque)
> return entry;
> }
>
> +void qemu_activate_kbd_event_handler(QEMUPutKbdEntry *entry)
Please don't add new code to input-legacy.c please.
Switch your code to use the new qemu_input_handler_*() functions
directly instead.
cheers,
Gerd
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-08 13:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 13:15 [Qemu-devel] [PATCH 0/4] xenfb: Add vkbd-only option Owen Smith
2017-06-08 13:15 ` Owen Smith
2017-06-08 13:15 ` [Qemu-devel] [PATCH 1/4] xenfb: Add feature-vkbd-standalone Owen Smith
2017-06-08 13:15 ` Owen Smith
2017-06-08 22:31 ` [Qemu-devel] " Stefano Stabellini
2017-06-08 22:31 ` Stefano Stabellini
2017-06-08 13:15 ` [Qemu-devel] [PATCH 2/4] xenfb: Activate mouse handler Owen Smith
2017-06-08 13:15 ` Owen Smith
2017-06-08 22:33 ` [Qemu-devel] " Stefano Stabellini
2017-06-08 22:33 ` Stefano Stabellini
2017-06-08 13:15 ` [Qemu-devel] [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers Owen Smith
2017-06-08 13:15 ` Owen Smith
2017-06-08 13:39 ` Gerd Hoffmann [this message]
2017-06-08 13:39 ` Gerd Hoffmann
2017-06-13 15:01 ` [Qemu-devel] " Owen Smith
2017-06-13 15:01 ` Owen Smith
2017-06-08 13:15 ` [Qemu-devel] [PATCH 4/4] xenfb: Fix leak by adding/removing keyboard handler Owen Smith
2017-06-08 13:15 ` Owen Smith
2017-06-08 22:24 ` [Qemu-devel] [PATCH 0/4] xenfb: Add vkbd-only option Stefano Stabellini
2017-06-08 22:24 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496929152.29761.3.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=owen.smith@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.