All of lore.kernel.org
 help / color / mirror / Atom feed
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes
Date: Mon, 12 Jun 2017 11:13:43 +0200	[thread overview]
Message-ID: <1497258823.3086.6.camel@baylibre.com> (raw)
In-Reply-To: <1497001756-942-7-git-send-email-narmstrong@baylibre.com>

On Fri, 2017-06-09 at 11:49 +0200, Neil Armstrong wrote:
> Switch to the stable UART bindings by adding a XTAL node and using the
> proper compatible strings.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> ?arch/arm/boot/dts/meson8.dtsi | 23 +++++++++++++++++++----
> ?1 file changed, 19 insertions(+), 4 deletions(-)

I think this is clashing with the recent change from Martin on meson8 clock
driver. Kevin just applied it :?

https://lkml.kernel.org/r/m2d1ad9g38.fsf at baylibre.com

<&clk81> no longer exists ...

> 
> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
> index 6993077..a2ea112 100644
> --- a/arch/arm/boot/dts/meson8.dtsi
> +++ b/arch/arm/boot/dts/meson8.dtsi
> @@ -83,6 +83,13 @@
> ?		};
> ?	};
> ?
> +	xtal: xtal-clk {
> +		compatible = "fixed-clock";
> +		clock-frequency = <24000000>;
> +		clock-output-names = "xtal";
> +		#clock-cells = <0>;
> +	};
> +
> ?	clk81: clk at 0 {
> ?		#clock-cells = <0>;
> ?		compatible = "fixed-clock";
> @@ -199,17 +206,25 @@
> ?};
> ?
> ?&uart_AO {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart", "amlogic,meson-ao-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};
> ?
> ?&uart_A {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};
> ?
> ?&uart_B {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};
> ?
> ?&uart_C {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};

WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
To: Neil Armstrong
	<narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org
Cc: hgkr.klein-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes
Date: Mon, 12 Jun 2017 11:13:43 +0200	[thread overview]
Message-ID: <1497258823.3086.6.camel@baylibre.com> (raw)
In-Reply-To: <1497001756-942-7-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>

On Fri, 2017-06-09 at 11:49 +0200, Neil Armstrong wrote:
> Switch to the stable UART bindings by adding a XTAL node and using the
> proper compatible strings.
> 
> Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> ---
>  arch/arm/boot/dts/meson8.dtsi | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)

I think this is clashing with the recent change from Martin on meson8 clock
driver. Kevin just applied it : 

https://lkml.kernel.org/r/m2d1ad9g38.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org

<&clk81> no longer exists ...

> 
> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
> index 6993077..a2ea112 100644
> --- a/arch/arm/boot/dts/meson8.dtsi
> +++ b/arch/arm/boot/dts/meson8.dtsi
> @@ -83,6 +83,13 @@
>  		};
>  	};
>  
> +	xtal: xtal-clk {
> +		compatible = "fixed-clock";
> +		clock-frequency = <24000000>;
> +		clock-output-names = "xtal";
> +		#clock-cells = <0>;
> +	};
> +
>  	clk81: clk@0 {
>  		#clock-cells = <0>;
>  		compatible = "fixed-clock";
> @@ -199,17 +206,25 @@
>  };
>  
>  &uart_AO {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart", "amlogic,meson-ao-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
>  };
>  
>  &uart_A {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
>  };
>  
>  &uart_B {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
>  };
>  
>  &uart_C {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
>  };

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes
Date: Mon, 12 Jun 2017 11:13:43 +0200	[thread overview]
Message-ID: <1497258823.3086.6.camel@baylibre.com> (raw)
In-Reply-To: <1497001756-942-7-git-send-email-narmstrong@baylibre.com>

On Fri, 2017-06-09 at 11:49 +0200, Neil Armstrong wrote:
> Switch to the stable UART bindings by adding a XTAL node and using the
> proper compatible strings.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> ?arch/arm/boot/dts/meson8.dtsi | 23 +++++++++++++++++++----
> ?1 file changed, 19 insertions(+), 4 deletions(-)

I think this is clashing with the recent change from Martin on meson8 clock
driver. Kevin just applied it :?

https://lkml.kernel.org/r/m2d1ad9g38.fsf at baylibre.com

<&clk81> no longer exists ...

> 
> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
> index 6993077..a2ea112 100644
> --- a/arch/arm/boot/dts/meson8.dtsi
> +++ b/arch/arm/boot/dts/meson8.dtsi
> @@ -83,6 +83,13 @@
> ?		};
> ?	};
> ?
> +	xtal: xtal-clk {
> +		compatible = "fixed-clock";
> +		clock-frequency = <24000000>;
> +		clock-output-names = "xtal";
> +		#clock-cells = <0>;
> +	};
> +
> ?	clk81: clk at 0 {
> ?		#clock-cells = <0>;
> ?		compatible = "fixed-clock";
> @@ -199,17 +206,25 @@
> ?};
> ?
> ?&uart_AO {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart", "amlogic,meson-ao-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};
> ?
> ?&uart_A {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};
> ?
> ?&uart_B {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};
> ?
> ?&uart_C {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};

WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
	gregkh@linuxfoundation.org, khilman@baylibre.com
Cc: hgkr.klein@gmail.com, linux-serial@vger.kernel.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes
Date: Mon, 12 Jun 2017 11:13:43 +0200	[thread overview]
Message-ID: <1497258823.3086.6.camel@baylibre.com> (raw)
In-Reply-To: <1497001756-942-7-git-send-email-narmstrong@baylibre.com>

On Fri, 2017-06-09 at 11:49 +0200, Neil Armstrong wrote:
> Switch to the stable UART bindings by adding a XTAL node and using the
> proper compatible strings.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  arch/arm/boot/dts/meson8.dtsi | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)

I think this is clashing with the recent change from Martin on meson8 clock
driver. Kevin just applied it : 

https://lkml.kernel.org/r/m2d1ad9g38.fsf@baylibre.com

<&clk81> no longer exists ...

> 
> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
> index 6993077..a2ea112 100644
> --- a/arch/arm/boot/dts/meson8.dtsi
> +++ b/arch/arm/boot/dts/meson8.dtsi
> @@ -83,6 +83,13 @@
>  		};
>  	};
>  
> +	xtal: xtal-clk {
> +		compatible = "fixed-clock";
> +		clock-frequency = <24000000>;
> +		clock-output-names = "xtal";
> +		#clock-cells = <0>;
> +	};
> +
>  	clk81: clk@0 {
>  		#clock-cells = <0>;
>  		compatible = "fixed-clock";
> @@ -199,17 +206,25 @@
>  };
>  
>  &uart_AO {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart", "amlogic,meson-ao-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
>  };
>  
>  &uart_A {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
>  };
>  
>  &uart_B {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
>  };
>  
>  &uart_C {
> -	clocks = <&clk81>;
> +	compatible = "amlogic,meson8-uart";
> +	clocks = <&xtal>, <&clk81>, <&clk81>;
> +	clock-names = "xtal", "pclk", "baud";
>  };

  parent reply	other threads:[~2017-06-12  9:13 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09  9:49 [PATCH v4 0/7] tty/serial: meson_uart: add support for core clock handling Neil Armstrong
2017-06-09  9:49 ` Neil Armstrong
2017-06-09  9:49 ` Neil Armstrong
2017-06-09  9:49 ` Neil Armstrong
2017-06-09  9:49 ` [PATCH v4 1/7] dt-bindings: serial: Add bindings for the Amlogic Meson UARTs Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49 ` [PATCH v4 2/7] tty/serial: meson_uart: update to stable bindings Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-12  9:39   ` Jerome Brunet
2017-06-12  9:39     ` Jerome Brunet
2017-06-12  9:39     ` Jerome Brunet
2017-06-12 12:48     ` Neil Armstrong
2017-06-12 12:48       ` Neil Armstrong
2017-06-12 12:48       ` Neil Armstrong
2017-06-12 12:45   ` Chris Moore
2017-06-12 12:45     ` Chris Moore
2017-06-12 12:45     ` Chris Moore
2017-06-12 12:48     ` Neil Armstrong
2017-06-12 12:48       ` Neil Armstrong
2017-06-12 12:48       ` Neil Armstrong
2017-06-09  9:49 ` [PATCH v4 3/7] ARM64: dts: meson-gx: use stable UART bindings with correct gate clock Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-12  9:40   ` Jerome Brunet
2017-06-12  9:40     ` Jerome Brunet
2017-06-12  9:40     ` Jerome Brunet
2017-06-09  9:49 ` [PATCH v4 4/7] ARM: dts: meson: use meson6 UART compatible like other nodes Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49 ` [PATCH v4 5/7] ARM: dts: meson6: switch to new bindings for UART nodes Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-12  9:42   ` Jerome Brunet
2017-06-12  9:42     ` Jerome Brunet
2017-06-12  9:42     ` Jerome Brunet
2017-06-12  9:42     ` Jerome Brunet
2017-06-12 12:49     ` Neil Armstrong
2017-06-12 12:49       ` Neil Armstrong
2017-06-12 12:49       ` Neil Armstrong
2017-06-09  9:49 ` [PATCH v4 6/7] ARM: dts: meson8: " Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09 22:37   ` Martin Blumenstingl
2017-06-09 22:37     ` Martin Blumenstingl
2017-06-09 22:37     ` Martin Blumenstingl
2017-06-09 22:37     ` Martin Blumenstingl
2017-06-11 20:18     ` Martin Blumenstingl
2017-06-11 20:18       ` Martin Blumenstingl
2017-06-11 20:18       ` Martin Blumenstingl
2017-06-11 20:18       ` Martin Blumenstingl
2017-06-12  7:27       ` Neil Armstrong
2017-06-12  7:27         ` Neil Armstrong
2017-06-12  7:27         ` Neil Armstrong
2017-06-12  9:13   ` Jerome Brunet [this message]
2017-06-12  9:13     ` Jerome Brunet
2017-06-12  9:13     ` Jerome Brunet
2017-06-12  9:13     ` Jerome Brunet
2017-06-12 12:49     ` Neil Armstrong
2017-06-12 12:49       ` Neil Armstrong
2017-06-12 12:49       ` Neil Armstrong
2017-06-09  9:49 ` [PATCH v4 7/7] ARM: dts: meson8b: " Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-12  9:47   ` Jerome Brunet
2017-06-12  9:47     ` Jerome Brunet
2017-06-12  9:47     ` Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497258823.3086.6.camel@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.