All of lore.kernel.org
 help / color / mirror / Atom feed
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 7/7] ARM: dts: meson8b: switch to new bindings for UART nodes
Date: Mon, 12 Jun 2017 11:47:59 +0200	[thread overview]
Message-ID: <1497260879.3086.13.camel@baylibre.com> (raw)
In-Reply-To: <1497001756-942-8-git-send-email-narmstrong@baylibre.com>

On Fri, 2017-06-09 at 11:49 +0200, Neil Armstrong wrote:
> Switch to the stable UART bindings by adding a XTAL node and using the
> proper compatible strings.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> ?arch/arm/boot/dts/meson8b.dtsi | 23 +++++++++++++++++++----
> ?1 file changed, 19 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index d9f116a..651ad4a 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -82,6 +82,13 @@
> ?			reg = <0x203>;
> ?		};
> ?	};
> +
> +	xtal: xtal-clk {
> +		compatible = "fixed-clock";
> +		clock-frequency = <24000000>;
> +		clock-output-names = "xtal";
> +		#clock-cells = <0>;
> +	};

On meson8b, I think xtal is already provided by <&clkc CLKID_XTAL>.
We have to choose which one we want.

With this handled:

Acked-by: Jerome Brunet <jbrunet@baylibre.com>

> ?}; /* end of / */
> ?
> ?&aobus {
> @@ -178,17 +185,25 @@
> ?};
> ?
> ?&uart_AO {
> -	clocks = <&clkc CLKID_CLK81>;
> +	compatible = "amlogic,meson8b-uart", "amlogic,meson-ao-uart";
> +	clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};
> ?
> ?&uart_A {
> -	clocks = <&clkc CLKID_CLK81>;
> +	compatible = "amlogic,meson8b-uart";
> +	clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};
> ?
> ?&uart_B {
> -	clocks = <&clkc CLKID_CLK81>;
> +	compatible = "amlogic,meson8b-uart";
> +	clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};
> ?
> ?&uart_C {
> -	clocks = <&clkc CLKID_CLK81>;
> +	compatible = "amlogic,meson8b-uart";
> +	clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};

WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
	gregkh@linuxfoundation.org, khilman@baylibre.com
Cc: hgkr.klein@gmail.com, linux-serial@vger.kernel.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 7/7] ARM: dts: meson8b: switch to new bindings for UART nodes
Date: Mon, 12 Jun 2017 11:47:59 +0200	[thread overview]
Message-ID: <1497260879.3086.13.camel@baylibre.com> (raw)
In-Reply-To: <1497001756-942-8-git-send-email-narmstrong@baylibre.com>

On Fri, 2017-06-09 at 11:49 +0200, Neil Armstrong wrote:
> Switch to the stable UART bindings by adding a XTAL node and using the
> proper compatible strings.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  arch/arm/boot/dts/meson8b.dtsi | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index d9f116a..651ad4a 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -82,6 +82,13 @@
>  			reg = <0x203>;
>  		};
>  	};
> +
> +	xtal: xtal-clk {
> +		compatible = "fixed-clock";
> +		clock-frequency = <24000000>;
> +		clock-output-names = "xtal";
> +		#clock-cells = <0>;
> +	};

On meson8b, I think xtal is already provided by <&clkc CLKID_XTAL>.
We have to choose which one we want.

With this handled:

Acked-by: Jerome Brunet <jbrunet@baylibre.com>

>  }; /* end of / */
>  
>  &aobus {
> @@ -178,17 +185,25 @@
>  };
>  
>  &uart_AO {
> -	clocks = <&clkc CLKID_CLK81>;
> +	compatible = "amlogic,meson8b-uart", "amlogic,meson-ao-uart";
> +	clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> +	clock-names = "xtal", "pclk", "baud";
>  };
>  
>  &uart_A {
> -	clocks = <&clkc CLKID_CLK81>;
> +	compatible = "amlogic,meson8b-uart";
> +	clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> +	clock-names = "xtal", "pclk", "baud";
>  };
>  
>  &uart_B {
> -	clocks = <&clkc CLKID_CLK81>;
> +	compatible = "amlogic,meson8b-uart";
> +	clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> +	clock-names = "xtal", "pclk", "baud";
>  };
>  
>  &uart_C {
> -	clocks = <&clkc CLKID_CLK81>;
> +	compatible = "amlogic,meson8b-uart";
> +	clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> +	clock-names = "xtal", "pclk", "baud";
>  };

WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 7/7] ARM: dts: meson8b: switch to new bindings for UART nodes
Date: Mon, 12 Jun 2017 11:47:59 +0200	[thread overview]
Message-ID: <1497260879.3086.13.camel@baylibre.com> (raw)
In-Reply-To: <1497001756-942-8-git-send-email-narmstrong@baylibre.com>

On Fri, 2017-06-09 at 11:49 +0200, Neil Armstrong wrote:
> Switch to the stable UART bindings by adding a XTAL node and using the
> proper compatible strings.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> ?arch/arm/boot/dts/meson8b.dtsi | 23 +++++++++++++++++++----
> ?1 file changed, 19 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index d9f116a..651ad4a 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -82,6 +82,13 @@
> ?			reg = <0x203>;
> ?		};
> ?	};
> +
> +	xtal: xtal-clk {
> +		compatible = "fixed-clock";
> +		clock-frequency = <24000000>;
> +		clock-output-names = "xtal";
> +		#clock-cells = <0>;
> +	};

On meson8b, I think xtal is already provided by <&clkc CLKID_XTAL>.
We have to choose which one we want.

With this handled:

Acked-by: Jerome Brunet <jbrunet@baylibre.com>

> ?}; /* end of / */
> ?
> ?&aobus {
> @@ -178,17 +185,25 @@
> ?};
> ?
> ?&uart_AO {
> -	clocks = <&clkc CLKID_CLK81>;
> +	compatible = "amlogic,meson8b-uart", "amlogic,meson-ao-uart";
> +	clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};
> ?
> ?&uart_A {
> -	clocks = <&clkc CLKID_CLK81>;
> +	compatible = "amlogic,meson8b-uart";
> +	clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};
> ?
> ?&uart_B {
> -	clocks = <&clkc CLKID_CLK81>;
> +	compatible = "amlogic,meson8b-uart";
> +	clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};
> ?
> ?&uart_C {
> -	clocks = <&clkc CLKID_CLK81>;
> +	compatible = "amlogic,meson8b-uart";
> +	clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> +	clock-names = "xtal", "pclk", "baud";
> ?};

  reply	other threads:[~2017-06-12  9:47 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09  9:49 [PATCH v4 0/7] tty/serial: meson_uart: add support for core clock handling Neil Armstrong
2017-06-09  9:49 ` Neil Armstrong
2017-06-09  9:49 ` Neil Armstrong
2017-06-09  9:49 ` Neil Armstrong
2017-06-09  9:49 ` [PATCH v4 1/7] dt-bindings: serial: Add bindings for the Amlogic Meson UARTs Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49 ` [PATCH v4 2/7] tty/serial: meson_uart: update to stable bindings Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-12  9:39   ` Jerome Brunet
2017-06-12  9:39     ` Jerome Brunet
2017-06-12  9:39     ` Jerome Brunet
2017-06-12 12:48     ` Neil Armstrong
2017-06-12 12:48       ` Neil Armstrong
2017-06-12 12:48       ` Neil Armstrong
2017-06-12 12:45   ` Chris Moore
2017-06-12 12:45     ` Chris Moore
2017-06-12 12:45     ` Chris Moore
2017-06-12 12:48     ` Neil Armstrong
2017-06-12 12:48       ` Neil Armstrong
2017-06-12 12:48       ` Neil Armstrong
2017-06-09  9:49 ` [PATCH v4 3/7] ARM64: dts: meson-gx: use stable UART bindings with correct gate clock Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-12  9:40   ` Jerome Brunet
2017-06-12  9:40     ` Jerome Brunet
2017-06-12  9:40     ` Jerome Brunet
2017-06-09  9:49 ` [PATCH v4 4/7] ARM: dts: meson: use meson6 UART compatible like other nodes Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49 ` [PATCH v4 5/7] ARM: dts: meson6: switch to new bindings for UART nodes Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-12  9:42   ` Jerome Brunet
2017-06-12  9:42     ` Jerome Brunet
2017-06-12  9:42     ` Jerome Brunet
2017-06-12  9:42     ` Jerome Brunet
2017-06-12 12:49     ` Neil Armstrong
2017-06-12 12:49       ` Neil Armstrong
2017-06-12 12:49       ` Neil Armstrong
2017-06-09  9:49 ` [PATCH v4 6/7] ARM: dts: meson8: " Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09 22:37   ` Martin Blumenstingl
2017-06-09 22:37     ` Martin Blumenstingl
2017-06-09 22:37     ` Martin Blumenstingl
2017-06-09 22:37     ` Martin Blumenstingl
2017-06-11 20:18     ` Martin Blumenstingl
2017-06-11 20:18       ` Martin Blumenstingl
2017-06-11 20:18       ` Martin Blumenstingl
2017-06-11 20:18       ` Martin Blumenstingl
2017-06-12  7:27       ` Neil Armstrong
2017-06-12  7:27         ` Neil Armstrong
2017-06-12  7:27         ` Neil Armstrong
2017-06-12  9:13   ` Jerome Brunet
2017-06-12  9:13     ` Jerome Brunet
2017-06-12  9:13     ` Jerome Brunet
2017-06-12  9:13     ` Jerome Brunet
2017-06-12 12:49     ` Neil Armstrong
2017-06-12 12:49       ` Neil Armstrong
2017-06-12 12:49       ` Neil Armstrong
2017-06-09  9:49 ` [PATCH v4 7/7] ARM: dts: meson8b: " Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-09  9:49   ` Neil Armstrong
2017-06-12  9:47   ` Jerome Brunet [this message]
2017-06-12  9:47     ` Jerome Brunet
2017-06-12  9:47     ` Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497260879.3086.13.camel@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.