From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: linuxwifi <linuxwifi@intel.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"jprvita@gmail.com" <jprvita@gmail.com>,
"Berg, Johannes" <johannes.berg@intel.com>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux@endlessm.com" <linux@endlessm.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"jprvita@endlessm.com" <jprvita@endlessm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: Demote messages about fw flags size to info
Date: Mon, 24 Jul 2017 11:01:27 +0000 [thread overview]
Message-ID: <1500894086.20057.12.camel@intel.com> (raw)
In-Reply-To: <20170721145147.7572-1-jprvita@endlessm.com>
T24gRnJpLCAyMDE3LTA3LTIxIGF0IDA3OjUxIC0wNzAwLCBKb8OjbyBQYXVsbyBSZWNoaSBWaXRh
IHdyb3RlOg0KPiBUaGVzZSBtZXNzYWdlcyBhcmUgbm90IHJlcG9ydGluZyBhIHJlYWwgZXJyb3Is
IGp1c3QgdGhlIGZhY3QgdGhhdCB0aGUNCj4gZmlybXdhcmUga25vd3MgYWJvdXQgbW9yZSBmbGFn
cyB0aGVuIHRoZSBkcml2ZXIuDQo+IA0KPiBDdXJyZW50bHkgdGhlc2UgbWVzc2FnZXMgYXJlIHBy
ZXNlbnRlZCB0byB0aGUgdXNlciBkdXJpbmcgYm9vdCBpZiB0aGVyZQ0KPiBpcyBubyBib290c3Bs
YXNoIGNvdmVyaW5nIHRoZSBjb25zb2xlLCBzb21ldGltZXMgZXZlbiBpZiB0aGUgYm9vdCBzcGxh
c2gNCj4gaXMgZW5hYmxlZCBidXQgaGFzIG5vdCBzdGFydGVkIHlldCBieSB0aGUgdGltZSB0aGlz
IG1lc3NhZ2UgaXMgc2hvd24uDQo+IA0KPiBEZW1vdGluZyBpdCB0byB0aGUgaW5mbyBsZXZlbCBo
ZWxwcyBoYXZpbmcgYSBjbGVhbiBib290IHByb2Nlc3MuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBK
b8OjbyBQYXVsbyBSZWNoaSBWaXRhIDxqcHJ2aXRhQGVuZGxlc3NtLmNvbT4NCj4gLS0tDQoNClRo
ZSBpZGVhIHdpdGggdGhpcyBlcnJvciBpcyB0aGF0IGlmIHRoZSBmaXJtd2FyZSBpcyB0b28gbmV3
IGFuZCBpbmNsdWRlcw0KYSBUTFYgdGhhdCB3ZSBhcmUgbm90IGF3YXJlIG9mLCB0aGVyZSBjYW4g
YmUgdW5leHBlY3RlZCBpc3N1ZXMuICBGb3INCmluc3RhbmNlLCBzb21ldGltZXMgdGhlIEZXIEFQ
SSBjaGFuZ2VzIHNvbWUgb2YgaXRzIHN0cnVjdHVyZXMgYW5kIHdlIHVzZQ0KVExWcyB0byBrbm93
IHdoaWNoIG9uZSB0byB1c2UuICBJZiBhIG5ldyBzdHJ1Y3QgaXMgaW4gdXNlIGJ5IHRoZQ0KZmly
bXdhcmUgYnV0IG5vdCBieSB0aGUgZHJpdmVyLCBwcm9ibGVtcyB3aWxsIG9jY3VyLg0KDQpSZWNl
bnRseSB3ZSBhY2NpZGVudGFsbHkgb21pdHRlZCBvbmUgVExWIGZyb20gdGhlIGRyaXZlciBhbmQg
cmVsZWFzZWQgYQ0KbmV3IGZpcm13YXJlIHRoYXQgaGFkIGl0IHNldC4uLiBUaGF0J3MgdGhlIGVy
cm9yIHlvdSBhcmUgY3VycmVudGx5DQpzZWVpbmcuICBXZSBoYXZlIGEgYnVnemlsbGEgZW50cnlb
MV0gYW5kIGl0IGlzIGZpeGVkIGluIG91ciBpbnRlcm5hbA0KdHJlZS4gIFRoZSBmaXggd2lsbCBi
ZSBzZW50IHVwc3RyZWFtIGluIHRoZSBuZXh0IC1maXhlcyByb3VuZCB3ZSBzZW5kDQpvdXQuDQoN
ClRoaXMgc3BlY2lmaWMgY2FzZSBpcyBoYXJtbGVzcywgYnV0IEknZCByYXRoZXIga2VlcCB0aGlz
IG1lc3NhZ2UgYXMgYW4NCmVycm9yLCBiZWNhdXNlIGluIG90aGVyIHNpdHVhdGlvbnMgaXQgY291
bGQgbGVhZCB0byB1bmV4cGVjdGVkDQpiZWhhdmlvaXIsIHNvIEkgcHJlZmVyIHRvIGtlZXAgaXQg
dmVyeSB2aXNpYmxlLg0KDQoNClsxXSBodHRwczovL2J1Z3ppbGxhLmtlcm5lbC5vcmcvc2hvd19i
dWcuY2dpP2lkPTE5NjE5NQ0KDQotLQ0KQ2hlZXJzLA0KTHVjYS4=
WARNING: multiple messages have this Message-ID (diff)
From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: linuxwifi <linuxwifi@intel.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"jprvita@gmail.com" <jprvita@gmail.com>,
"Berg, Johannes" <johannes.berg@intel.com>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux@endlessm.com" <linux@endlessm.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"jprvita@endlessm.com" <jprvita@endlessm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: Demote messages about fw flags size to info
Date: Mon, 24 Jul 2017 11:01:27 +0000 [thread overview]
Message-ID: <1500894086.20057.12.camel@intel.com> (raw)
In-Reply-To: <20170721145147.7572-1-jprvita@endlessm.com>
On Fri, 2017-07-21 at 07:51 -0700, João Paulo Rechi Vita wrote:
> These messages are not reporting a real error, just the fact that the
> firmware knows about more flags then the driver.
>
> Currently these messages are presented to the user during boot if there
> is no bootsplash covering the console, sometimes even if the boot splash
> is enabled but has not started yet by the time this message is shown.
>
> Demoting it to the info level helps having a clean boot process.
>
> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
> ---
The idea with this error is that if the firmware is too new and includes
a TLV that we are not aware of, there can be unexpected issues. For
instance, sometimes the FW API changes some of its structures and we use
TLVs to know which one to use. If a new struct is in use by the
firmware but not by the driver, problems will occur.
Recently we accidentally omitted one TLV from the driver and released a
new firmware that had it set... That's the error you are currently
seeing. We have a bugzilla entry[1] and it is fixed in our internal
tree. The fix will be sent upstream in the next -fixes round we send
out.
This specific case is harmless, but I'd rather keep this message as an
error, because in other situations it could lead to unexpected
behavioir, so I prefer to keep it very visible.
[1] https://bugzilla.kernel.org/show_bug.cgi?id=196195
--
Cheers,
Luca.
next prev parent reply other threads:[~2017-07-24 11:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 14:51 [PATCH] iwlwifi: Demote messages about fw flags size to info João Paulo Rechi Vita
2017-07-24 11:01 ` Coelho, Luciano [this message]
2017-07-24 11:01 ` Coelho, Luciano
2017-08-01 22:58 ` João Paulo Rechi Vita
2017-08-01 22:58 ` João Paulo Rechi Vita
2017-08-02 4:46 ` Luca Coelho
2017-08-03 14:30 ` [PATCH v2] " João Paulo Rechi Vita
2017-08-03 14:36 ` David Laight
2017-08-03 14:36 ` David Laight
2017-08-03 14:47 ` [PATCH v3] " João Paulo Rechi Vita
2017-08-08 8:21 ` Coelho, Luciano
2017-08-08 8:21 ` Coelho, Luciano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500894086.20057.12.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=jprvita@endlessm.com \
--cc=jprvita@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=linuxwifi@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.