From: Joe Perches <joe@perches.com>
To: Geoff Levand <geoff@infradead.org>,
SF Markus Elfring <elfring@users.sourceforge.net>,
linuxppc-dev@lists.ozlabs.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_i
Date: Mon, 07 Aug 2017 15:13:40 +0000 [thread overview]
Message-ID: <1502118820.2219.19.camel@perches.com> (raw)
In-Reply-To: <b6b5f2f0-bbfe-8471-d8fc-e236ea0b1ea4@infradead.org>
On Mon, 2017-08-07 at 08:10 -0700, Geoff Levand wrote:
> On 08/07/2017 03:52 AM, SF Markus Elfring wrote:
> > Omit an extra message for a memory allocation failure in this function.
> NACK
>
> When a user asks me for help I would certainly like to get
> 'Could not allocate cache tags' as apposed to nothing, since
> the return value of ps3vram_cache_init() is not checked.
You still get a dump_stack on alloc failure.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Geoff Levand <geoff@infradead.org>,
SF Markus Elfring <elfring@users.sourceforge.net>,
linuxppc-dev@lists.ozlabs.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()
Date: Mon, 07 Aug 2017 08:13:40 -0700 [thread overview]
Message-ID: <1502118820.2219.19.camel@perches.com> (raw)
In-Reply-To: <b6b5f2f0-bbfe-8471-d8fc-e236ea0b1ea4@infradead.org>
On Mon, 2017-08-07 at 08:10 -0700, Geoff Levand wrote:
> On 08/07/2017 03:52 AM, SF Markus Elfring wrote:
> > Omit an extra message for a memory allocation failure in this function.
> NACK
>
> When a user asks me for help I would certainly like to get
> 'Could not allocate cache tags' as apposed to nothing, since
> the return value of ps3vram_cache_init() is not checked.
You still get a dump_stack on alloc failure.
next prev parent reply other threads:[~2017-08-07 15:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 10:52 [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init( SF Markus Elfring
2017-08-07 10:52 ` [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() SF Markus Elfring
2017-08-07 15:10 ` [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_i Geoff Levand
2017-08-07 15:10 ` [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() Geoff Levand
2017-08-07 15:13 ` Joe Perches [this message]
2017-08-07 15:13 ` Joe Perches
2017-08-07 16:27 ` SF Markus Elfring
2017-08-07 16:27 ` SF Markus Elfring
2017-08-07 18:28 ` Geoff Levand
2017-08-07 18:28 ` Geoff Levand
2017-08-07 18:34 ` SF Markus Elfring
2017-08-07 18:34 ` SF Markus Elfring
2017-08-07 18:49 ` Geoff Levand
2017-08-07 18:49 ` Geoff Levand
2017-08-07 19:04 ` SF Markus Elfring
2017-08-07 19:04 ` SF Markus Elfring
2017-08-07 20:17 ` Geoff Levand
2017-08-07 20:17 ` Geoff Levand
2017-08-08 8:23 ` SF Markus Elfring
2017-08-08 8:23 ` SF Markus Elfring
2017-08-08 2:13 ` Michael Ellerman
2017-08-08 2:13 ` Michael Ellerman
2017-08-08 2:13 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502118820.2219.19.camel@perches.com \
--to=joe@perches.com \
--cc=benh@kernel.crashing.org \
--cc=elfring@users.sourceforge.net \
--cc=geoff@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.