All of lore.kernel.org
 help / color / mirror / Atom feed
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 00/16] mmc: meson-gx: driver fixups and upgrades
Date: Tue, 22 Aug 2017 13:46:30 +0200	[thread overview]
Message-ID: <1503402390.7032.11.camel@baylibre.com> (raw)
In-Reply-To: <CAPDyKFoBebVf0wqJ+z5UHC+aMju2Qy0ONc1OVYrwzZKk+XgGTg@mail.gmail.com>

On Tue, 2017-08-22 at 13:15 +0200, Ulf Hansson wrote:
> On 21 August 2017 at 18:02, Jerome Brunet <jbrunet@baylibre.com> wrote:
> > The patchset features several bugfixes, rework and upgrade for the
> > meson-gx MMC driver.
> > 
> > The main goal is to improve readability and enable new high speed
> > modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz)
> > 
> > SDR104 is not working with a few cards on the p200 and the
> > libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB
> > of these boards, adding noise to the signal and eventually breaking
> > the communication with some cards. The same cards are working well on a
> > laptop or the nanopi-k2 at 200Mhz.
> > 
> > This series has been tested on gxbb-p200, gxbb-nanopi-k2 and
> > gxl-s905x-libretech-cc
> > 
> > Changes since v1 [0]:
> > * Reorder patches to have fixes first, then rework and finally
> > ? enhancements.
> > * Use CCF to manage clock phases
> > 
> > [0]: https://lkml.kernel.org/r/20170804174353.16486-1-jbrunet at baylibre.com
> > 
> > Jerome Brunet (16):
> > ? mmc: meson-gx: fix mux mask definition
> > ? mmc: meson-gx: remove CLK_DIVIDER_ALLOW_ZERO clock flag
> > ? mmc: meson-gx: clean up some constants
> > ? mmc: meson-gx: use _irqsave variant of spinlock
> > ? mmc: meson-gx: cfg init overwrite values
> > ? mmc: meson-gx: rework set_ios function
> > ? mmc: meson-gx: rework clk_set function
> > ? mmc: meson-gx: rework clock init function
> > ? mmc: meson-gx: fix dual data rate mode frequencies
> > ? mmc: meson-gx: work around clk-stop issue
> > ? mmc: meson-gx: simplify interrupt handler
> > ? mmc: meson-gx: implement card_busy callback
> > ? mmc: meson-gx: use CCF to handle the clock phases
> > ? mmc: meson-gx: implement voltage switch callback
> > ? mmc: meson-gx: change default tx phase
> > ? mmc: meson-gx: rework tuning function
> > 
> > ?drivers/mmc/host/meson-gx-mmc.c | 718 +++++++++++++++++++++++++++--------
> > -----
> > ?1 file changed, 497 insertions(+), 221 deletions(-)
> > 
> > --
> > 2.9.5
> > 
> 
> So far, I decided to pick patch 1 -> 3.

Thx Ulf.
Do you want me to respin w/o patch 1 -> 4 or shall I wait for further review on
the other changes ?

> 
> Kind regards
> Uffe

WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Kevin Hilman <khilman@baylibre.com>,
	Carlo Caione <carlo@caione.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 00/16] mmc: meson-gx: driver fixups and upgrades
Date: Tue, 22 Aug 2017 13:46:30 +0200	[thread overview]
Message-ID: <1503402390.7032.11.camel@baylibre.com> (raw)
In-Reply-To: <CAPDyKFoBebVf0wqJ+z5UHC+aMju2Qy0ONc1OVYrwzZKk+XgGTg@mail.gmail.com>

On Tue, 2017-08-22 at 13:15 +0200, Ulf Hansson wrote:
> On 21 August 2017 at 18:02, Jerome Brunet <jbrunet@baylibre.com> wrote:
> > The patchset features several bugfixes, rework and upgrade for the
> > meson-gx MMC driver.
> > 
> > The main goal is to improve readability and enable new high speed
> > modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz)
> > 
> > SDR104 is not working with a few cards on the p200 and the
> > libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB
> > of these boards, adding noise to the signal and eventually breaking
> > the communication with some cards. The same cards are working well on a
> > laptop or the nanopi-k2 at 200Mhz.
> > 
> > This series has been tested on gxbb-p200, gxbb-nanopi-k2 and
> > gxl-s905x-libretech-cc
> > 
> > Changes since v1 [0]:
> > * Reorder patches to have fixes first, then rework and finally
> >   enhancements.
> > * Use CCF to manage clock phases
> > 
> > [0]: https://lkml.kernel.org/r/20170804174353.16486-1-jbrunet@baylibre.com
> > 
> > Jerome Brunet (16):
> >   mmc: meson-gx: fix mux mask definition
> >   mmc: meson-gx: remove CLK_DIVIDER_ALLOW_ZERO clock flag
> >   mmc: meson-gx: clean up some constants
> >   mmc: meson-gx: use _irqsave variant of spinlock
> >   mmc: meson-gx: cfg init overwrite values
> >   mmc: meson-gx: rework set_ios function
> >   mmc: meson-gx: rework clk_set function
> >   mmc: meson-gx: rework clock init function
> >   mmc: meson-gx: fix dual data rate mode frequencies
> >   mmc: meson-gx: work around clk-stop issue
> >   mmc: meson-gx: simplify interrupt handler
> >   mmc: meson-gx: implement card_busy callback
> >   mmc: meson-gx: use CCF to handle the clock phases
> >   mmc: meson-gx: implement voltage switch callback
> >   mmc: meson-gx: change default tx phase
> >   mmc: meson-gx: rework tuning function
> > 
> >  drivers/mmc/host/meson-gx-mmc.c | 718 +++++++++++++++++++++++++++--------
> > -----
> >  1 file changed, 497 insertions(+), 221 deletions(-)
> > 
> > --
> > 2.9.5
> > 
> 
> So far, I decided to pick patch 1 -> 3.

Thx Ulf.
Do you want me to respin w/o patch 1 -> 4 or shall I wait for further review on
the other changes ?

> 
> Kind regards
> Uffe


WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/16] mmc: meson-gx: driver fixups and upgrades
Date: Tue, 22 Aug 2017 13:46:30 +0200	[thread overview]
Message-ID: <1503402390.7032.11.camel@baylibre.com> (raw)
In-Reply-To: <CAPDyKFoBebVf0wqJ+z5UHC+aMju2Qy0ONc1OVYrwzZKk+XgGTg@mail.gmail.com>

On Tue, 2017-08-22 at 13:15 +0200, Ulf Hansson wrote:
> On 21 August 2017 at 18:02, Jerome Brunet <jbrunet@baylibre.com> wrote:
> > The patchset features several bugfixes, rework and upgrade for the
> > meson-gx MMC driver.
> > 
> > The main goal is to improve readability and enable new high speed
> > modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz)
> > 
> > SDR104 is not working with a few cards on the p200 and the
> > libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB
> > of these boards, adding noise to the signal and eventually breaking
> > the communication with some cards. The same cards are working well on a
> > laptop or the nanopi-k2 at 200Mhz.
> > 
> > This series has been tested on gxbb-p200, gxbb-nanopi-k2 and
> > gxl-s905x-libretech-cc
> > 
> > Changes since v1 [0]:
> > * Reorder patches to have fixes first, then rework and finally
> > ? enhancements.
> > * Use CCF to manage clock phases
> > 
> > [0]: https://lkml.kernel.org/r/20170804174353.16486-1-jbrunet at baylibre.com
> > 
> > Jerome Brunet (16):
> > ? mmc: meson-gx: fix mux mask definition
> > ? mmc: meson-gx: remove CLK_DIVIDER_ALLOW_ZERO clock flag
> > ? mmc: meson-gx: clean up some constants
> > ? mmc: meson-gx: use _irqsave variant of spinlock
> > ? mmc: meson-gx: cfg init overwrite values
> > ? mmc: meson-gx: rework set_ios function
> > ? mmc: meson-gx: rework clk_set function
> > ? mmc: meson-gx: rework clock init function
> > ? mmc: meson-gx: fix dual data rate mode frequencies
> > ? mmc: meson-gx: work around clk-stop issue
> > ? mmc: meson-gx: simplify interrupt handler
> > ? mmc: meson-gx: implement card_busy callback
> > ? mmc: meson-gx: use CCF to handle the clock phases
> > ? mmc: meson-gx: implement voltage switch callback
> > ? mmc: meson-gx: change default tx phase
> > ? mmc: meson-gx: rework tuning function
> > 
> > ?drivers/mmc/host/meson-gx-mmc.c | 718 +++++++++++++++++++++++++++--------
> > -----
> > ?1 file changed, 497 insertions(+), 221 deletions(-)
> > 
> > --
> > 2.9.5
> > 
> 
> So far, I decided to pick patch 1 -> 3.

Thx Ulf.
Do you want me to respin w/o patch 1 -> 4 or shall I wait for further review on
the other changes ?

> 
> Kind regards
> Uffe

  reply	other threads:[~2017-08-22 11:46 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21 16:02 [PATCH v2 00/16] mmc: meson-gx: driver fixups and upgrades Jerome Brunet
2017-08-21 16:02 ` Jerome Brunet
2017-08-21 16:02 ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 01/16] mmc: meson-gx: fix mux mask definition Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 02/16] mmc: meson-gx: remove CLK_DIVIDER_ALLOW_ZERO clock flag Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 03/16] mmc: meson-gx: clean up some constants Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 04/16] mmc: meson-gx: use _irqsave variant of spinlock Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-22 11:08   ` Ulf Hansson
2017-08-22 11:08     ` Ulf Hansson
2017-08-22 11:08     ` Ulf Hansson
2017-08-22 11:41     ` Jerome Brunet
2017-08-22 11:41       ` Jerome Brunet
2017-08-22 11:41       ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 05/16] mmc: meson-gx: cfg init overwrite values Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 06/16] mmc: meson-gx: rework set_ios function Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 07/16] mmc: meson-gx: rework clk_set function Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 08/16] mmc: meson-gx: rework clock init function Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 09/16] mmc: meson-gx: fix dual data rate mode frequencies Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 10/16] mmc: meson-gx: work around clk-stop issue Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 11/16] mmc: meson-gx: simplify interrupt handler Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 12/16] mmc: meson-gx: implement card_busy callback Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 13/16] mmc: meson-gx: use CCF to handle the clock phases Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-25  0:04   ` Kevin Hilman
2017-08-25  0:04     ` Kevin Hilman
2017-08-25  0:04     ` Kevin Hilman
2017-08-21 16:02 ` [PATCH v2 14/16] mmc: meson-gx: implement voltage switch callback Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:03 ` [PATCH v2 15/16] mmc: meson-gx: change default tx phase Jerome Brunet
2017-08-21 16:03   ` Jerome Brunet
2017-08-21 16:03   ` Jerome Brunet
2017-08-25  0:05   ` Kevin Hilman
2017-08-25  0:05     ` Kevin Hilman
2017-08-25  0:05     ` Kevin Hilman
2017-08-21 16:03 ` [PATCH v2 16/16] mmc: meson-gx: rework tuning function Jerome Brunet
2017-08-21 16:03   ` Jerome Brunet
2017-08-21 16:03   ` Jerome Brunet
2017-08-22 11:15 ` [PATCH v2 00/16] mmc: meson-gx: driver fixups and upgrades Ulf Hansson
2017-08-22 11:15   ` Ulf Hansson
2017-08-22 11:15   ` Ulf Hansson
2017-08-22 11:46   ` Jerome Brunet [this message]
2017-08-22 11:46     ` Jerome Brunet
2017-08-22 11:46     ` Jerome Brunet
2017-08-23 13:10     ` Ulf Hansson
2017-08-23 13:10       ` Ulf Hansson
2017-08-23 13:10       ` Ulf Hansson
2017-08-25  0:05       ` Kevin Hilman
2017-08-25  0:05         ` Kevin Hilman
2017-08-25  0:05         ` Kevin Hilman
2017-08-25  0:05         ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1503402390.7032.11.camel@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.