All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 13/16] mmc: meson-gx: use CCF to handle the clock phases
Date: Thu, 24 Aug 2017 17:04:26 -0700	[thread overview]
Message-ID: <7hd17kh5rp.fsf@baylibre.com> (raw)
In-Reply-To: <20170821160301.21899-14-jbrunet@baylibre.com> (Jerome Brunet's message of "Mon, 21 Aug 2017 18:02:58 +0200")

Jerome Brunet <jbrunet@baylibre.com> writes:

> Several phases can be controlled on the meson-gx controller, the core, tx
> and rx clock phase. The tx and rx uses delays to allow for a more fine
> grained setting of the phase. To properly compute the phase using delays,
> accessing the clock rate is necessary.
>
> Instead of ad-hoc functions, use the common clock framework to set the
> clock phases (and access the clock rate while doing it).
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

I have to admit to not fully understanding the MMC tuning aspsects here,
but I like this approach to using the clock framework for handling the
extra clocks.

Acked-by: Kevin Hilman <khilman@baylibre.com>

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Carlo Caione <carlo@caione.org>,
	linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 13/16] mmc: meson-gx: use CCF to handle the clock phases
Date: Thu, 24 Aug 2017 17:04:26 -0700	[thread overview]
Message-ID: <7hd17kh5rp.fsf@baylibre.com> (raw)
In-Reply-To: <20170821160301.21899-14-jbrunet@baylibre.com> (Jerome Brunet's message of "Mon, 21 Aug 2017 18:02:58 +0200")

Jerome Brunet <jbrunet@baylibre.com> writes:

> Several phases can be controlled on the meson-gx controller, the core, tx
> and rx clock phase. The tx and rx uses delays to allow for a more fine
> grained setting of the phase. To properly compute the phase using delays,
> accessing the clock rate is necessary.
>
> Instead of ad-hoc functions, use the common clock framework to set the
> clock phases (and access the clock rate while doing it).
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

I have to admit to not fully understanding the MMC tuning aspsects here,
but I like this approach to using the clock framework for handling the
extra clocks.

Acked-by: Kevin Hilman <khilman@baylibre.com>

WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 13/16] mmc: meson-gx: use CCF to handle the clock phases
Date: Thu, 24 Aug 2017 17:04:26 -0700	[thread overview]
Message-ID: <7hd17kh5rp.fsf@baylibre.com> (raw)
In-Reply-To: <20170821160301.21899-14-jbrunet@baylibre.com> (Jerome Brunet's message of "Mon, 21 Aug 2017 18:02:58 +0200")

Jerome Brunet <jbrunet@baylibre.com> writes:

> Several phases can be controlled on the meson-gx controller, the core, tx
> and rx clock phase. The tx and rx uses delays to allow for a more fine
> grained setting of the phase. To properly compute the phase using delays,
> accessing the clock rate is necessary.
>
> Instead of ad-hoc functions, use the common clock framework to set the
> clock phases (and access the clock rate while doing it).
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

I have to admit to not fully understanding the MMC tuning aspsects here,
but I like this approach to using the clock framework for handling the
extra clocks.

Acked-by: Kevin Hilman <khilman@baylibre.com>

  reply	other threads:[~2017-08-25  0:04 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21 16:02 [PATCH v2 00/16] mmc: meson-gx: driver fixups and upgrades Jerome Brunet
2017-08-21 16:02 ` Jerome Brunet
2017-08-21 16:02 ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 01/16] mmc: meson-gx: fix mux mask definition Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 02/16] mmc: meson-gx: remove CLK_DIVIDER_ALLOW_ZERO clock flag Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 03/16] mmc: meson-gx: clean up some constants Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 04/16] mmc: meson-gx: use _irqsave variant of spinlock Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-22 11:08   ` Ulf Hansson
2017-08-22 11:08     ` Ulf Hansson
2017-08-22 11:08     ` Ulf Hansson
2017-08-22 11:41     ` Jerome Brunet
2017-08-22 11:41       ` Jerome Brunet
2017-08-22 11:41       ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 05/16] mmc: meson-gx: cfg init overwrite values Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 06/16] mmc: meson-gx: rework set_ios function Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 07/16] mmc: meson-gx: rework clk_set function Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 08/16] mmc: meson-gx: rework clock init function Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 09/16] mmc: meson-gx: fix dual data rate mode frequencies Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 10/16] mmc: meson-gx: work around clk-stop issue Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 11/16] mmc: meson-gx: simplify interrupt handler Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 12/16] mmc: meson-gx: implement card_busy callback Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 13/16] mmc: meson-gx: use CCF to handle the clock phases Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-25  0:04   ` Kevin Hilman [this message]
2017-08-25  0:04     ` Kevin Hilman
2017-08-25  0:04     ` Kevin Hilman
2017-08-21 16:02 ` [PATCH v2 14/16] mmc: meson-gx: implement voltage switch callback Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:03 ` [PATCH v2 15/16] mmc: meson-gx: change default tx phase Jerome Brunet
2017-08-21 16:03   ` Jerome Brunet
2017-08-21 16:03   ` Jerome Brunet
2017-08-25  0:05   ` Kevin Hilman
2017-08-25  0:05     ` Kevin Hilman
2017-08-25  0:05     ` Kevin Hilman
2017-08-21 16:03 ` [PATCH v2 16/16] mmc: meson-gx: rework tuning function Jerome Brunet
2017-08-21 16:03   ` Jerome Brunet
2017-08-21 16:03   ` Jerome Brunet
2017-08-22 11:15 ` [PATCH v2 00/16] mmc: meson-gx: driver fixups and upgrades Ulf Hansson
2017-08-22 11:15   ` Ulf Hansson
2017-08-22 11:15   ` Ulf Hansson
2017-08-22 11:46   ` Jerome Brunet
2017-08-22 11:46     ` Jerome Brunet
2017-08-22 11:46     ` Jerome Brunet
2017-08-23 13:10     ` Ulf Hansson
2017-08-23 13:10       ` Ulf Hansson
2017-08-23 13:10       ` Ulf Hansson
2017-08-25  0:05       ` Kevin Hilman
2017-08-25  0:05         ` Kevin Hilman
2017-08-25  0:05         ` Kevin Hilman
2017-08-25  0:05         ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hd17kh5rp.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.