[PATCH] boost: add python to default PACKAGECONFIG options

[PATCH] boost: add python to default PACKAGECONFIG options

[jackie.huang]

From: Jackie Huang <jackie.huang@windriver.com>

We want to provide python libs by default, and some other
popular Linux distributions like redhat/fedora does the same.

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta/recipes-support/boost/boost.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/boost/boost.inc b/meta/recipes-support/boost/boost.inc
index 4ff70e3..f4ecc10 100644
--- a/meta/recipes-support/boost/boost.inc
+++ b/meta/recipes-support/boost/boost.inc
@@ -38,7 +38,7 @@ BOOST_LIBS_remove_class-native = " context coroutine"
 BOOST_LIBS_remove_mips16e = "wave"
 
 # optional libraries
-PACKAGECONFIG ??= "locale"
+PACKAGECONFIG ??= "locale python"
 PACKAGECONFIG[locale] = ",,icu"
 PACKAGECONFIG[graph_parallel] = ",,,boost-mpi mpich"
 PACKAGECONFIG[mpi] = ",,mpich"
-- 
1.9.1

Re: [PATCH] boost: add python to default PACKAGECONFIG options

[Andre McCurdy]

On Tue, Aug 22, 2017 at 12:42 AM,  <jackie.huang@windriver.com> wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
>
> We want to provide python libs by default, and some other
> popular Linux distributions like redhat/fedora does the same.

Has something changed? Is there anything in oe-core or meta-oe which
now needs boost python support enabled?

> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>  meta/recipes-support/boost/boost.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/boost/boost.inc b/meta/recipes-support/boost/boost.inc
> index 4ff70e3..f4ecc10 100644
> --- a/meta/recipes-support/boost/boost.inc
> +++ b/meta/recipes-support/boost/boost.inc
> @@ -38,7 +38,7 @@ BOOST_LIBS_remove_class-native = " context coroutine"
>  BOOST_LIBS_remove_mips16e = "wave"
>
>  # optional libraries
> -PACKAGECONFIG ??= "locale"
> +PACKAGECONFIG ??= "locale python"
>  PACKAGECONFIG[locale] = ",,icu"
>  PACKAGECONFIG[graph_parallel] = ",,,boost-mpi mpich"
>  PACKAGECONFIG[mpi] = ",,mpich"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] boost: add python to default PACKAGECONFIG options

[Richard Purdie]

On Tue, 2017-08-22 at 12:51 -0700, Andre McCurdy wrote:
> On Tue, Aug 22, 2017 at 12:42 AM,  <jackie.huang@windriver.com>
> wrote:
> > 
> > From: Jackie Huang <jackie.huang@windriver.com>
> > 
> > We want to provide python libs by default, and some other
> > popular Linux distributions like redhat/fedora does the same.
> Has something changed? Is there anything in oe-core or meta-oe which
> now needs boost python support enabled?

Does it even actually build on all arches?

I'm rather behind with patch review right now as people are putting so
many patches out there with what seems like minimal testing and
expecting me/Ross and the autobuilder to figure out the problems for
them.

Each time one fails, it blocks the queue with the rest of them in and I
have to retest until I get something clean.

Testing this change is quite a way down my priority list I'm afraid.

Cheers,

Richard

Re: [PATCH] boost: add python to default PACKAGECONFIG options

[Randy MacLeod]

On 2017-08-22 03:55 PM, Richard Purdie wrote:
> On Tue, 2017-08-22 at 12:51 -0700, Andre McCurdy wrote:
>> On Tue, Aug 22, 2017 at 12:42 AM,  <jackie.huang@windriver.com>
>> wrote:
>>>
>>> From: Jackie Huang <jackie.huang@windriver.com>
>>>
>>> We want to provide python libs by default, and some other
>>> popular Linux distributions like redhat/fedora does the same.
>> Has something changed? Is there anything in oe-core or meta-oe which
>> now needs boost python support enabled?
> 
> Does it even actually build on all arches? >
> I'm rather behind with patch review right now as people are putting so
> many patches out there with what seems like minimal testing and
> expecting me/Ross and the autobuilder to figure out the problems for
> them.
> 
> Each time one fails, it blocks the queue with the rest of them in and I
> have to retest until I get something clean.
> 
> Testing this change is quite a way down my priority list I'm afraid.
> 

Maybe this is better done in our distro configuration.

We're trying to minimize differences with oe-core and
the boost python support doesn't seem to be much of an
impact based on looking at logs rather than a having a
detailed understanding of boost.

We've had this commit in our local branch since before:

CommitDate: Wed Dec 21 22:16:31 2016 -0800

     boost: add python to default PACKAGECONFIG options

     We want to provide python libs by default, and some other
     popular Linux distributions like redhat/fedora does the same.

     (LOCAL REV: NOT UPSTREAM) -- sent to oe-core on 20160930

so it certainly builds for all qemu* for glibc configurations.

I'll see if we can add musl builds to our automated builds tonight.

Jackie,

Did/Can you build for musl?
Do you have any idea of the impact of this config on users that are not
interested in the python interface with boost?
What's the additional cost in compile time?



There certainly are a rush of package updates and other changes
coming in; apologies for the lack of warning and late arrivals.
Other than doing more testing and explaining what tests were done,
what else can we do to help?


../Randy


> Cheers,
> 
> Richard
> 
> 


-- 
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, 
Canada, K2K 2W5

Re: [PATCH] boost: add python to default PACKAGECONFIG options

[Huang, Jie (Jackie)]

> -----Original Message-----
> From: MacLeod, Randy
> Sent: Wednesday, August 23, 2017 09:27
> To: Richard Purdie; Andre McCurdy; Huang, Jie (Jackie)
> Cc: OE Core mailing list
> Subject: Re: [OE-core] [PATCH] boost: add python to default PACKAGECONFIG
> options
> 
> On 2017-08-22 03:55 PM, Richard Purdie wrote:
> > On Tue, 2017-08-22 at 12:51 -0700, Andre McCurdy wrote:
> >> On Tue, Aug 22, 2017 at 12:42 AM,  <jackie.huang@windriver.com>
> >> wrote:
> >>>
> >>> From: Jackie Huang <jackie.huang@windriver.com>
> >>>
> >>> We want to provide python libs by default, and some other
> >>> popular Linux distributions like redhat/fedora does the same.
> >> Has something changed? Is there anything in oe-core or meta-oe which
> >> now needs boost python support enabled?
> >
> > Does it even actually build on all arches? >
> > I'm rather behind with patch review right now as people are putting so
> > many patches out there with what seems like minimal testing and
> > expecting me/Ross and the autobuilder to figure out the problems for
> > them.
> >
> > Each time one fails, it blocks the queue with the rest of them in and I
> > have to retest until I get something clean.
> >
> > Testing this change is quite a way down my priority list I'm afraid.
> >
> 
> Maybe this is better done in our distro configuration.
> 
> We're trying to minimize differences with oe-core and
> the boost python support doesn't seem to be much of an
> impact based on looking at logs rather than a having a
> detailed understanding of boost.
> 
> We've had this commit in our local branch since before:
> 
> CommitDate: Wed Dec 21 22:16:31 2016 -0800
> 
>      boost: add python to default PACKAGECONFIG options
> 
>      We want to provide python libs by default, and some other
>      popular Linux distributions like redhat/fedora does the same.
> 
>      (LOCAL REV: NOT UPSTREAM) -- sent to oe-core on 20160930
> 
> so it certainly builds for all qemu* for glibc configurations.
> 
> I'll see if we can add musl builds to our automated builds tonight.
> 
> Jackie,
> 
> Did/Can you build for musl?

No, I didn't build for musl yet, but yes, I can and will do the test with musl
and fix issues as needed.

> Do you have any idea of the impact of this config on users that are not
> interested in the python interface with boost?

I don't think there is any impact, each library is packaged into a separate
package named with boost-<lib name>

> What's the additional cost in compile time?

A quick test indicates that it's less than 1 second:

$ grep -r 'Elapsed time:' 20170823073306/boost-1.64.0-r0/do_compile 20170823075302/boost-1.64.0-r0/do_compile
20170823073306/boost-1.64.0-r0/do_compile:Elapsed time: 50.96 seconds
20170823075302/boost-1.64.0-r0/do_compile:Elapsed time: 51.63 seconds

Thanks,
Jackie

> 
> 
> 
> There certainly are a rush of package updates and other changes
> coming in; apologies for the lack of warning and late arrivals.
> Other than doing more testing and explaining what tests were done,
> what else can we do to help?
> 
> 
> ../Randy
> 
> 
> > Cheers,
> >
> > Richard
> >
> >
> 
> 
> --
> # Randy MacLeod. SMTS, Linux, Wind River
> Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON,
> Canada, K2K 2W5

Re: [PATCH] boost: add python to default PACKAGECONFIG options

[Huang, Jie (Jackie)]

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Huang, Jie (Jackie)
> Sent: Wednesday, August 23, 2017 16:02
> To: MacLeod, Randy; Richard Purdie; Andre McCurdy
> Cc: OE Core mailing list
> Subject: Re: [OE-core] [PATCH] boost: add python to default PACKAGECONFIG
> options
> 
> 
> 
> > -----Original Message-----
> > From: MacLeod, Randy
> > Sent: Wednesday, August 23, 2017 09:27
> > To: Richard Purdie; Andre McCurdy; Huang, Jie (Jackie)
> > Cc: OE Core mailing list
> > Subject: Re: [OE-core] [PATCH] boost: add python to default PACKAGECONFIG
> > options
> >
> > On 2017-08-22 03:55 PM, Richard Purdie wrote:
> > > On Tue, 2017-08-22 at 12:51 -0700, Andre McCurdy wrote:
> > >> On Tue, Aug 22, 2017 at 12:42 AM,  <jackie.huang@windriver.com>
> > >> wrote:
> > >>>
> > >>> From: Jackie Huang <jackie.huang@windriver.com>
> > >>>
> > >>> We want to provide python libs by default, and some other
> > >>> popular Linux distributions like redhat/fedora does the same.
> > >> Has something changed? Is there anything in oe-core or meta-oe which
> > >> now needs boost python support enabled?
> > >
> > > Does it even actually build on all arches? >
> > > I'm rather behind with patch review right now as people are putting so
> > > many patches out there with what seems like minimal testing and
> > > expecting me/Ross and the autobuilder to figure out the problems for
> > > them.
> > >
> > > Each time one fails, it blocks the queue with the rest of them in and I
> > > have to retest until I get something clean.
> > >
> > > Testing this change is quite a way down my priority list I'm afraid.
> > >
> >
> > Maybe this is better done in our distro configuration.
> >
> > We're trying to minimize differences with oe-core and
> > the boost python support doesn't seem to be much of an
> > impact based on looking at logs rather than a having a
> > detailed understanding of boost.
> >
> > We've had this commit in our local branch since before:
> >
> > CommitDate: Wed Dec 21 22:16:31 2016 -0800
> >
> >      boost: add python to default PACKAGECONFIG options
> >
> >      We want to provide python libs by default, and some other
> >      popular Linux distributions like redhat/fedora does the same.
> >
> >      (LOCAL REV: NOT UPSTREAM) -- sent to oe-core on 20160930
> >
> > so it certainly builds for all qemu* for glibc configurations.
> >
> > I'll see if we can add musl builds to our automated builds tonight.
> >
> > Jackie,
> >
> > Did/Can you build for musl?
> 
> No, I didn't build for musl yet, but yes, I can and will do the test with musl
> and fix issues as needed.

I tested for all qemu* with:
$ for i in qemuarm qemuarm64 qemux86 qemux86-64 qemuppc qemumips qemumips64; do MACHINE="$i" TCLIBC=musl bitbake boost

And all passed, could you point me out what the failure is caused by this patch? 

Thanks,
Jackie

> 
> > Do you have any idea of the impact of this config on users that are not
> > interested in the python interface with boost?
> 
> I don't think there is any impact, each library is packaged into a separate
> package named with boost-<lib name>
> 
> > What's the additional cost in compile time?
> 
> A quick test indicates that it's less than 1 second:
> 
> $ grep -r 'Elapsed time:' 20170823073306/boost-1.64.0-r0/do_compile
> 20170823075302/boost-1.64.0-r0/do_compile
> 20170823073306/boost-1.64.0-r0/do_compile:Elapsed time: 50.96 seconds
> 20170823075302/boost-1.64.0-r0/do_compile:Elapsed time: 51.63 seconds
> 
> Thanks,
> Jackie
> 
> >
> >
> >
> > There certainly are a rush of package updates and other changes
> > coming in; apologies for the lack of warning and late arrivals.
> > Other than doing more testing and explaining what tests were done,
> > what else can we do to help?
> >
> >
> > ../Randy
> >
> >
> > > Cheers,
> > >
> > > Richard
> > >
> > >
> >
> >
> > --
> > # Randy MacLeod. SMTS, Linux, Wind River
> > Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON,
> > Canada, K2K 2W5
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] boost: add python to default PACKAGECONFIG options

[Philip Balister]

On 08/22/2017 09:26 PM, Randy MacLeod wrote:
> On 2017-08-22 03:55 PM, Richard Purdie wrote:
>> On Tue, 2017-08-22 at 12:51 -0700, Andre McCurdy wrote:
>>> On Tue, Aug 22, 2017 at 12:42 AM,  <jackie.huang@windriver.com>
>>> wrote:
>>>>
>>>> From: Jackie Huang <jackie.huang@windriver.com>
>>>>
>>>> We want to provide python libs by default, and some other
>>>> popular Linux distributions like redhat/fedora does the same.
>>> Has something changed? Is there anything in oe-core or meta-oe which
>>> now needs boost python support enabled?

I'm aware of a package in meta-sdr that will need boost python support.
So there is need for this feature.

Philip

>>
>> Does it even actually build on all arches? >
>> I'm rather behind with patch review right now as people are putting so
>> many patches out there with what seems like minimal testing and
>> expecting me/Ross and the autobuilder to figure out the problems for
>> them.
>>
>> Each time one fails, it blocks the queue with the rest of them in and I
>> have to retest until I get something clean.
>>
>> Testing this change is quite a way down my priority list I'm afraid.
>>
> 
> Maybe this is better done in our distro configuration.
> 
> We're trying to minimize differences with oe-core and
> the boost python support doesn't seem to be much of an
> impact based on looking at logs rather than a having a
> detailed understanding of boost.
> 
> We've had this commit in our local branch since before:
> 
> CommitDate: Wed Dec 21 22:16:31 2016 -0800
> 
>     boost: add python to default PACKAGECONFIG options
> 
>     We want to provide python libs by default, and some other
>     popular Linux distributions like redhat/fedora does the same.
> 
>     (LOCAL REV: NOT UPSTREAM) -- sent to oe-core on 20160930
> 
> so it certainly builds for all qemu* for glibc configurations.
> 
> I'll see if we can add musl builds to our automated builds tonight.
> 
> Jackie,
> 
> Did/Can you build for musl?
> Do you have any idea of the impact of this config on users that are not
> interested in the python interface with boost?
> What's the additional cost in compile time?
> 
> 
> 
> There certainly are a rush of package updates and other changes
> coming in; apologies for the lack of warning and late arrivals.
> Other than doing more testing and explaining what tests were done,
> what else can we do to help?
> 
> 
> ../Randy
> 
> 
>> Cheers,
>>
>> Richard
>>
>>
> 
> 

Re: [PATCH] boost: add python to default PACKAGECONFIG options

[Andreas Müller]

On Wed, Aug 23, 2017 at 11:04 PM, Philip Balister <philip@balister.org> wrote:
> On 08/22/2017 09:26 PM, Randy MacLeod wrote:
>> On 2017-08-22 03:55 PM, Richard Purdie wrote:
>>> On Tue, 2017-08-22 at 12:51 -0700, Andre McCurdy wrote:
>>>> On Tue, Aug 22, 2017 at 12:42 AM,  <jackie.huang@windriver.com>
>>>> wrote:
>>>>>
>>>>> From: Jackie Huang <jackie.huang@windriver.com>
>>>>>
>>>>> We want to provide python libs by default, and some other
>>>>> popular Linux distributions like redhat/fedora does the same.
>>>> Has something changed? Is there anything in oe-core or meta-oe which
>>>> now needs boost python support enabled?
>
> I'm aware of a package in meta-sdr that will need boost python support.
> So there is need for this feature.
>
> Philip
>
FWIW: I have an append in metea-qt5-extra enabling python since two years.

Andreas

Re: [PATCH] boost: add python to default PACKAGECONFIG options

[Andreas Müller]

On Tue, Sep 5, 2017 at 10:44 AM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> On Wed, Aug 23, 2017 at 11:04 PM, Philip Balister <philip@balister.org> wrote:
>> On 08/22/2017 09:26 PM, Randy MacLeod wrote:
>>> On 2017-08-22 03:55 PM, Richard Purdie wrote:
>>>> On Tue, 2017-08-22 at 12:51 -0700, Andre McCurdy wrote:
>>>>> On Tue, Aug 22, 2017 at 12:42 AM,  <jackie.huang@windriver.com>
>>>>> wrote:
>>>>>>
>>>>>> From: Jackie Huang <jackie.huang@windriver.com>
>>>>>>
>>>>>> We want to provide python libs by default, and some other
>>>>>> popular Linux distributions like redhat/fedora does the same.
>>>>> Has something changed? Is there anything in oe-core or meta-oe which
>>>>> now needs boost python support enabled?
>>
>> I'm aware of a package in meta-sdr that will need boost python support.
>> So there is need for this feature.
>>
>> Philip
>>
> FWIW: I have an append in metea-qt5-extra enabling python since two years.
>
> Andreas

Re: [PATCH] boost: add python to default PACKAGECONFIG options

[Andreas Müller]

On Tue, Sep 5, 2017 at 11:02 AM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> On Tue, Sep 5, 2017 at 10:44 AM, Andreas Müller
> <schnitzeltony@googlemail.com> wrote:
>> On Wed, Aug 23, 2017 at 11:04 PM, Philip Balister <philip@balister.org> wrote:
>>> On 08/22/2017 09:26 PM, Randy MacLeod wrote:
>>>> On 2017-08-22 03:55 PM, Richard Purdie wrote:
>>>>> On Tue, 2017-08-22 at 12:51 -0700, Andre McCurdy wrote:
>>>>>> On Tue, Aug 22, 2017 at 12:42 AM,  <jackie.huang@windriver.com>
>>>>>> wrote:
>>>>>>>
>>>>>>> From: Jackie Huang <jackie.huang@windriver.com>
>>>>>>>
>>>>>>> We want to provide python libs by default, and some other
>>>>>>> popular Linux distributions like redhat/fedora does the same.
>>>>>> Has something changed? Is there anything in oe-core or meta-oe which
>>>>>> now needs boost python support enabled?
>>>
>>> I'm aware of a package in meta-sdr that will need boost python support.
>>> So there is need for this feature.
>>>
>>> Philip
>>>
>> FWIW: I have an append in metea-qt5-extra enabling python since two years.
>>
Saw that this was applied already. Sorry for the noise..

A.

[PATCH] boost: add python to default PACKAGECONFIG options

[jackie.huang]

From: Jackie Huang <jackie.huang@windriver.com>

We want to provide python libs by default, and some other
popular Linux distributions like redhat/fedora does the same.

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta/recipes-support/boost/boost.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/boost/boost.inc b/meta/recipes-support/boost/boost.inc
index 7637a4e..f854033 100644
--- a/meta/recipes-support/boost/boost.inc
+++ b/meta/recipes-support/boost/boost.inc
@@ -34,7 +34,7 @@ BOOST_LIBS_append_x86-64 = " context coroutine"
 BOOST_LIBS_append_powerpc = " context coroutine"
 
 # optional libraries
-PACKAGECONFIG ??= "locale"
+PACKAGECONFIG ??= "locale python"
 PACKAGECONFIG[locale] = ",,icu"
 PACKAGECONFIG[graph_parallel] = ",,,boost-mpi mpich"
 PACKAGECONFIG[mpi] = ",,mpich"
-- 
2.7.4