* Re: [PATCH] arm64: Convert pr_warning to standard pr_warn
@ 2017-09-05 9:10 ` Mark Rutland
0 siblings, 0 replies; 12+ messages in thread
From: Mark Rutland @ 2017-09-05 9:10 UTC (permalink / raw)
To: chengjian c00427203
Cc: linux-kernel, linux-arm-kernel, catalin.marinas, will.deacon,
huawei.libin, akpm, mingo
On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
> Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
>
> Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
> ---
> arch/arm64/kernel/smp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Is this a step towards removing pr_warning entirely?
If so, can you please fix up all occurences in arm64? i.e.
[mark@leverpostej:~/src/linux]% git grep pr_warning linux-next/master:arch/arm64
linux-next/master:arch/arm64:include/asm/syscall.h: pr_warning("%s called with max args %d, handling only %d\n",
linux-next/master:arch/arm64:include/asm/syscall.h: pr_warning("%s called with max args %d, handling only %d\n",
linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("unknown slot type: %d\n", type);
linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("attempt to read from unknown breakpoint register %d\n", n);
linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("attempt to write to unknown breakpoint register %d\n", n);
linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("invalid breakpoint privilege level %d\n", privilege);
linux-next/master:arch/arm64:kernel/smp.c: pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
linux-next/master:arch/arm64:kernel/smp.c: pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
Otherwise, I don't think it make sense to only fix some occurences.
Thanks,
Mark.
>
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index 9f7195a..efcaa05 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -972,7 +972,7 @@ void smp_send_stop(void)
> udelay(1);
>
> if (num_online_cpus() > 1)
> - pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
> + pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
> cpumask_pr_args(cpu_online_mask));
> }
>
> @@ -1009,7 +1009,7 @@ void crash_smp_send_stop(void)
> udelay(1);
>
> if (atomic_read(&waiting_for_crash_ipi) > 0)
> - pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
> + pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
> cpumask_pr_args(&mask));
> }
>
> --
> 1.8.3.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH] arm64: Convert pr_warning to standard pr_warn
2017-09-05 9:10 ` Mark Rutland
@ 2017-09-05 9:22 ` chengjian (D)
-1 siblings, 0 replies; 12+ messages in thread
From: chengjian (D) @ 2017-09-05 9:22 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mark,
OK, I will do it now
> On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
>> Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
>>
>> Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
>> ---
>> arch/arm64/kernel/smp.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
> Is this a step towards removing pr_warning entirely?
>
> If so, can you please fix up all occurences in arm64? i.e.
>
> [mark at leverpostej:~/src/linux]% git grep pr_warning linux-next/master:arch/arm64
> linux-next/master:arch/arm64:include/asm/syscall.h: pr_warning("%s called with max args %d, handling only %d\n",
> linux-next/master:arch/arm64:include/asm/syscall.h: pr_warning("%s called with max args %d, handling only %d\n",
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("unknown slot type: %d\n", type);
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("attempt to read from unknown breakpoint register %d\n", n);
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("attempt to write to unknown breakpoint register %d\n", n);
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("invalid breakpoint privilege level %d\n", privilege);
> linux-next/master:arch/arm64:kernel/smp.c: pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
> linux-next/master:arch/arm64:kernel/smp.c: pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
>
> Otherwise, I don't think it make sense to only fix some occurences.
>
> Thanks,
> Mark.
>
>> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
>> index 9f7195a..efcaa05 100644
>> --- a/arch/arm64/kernel/smp.c
>> +++ b/arch/arm64/kernel/smp.c
>> @@ -972,7 +972,7 @@ void smp_send_stop(void)
>> udelay(1);
>>
>> if (num_online_cpus() > 1)
>> - pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
>> + pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
>> cpumask_pr_args(cpu_online_mask));
>> }
>>
>> @@ -1009,7 +1009,7 @@ void crash_smp_send_stop(void)
>> udelay(1);
>>
>> if (atomic_read(&waiting_for_crash_ipi) > 0)
>> - pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
>> + pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
>> cpumask_pr_args(&mask));
>> }
>>
>> --
>> 1.8.3.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> .
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] arm64: Convert pr_warning to standard pr_warn
@ 2017-09-05 9:22 ` chengjian (D)
0 siblings, 0 replies; 12+ messages in thread
From: chengjian (D) @ 2017-09-05 9:22 UTC (permalink / raw)
To: Mark Rutland; +Cc: linux-kernel, linux-arm-kernel, huawei.libin
Hi Mark,
OK, I will do it now
> On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
>> Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
>>
>> Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
>> ---
>> arch/arm64/kernel/smp.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
> Is this a step towards removing pr_warning entirely?
>
> If so, can you please fix up all occurences in arm64? i.e.
>
> [mark@leverpostej:~/src/linux]% git grep pr_warning linux-next/master:arch/arm64
> linux-next/master:arch/arm64:include/asm/syscall.h: pr_warning("%s called with max args %d, handling only %d\n",
> linux-next/master:arch/arm64:include/asm/syscall.h: pr_warning("%s called with max args %d, handling only %d\n",
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("unknown slot type: %d\n", type);
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("attempt to read from unknown breakpoint register %d\n", n);
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("attempt to write to unknown breakpoint register %d\n", n);
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("invalid breakpoint privilege level %d\n", privilege);
> linux-next/master:arch/arm64:kernel/smp.c: pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
> linux-next/master:arch/arm64:kernel/smp.c: pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
>
> Otherwise, I don't think it make sense to only fix some occurences.
>
> Thanks,
> Mark.
>
>> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
>> index 9f7195a..efcaa05 100644
>> --- a/arch/arm64/kernel/smp.c
>> +++ b/arch/arm64/kernel/smp.c
>> @@ -972,7 +972,7 @@ void smp_send_stop(void)
>> udelay(1);
>>
>> if (num_online_cpus() > 1)
>> - pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
>> + pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
>> cpumask_pr_args(cpu_online_mask));
>> }
>>
>> @@ -1009,7 +1009,7 @@ void crash_smp_send_stop(void)
>> udelay(1);
>>
>> if (atomic_read(&waiting_for_crash_ipi) > 0)
>> - pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
>> + pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
>> cpumask_pr_args(&mask));
>> }
>>
>> --
>> 1.8.3.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> .
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] arm64: Convert pr_warning to standard pr_warn
2017-09-05 9:10 ` Mark Rutland
@ 2017-09-05 18:38 ` Joe Perches
-1 siblings, 0 replies; 12+ messages in thread
From: Joe Perches @ 2017-09-05 18:38 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2017-09-05 at 10:10 +0100, Mark Rutland wrote:
> On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
> > Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
> >
> > Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
> > ---
> > arch/arm64/kernel/smp.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Is this a step towards removing pr_warning entirely?
>
> If so, can you please fix up all occurences in arm64? i.e.
https://patchwork.kernel.org/patch/9578907/
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64: Convert pr_warning to standard pr_warn
@ 2017-09-05 18:38 ` Joe Perches
0 siblings, 0 replies; 12+ messages in thread
From: Joe Perches @ 2017-09-05 18:38 UTC (permalink / raw)
To: Mark Rutland, chengjian c00427203
Cc: linux-kernel, linux-arm-kernel, catalin.marinas, will.deacon,
huawei.libin, akpm, mingo
On Tue, 2017-09-05 at 10:10 +0100, Mark Rutland wrote:
> On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
> > Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
> >
> > Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
> > ---
> > arch/arm64/kernel/smp.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Is this a step towards removing pr_warning entirely?
>
> If so, can you please fix up all occurences in arm64? i.e.
https://patchwork.kernel.org/patch/9578907/
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] arm64: Convert pr_warning to standard pr_warn
2017-09-05 18:38 ` Joe Perches
@ 2017-09-06 9:21 ` Mark Rutland
-1 siblings, 0 replies; 12+ messages in thread
From: Mark Rutland @ 2017-09-06 9:21 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Sep 05, 2017 at 11:38:23AM -0700, Joe Perches wrote:
> On Tue, 2017-09-05 at 10:10 +0100, Mark Rutland wrote:
> > On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
> > > Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
> > >
> > > Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
> > > ---
> > > arch/arm64/kernel/smp.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Is this a step towards removing pr_warning entirely?
> >
> > If so, can you please fix up all occurences in arm64? i.e.
>
> https://patchwork.kernel.org/patch/9578907/
>
Ah, I thought I'd seen this before. :)
Catalin, Will, are you happy with Joe's patch?
Thanks,
Mark.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64: Convert pr_warning to standard pr_warn
@ 2017-09-06 9:21 ` Mark Rutland
0 siblings, 0 replies; 12+ messages in thread
From: Mark Rutland @ 2017-09-06 9:21 UTC (permalink / raw)
To: Joe Perches
Cc: chengjian c00427203, linux-kernel, linux-arm-kernel,
catalin.marinas, will.deacon, huawei.libin, akpm, mingo
On Tue, Sep 05, 2017 at 11:38:23AM -0700, Joe Perches wrote:
> On Tue, 2017-09-05 at 10:10 +0100, Mark Rutland wrote:
> > On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
> > > Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
> > >
> > > Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
> > > ---
> > > arch/arm64/kernel/smp.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Is this a step towards removing pr_warning entirely?
> >
> > If so, can you please fix up all occurences in arm64? i.e.
>
> https://patchwork.kernel.org/patch/9578907/
>
Ah, I thought I'd seen this before. :)
Catalin, Will, are you happy with Joe's patch?
Thanks,
Mark.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] arm64: Convert pr_warning to standard pr_warn
2017-09-06 9:21 ` Mark Rutland
@ 2017-09-06 14:19 ` Catalin Marinas
-1 siblings, 0 replies; 12+ messages in thread
From: Catalin Marinas @ 2017-09-06 14:19 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 06, 2017 at 10:21:26AM +0100, Mark Rutland wrote:
> On Tue, Sep 05, 2017 at 11:38:23AM -0700, Joe Perches wrote:
> > On Tue, 2017-09-05 at 10:10 +0100, Mark Rutland wrote:
> > > On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
> > > > Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
> > > >
> > > > Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
> > > > ---
> > > > arch/arm64/kernel/smp.c | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > Is this a step towards removing pr_warning entirely?
> > >
> > > If so, can you please fix up all occurences in arm64? i.e.
> >
> > https://patchwork.kernel.org/patch/9578907/
>
> Ah, I thought I'd seen this before. :)
>
> Catalin, Will, are you happy with Joe's patch?
Yes, though I thought they'd go in via other tree (e.g.
kernel-janitors).
--
Catalin
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64: Convert pr_warning to standard pr_warn
@ 2017-09-06 14:19 ` Catalin Marinas
0 siblings, 0 replies; 12+ messages in thread
From: Catalin Marinas @ 2017-09-06 14:19 UTC (permalink / raw)
To: Mark Rutland
Cc: Joe Perches, chengjian c00427203, will.deacon, linux-kernel,
huawei.libin, akpm, mingo, linux-arm-kernel
On Wed, Sep 06, 2017 at 10:21:26AM +0100, Mark Rutland wrote:
> On Tue, Sep 05, 2017 at 11:38:23AM -0700, Joe Perches wrote:
> > On Tue, 2017-09-05 at 10:10 +0100, Mark Rutland wrote:
> > > On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
> > > > Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
> > > >
> > > > Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
> > > > ---
> > > > arch/arm64/kernel/smp.c | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > Is this a step towards removing pr_warning entirely?
> > >
> > > If so, can you please fix up all occurences in arm64? i.e.
> >
> > https://patchwork.kernel.org/patch/9578907/
>
> Ah, I thought I'd seen this before. :)
>
> Catalin, Will, are you happy with Joe's patch?
Yes, though I thought they'd go in via other tree (e.g.
kernel-janitors).
--
Catalin
^ permalink raw reply [flat|nested] 12+ messages in thread