All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP
Date: Fri, 8 Sep 2017 17:14:52 +0000	[thread overview]
Message-ID: <1504890890.30546.15.camel@synopsys.com> (raw)
In-Reply-To: <948bc9d9-7cef-4574-2ec9-0e9b0e5e0772@synopsys.com>

On Wed, 2017-09-06@12:54 -0700, Vineet Gupta wrote:
> On 09/06/2017 11:21 AM, Eugeniy Paltsev wrote:
> > DW ethernet controller on AXS10x hangs sometimes after SW reset, so
> > add temporary quirk to reset DW ethernet controller IP core.
> > This quirk can be removed after axs10x reset driver
> > (see http://patchwork.ozlabs.org/patch/800273/)
> > or simple reset driver
> > (see https://patchwork.kernel.org/patch/9903375/)
> > will be available in upstream.
> > 
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
> 
> Added to for-next !
> 
> Thx,

Hi Vineet,

Please specify if you have plans to add this patch to 4.14?

I'm asking because we mostly need this quirk in 4.14 - I hope generic simple
reset driver will be available in 4.15.

Thanks.

> 
> > ---
> > ? arch/arc/plat-axs10x/axs10x.c | 7 +++++++
> > ? 1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
> > index f1ac679..cf14ebc 100644
> > --- a/arch/arc/plat-axs10x/axs10x.c
> > +++ b/arch/arc/plat-axs10x/axs10x.c
> > @@ -111,6 +111,13 @@ static void __init axs10x_early_init(void)
> > ??
> > ??	axs10x_enable_gpio_intc_wire();
> > ??
> > +	/*
> > +	?* Reset ethernet IP core.
> > +	?* TODO: get rid of this quirk after axs10x reset driver (or simple
> > +	?* reset driver) will be available in upstream.
> > +	?*/
> > +	iowrite32((1 << 5), (void __iomem *) CREG_MB_SW_RESET);
> > +
> > ??	scnprintf(mb, 32, "MainBoard v%d", mb_rev);
> > ??	axs10x_print_board_ver(CREG_MB_VER, mb);
> > ? }
> > 
> 
> 
-- 
?Eugeniy Paltsev

WARNING: multiple messages have this Message-ID (diff)
From: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
To: "Eugeniy.Paltsev@synopsys.com" <Eugeniy.Paltsev@synopsys.com>,
	"Vineet Gupta" <Vineet.Gupta1@synopsys.com>,
	"linux-snps-arc@lists.infradead.org" 
	<linux-snps-arc@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Alexey.Brodkin@synopsys.com" <Alexey.Brodkin@synopsys.com>
Subject: Re: [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP
Date: Fri, 8 Sep 2017 17:14:52 +0000	[thread overview]
Message-ID: <1504890890.30546.15.camel@synopsys.com> (raw)
In-Reply-To: <948bc9d9-7cef-4574-2ec9-0e9b0e5e0772@synopsys.com>

On Wed, 2017-09-06 at 12:54 -0700, Vineet Gupta wrote:
> On 09/06/2017 11:21 AM, Eugeniy Paltsev wrote:
> > DW ethernet controller on AXS10x hangs sometimes after SW reset, so
> > add temporary quirk to reset DW ethernet controller IP core.
> > This quirk can be removed after axs10x reset driver
> > (see http://patchwork.ozlabs.org/patch/800273/)
> > or simple reset driver
> > (see https://patchwork.kernel.org/patch/9903375/)
> > will be available in upstream.
> > 
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> 
> Added to for-next !
> 
> Thx,

Hi Vineet,

Please specify if you have plans to add this patch to 4.14?

I'm asking because we mostly need this quirk in 4.14 - I hope generic simple
reset driver will be available in 4.15.

Thanks.

> 
> > ---
> >   arch/arc/plat-axs10x/axs10x.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
> > index f1ac679..cf14ebc 100644
> > --- a/arch/arc/plat-axs10x/axs10x.c
> > +++ b/arch/arc/plat-axs10x/axs10x.c
> > @@ -111,6 +111,13 @@ static void __init axs10x_early_init(void)
> >   
> >   	axs10x_enable_gpio_intc_wire();
> >   
> > +	/*
> > +	 * Reset ethernet IP core.
> > +	 * TODO: get rid of this quirk after axs10x reset driver (or simple
> > +	 * reset driver) will be available in upstream.
> > +	 */
> > +	iowrite32((1 << 5), (void __iomem *) CREG_MB_SW_RESET);
> > +
> >   	scnprintf(mb, 32, "MainBoard v%d", mb_rev);
> >   	axs10x_print_board_ver(CREG_MB_VER, mb);
> >   }
> > 
> 
> 
-- 
 Eugeniy Paltsev

  reply	other threads:[~2017-09-08 17:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-06 18:21 [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP Eugeniy Paltsev
2017-09-06 18:21 ` Eugeniy Paltsev
2017-09-06 19:54 ` Vineet Gupta
2017-09-06 19:54   ` Vineet Gupta
2017-09-08 17:14   ` Eugeniy Paltsev [this message]
2017-09-08 17:14     ` Eugeniy Paltsev
2017-09-08 17:31     ` Vineet Gupta
2017-09-08 17:31       ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504890890.30546.15.camel@synopsys.com \
    --to=eugeniy.paltsev@synopsys.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.