All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP
@ 2017-09-06 18:21 ` Eugeniy Paltsev
  0 siblings, 0 replies; 8+ messages in thread
From: Eugeniy Paltsev @ 2017-09-06 18:21 UTC (permalink / raw)
  To: linux-snps-arc

DW ethernet controller on AXS10x hangs sometimes after SW reset, so
add temporary quirk to reset DW ethernet controller IP core.
This quirk can be removed after axs10x reset driver
(see http://patchwork.ozlabs.org/patch/800273/)
or simple reset driver
(see https://patchwork.kernel.org/patch/9903375/)
will be available in upstream.

Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
---
 arch/arc/plat-axs10x/axs10x.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
index f1ac679..cf14ebc 100644
--- a/arch/arc/plat-axs10x/axs10x.c
+++ b/arch/arc/plat-axs10x/axs10x.c
@@ -111,6 +111,13 @@ static void __init axs10x_early_init(void)
 
 	axs10x_enable_gpio_intc_wire();
 
+	/*
+	 * Reset ethernet IP core.
+	 * TODO: get rid of this quirk after axs10x reset driver (or simple
+	 * reset driver) will be available in upstream.
+	 */
+	iowrite32((1 << 5), (void __iomem *) CREG_MB_SW_RESET);
+
 	scnprintf(mb, 32, "MainBoard v%d", mb_rev);
 	axs10x_print_board_ver(CREG_MB_VER, mb);
 }
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP
@ 2017-09-06 18:21 ` Eugeniy Paltsev
  0 siblings, 0 replies; 8+ messages in thread
From: Eugeniy Paltsev @ 2017-09-06 18:21 UTC (permalink / raw)
  To: linux-snps-arc
  Cc: linux-kernel, Vineet Gupta, Alexey Brodkin, Eugeniy Paltsev

DW ethernet controller on AXS10x hangs sometimes after SW reset, so
add temporary quirk to reset DW ethernet controller IP core.
This quirk can be removed after axs10x reset driver
(see http://patchwork.ozlabs.org/patch/800273/)
or simple reset driver
(see https://patchwork.kernel.org/patch/9903375/)
will be available in upstream.

Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
---
 arch/arc/plat-axs10x/axs10x.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
index f1ac679..cf14ebc 100644
--- a/arch/arc/plat-axs10x/axs10x.c
+++ b/arch/arc/plat-axs10x/axs10x.c
@@ -111,6 +111,13 @@ static void __init axs10x_early_init(void)
 
 	axs10x_enable_gpio_intc_wire();
 
+	/*
+	 * Reset ethernet IP core.
+	 * TODO: get rid of this quirk after axs10x reset driver (or simple
+	 * reset driver) will be available in upstream.
+	 */
+	iowrite32((1 << 5), (void __iomem *) CREG_MB_SW_RESET);
+
 	scnprintf(mb, 32, "MainBoard v%d", mb_rev);
 	axs10x_print_board_ver(CREG_MB_VER, mb);
 }
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP
  2017-09-06 18:21 ` Eugeniy Paltsev
@ 2017-09-06 19:54   ` Vineet Gupta
  -1 siblings, 0 replies; 8+ messages in thread
From: Vineet Gupta @ 2017-09-06 19:54 UTC (permalink / raw)
  To: linux-snps-arc

On 09/06/2017 11:21 AM, Eugeniy Paltsev wrote:
> DW ethernet controller on AXS10x hangs sometimes after SW reset, so
> add temporary quirk to reset DW ethernet controller IP core.
> This quirk can be removed after axs10x reset driver
> (see http://patchwork.ozlabs.org/patch/800273/)
> or simple reset driver
> (see https://patchwork.kernel.org/patch/9903375/)
> will be available in upstream.
> 
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>

Added to for-next !

Thx,

> ---
>   arch/arc/plat-axs10x/axs10x.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
> index f1ac679..cf14ebc 100644
> --- a/arch/arc/plat-axs10x/axs10x.c
> +++ b/arch/arc/plat-axs10x/axs10x.c
> @@ -111,6 +111,13 @@ static void __init axs10x_early_init(void)
>   
>   	axs10x_enable_gpio_intc_wire();
>   
> +	/*
> +	 * Reset ethernet IP core.
> +	 * TODO: get rid of this quirk after axs10x reset driver (or simple
> +	 * reset driver) will be available in upstream.
> +	 */
> +	iowrite32((1 << 5), (void __iomem *) CREG_MB_SW_RESET);
> +
>   	scnprintf(mb, 32, "MainBoard v%d", mb_rev);
>   	axs10x_print_board_ver(CREG_MB_VER, mb);
>   }
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP
@ 2017-09-06 19:54   ` Vineet Gupta
  0 siblings, 0 replies; 8+ messages in thread
From: Vineet Gupta @ 2017-09-06 19:54 UTC (permalink / raw)
  To: Eugeniy Paltsev, linux-snps-arc; +Cc: Alexey Brodkin, linux-kernel

On 09/06/2017 11:21 AM, Eugeniy Paltsev wrote:
> DW ethernet controller on AXS10x hangs sometimes after SW reset, so
> add temporary quirk to reset DW ethernet controller IP core.
> This quirk can be removed after axs10x reset driver
> (see http://patchwork.ozlabs.org/patch/800273/)
> or simple reset driver
> (see https://patchwork.kernel.org/patch/9903375/)
> will be available in upstream.
> 
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>

Added to for-next !

Thx,

> ---
>   arch/arc/plat-axs10x/axs10x.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
> index f1ac679..cf14ebc 100644
> --- a/arch/arc/plat-axs10x/axs10x.c
> +++ b/arch/arc/plat-axs10x/axs10x.c
> @@ -111,6 +111,13 @@ static void __init axs10x_early_init(void)
>   
>   	axs10x_enable_gpio_intc_wire();
>   
> +	/*
> +	 * Reset ethernet IP core.
> +	 * TODO: get rid of this quirk after axs10x reset driver (or simple
> +	 * reset driver) will be available in upstream.
> +	 */
> +	iowrite32((1 << 5), (void __iomem *) CREG_MB_SW_RESET);
> +
>   	scnprintf(mb, 32, "MainBoard v%d", mb_rev);
>   	axs10x_print_board_ver(CREG_MB_VER, mb);
>   }
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP
  2017-09-06 19:54   ` Vineet Gupta
@ 2017-09-08 17:14     ` Eugeniy Paltsev
  -1 siblings, 0 replies; 8+ messages in thread
From: Eugeniy Paltsev @ 2017-09-08 17:14 UTC (permalink / raw)
  To: linux-snps-arc

On Wed, 2017-09-06@12:54 -0700, Vineet Gupta wrote:
> On 09/06/2017 11:21 AM, Eugeniy Paltsev wrote:
> > DW ethernet controller on AXS10x hangs sometimes after SW reset, so
> > add temporary quirk to reset DW ethernet controller IP core.
> > This quirk can be removed after axs10x reset driver
> > (see http://patchwork.ozlabs.org/patch/800273/)
> > or simple reset driver
> > (see https://patchwork.kernel.org/patch/9903375/)
> > will be available in upstream.
> > 
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
> 
> Added to for-next !
> 
> Thx,

Hi Vineet,

Please specify if you have plans to add this patch to 4.14?

I'm asking because we mostly need this quirk in 4.14 - I hope generic simple
reset driver will be available in 4.15.

Thanks.

> 
> > ---
> > ? arch/arc/plat-axs10x/axs10x.c | 7 +++++++
> > ? 1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
> > index f1ac679..cf14ebc 100644
> > --- a/arch/arc/plat-axs10x/axs10x.c
> > +++ b/arch/arc/plat-axs10x/axs10x.c
> > @@ -111,6 +111,13 @@ static void __init axs10x_early_init(void)
> > ??
> > ??	axs10x_enable_gpio_intc_wire();
> > ??
> > +	/*
> > +	?* Reset ethernet IP core.
> > +	?* TODO: get rid of this quirk after axs10x reset driver (or simple
> > +	?* reset driver) will be available in upstream.
> > +	?*/
> > +	iowrite32((1 << 5), (void __iomem *) CREG_MB_SW_RESET);
> > +
> > ??	scnprintf(mb, 32, "MainBoard v%d", mb_rev);
> > ??	axs10x_print_board_ver(CREG_MB_VER, mb);
> > ? }
> > 
> 
> 
-- 
?Eugeniy Paltsev

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP
@ 2017-09-08 17:14     ` Eugeniy Paltsev
  0 siblings, 0 replies; 8+ messages in thread
From: Eugeniy Paltsev @ 2017-09-08 17:14 UTC (permalink / raw)
  To: Eugeniy.Paltsev@synopsys.com, Vineet Gupta,
	linux-snps-arc@lists.infradead.org
  Cc: linux-kernel@vger.kernel.org, Alexey.Brodkin@synopsys.com

On Wed, 2017-09-06 at 12:54 -0700, Vineet Gupta wrote:
> On 09/06/2017 11:21 AM, Eugeniy Paltsev wrote:
> > DW ethernet controller on AXS10x hangs sometimes after SW reset, so
> > add temporary quirk to reset DW ethernet controller IP core.
> > This quirk can be removed after axs10x reset driver
> > (see http://patchwork.ozlabs.org/patch/800273/)
> > or simple reset driver
> > (see https://patchwork.kernel.org/patch/9903375/)
> > will be available in upstream.
> > 
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> 
> Added to for-next !
> 
> Thx,

Hi Vineet,

Please specify if you have plans to add this patch to 4.14?

I'm asking because we mostly need this quirk in 4.14 - I hope generic simple
reset driver will be available in 4.15.

Thanks.

> 
> > ---
> >   arch/arc/plat-axs10x/axs10x.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
> > index f1ac679..cf14ebc 100644
> > --- a/arch/arc/plat-axs10x/axs10x.c
> > +++ b/arch/arc/plat-axs10x/axs10x.c
> > @@ -111,6 +111,13 @@ static void __init axs10x_early_init(void)
> >   
> >   	axs10x_enable_gpio_intc_wire();
> >   
> > +	/*
> > +	 * Reset ethernet IP core.
> > +	 * TODO: get rid of this quirk after axs10x reset driver (or simple
> > +	 * reset driver) will be available in upstream.
> > +	 */
> > +	iowrite32((1 << 5), (void __iomem *) CREG_MB_SW_RESET);
> > +
> >   	scnprintf(mb, 32, "MainBoard v%d", mb_rev);
> >   	axs10x_print_board_ver(CREG_MB_VER, mb);
> >   }
> > 
> 
> 
-- 
 Eugeniy Paltsev

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP
  2017-09-08 17:14     ` Eugeniy Paltsev
@ 2017-09-08 17:31       ` Vineet Gupta
  -1 siblings, 0 replies; 8+ messages in thread
From: Vineet Gupta @ 2017-09-08 17:31 UTC (permalink / raw)
  To: linux-snps-arc

On 09/08/2017 10:14 AM, Eugeniy Paltsev wrote:
> On Wed, 2017-09-06@12:54 -0700, Vineet Gupta wrote:
>> On 09/06/2017 11:21 AM, Eugeniy Paltsev wrote:
>>> DW ethernet controller on AXS10x hangs sometimes after SW reset, so
>>> add temporary quirk to reset DW ethernet controller IP core.
>>> This quirk can be removed after axs10x reset driver
>>> (see http://patchwork.ozlabs.org/patch/800273/)
>>> or simple reset driver
>>> (see https://patchwork.kernel.org/patch/9903375/)
>>> will be available in upstream.
>>>
>>> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
>> Added to for-next !
>>
>> Thx,
> Hi Vineet,
>
> Please specify if you have plans to add this patch to 4.14?
>
> I'm asking because we mostly need this quirk in 4.14 - I hope generic simple
> reset driver will be available in 4.15.

New code can't be added during the merge window ! I've applied it locally and it 
will happen after rc1 is out !

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP
@ 2017-09-08 17:31       ` Vineet Gupta
  0 siblings, 0 replies; 8+ messages in thread
From: Vineet Gupta @ 2017-09-08 17:31 UTC (permalink / raw)
  To: Eugeniy Paltsev, Eugeniy.Paltsev@synopsys.com,
	linux-snps-arc@lists.infradead.org
  Cc: linux-kernel@vger.kernel.org, Alexey.Brodkin@synopsys.com

On 09/08/2017 10:14 AM, Eugeniy Paltsev wrote:
> On Wed, 2017-09-06 at 12:54 -0700, Vineet Gupta wrote:
>> On 09/06/2017 11:21 AM, Eugeniy Paltsev wrote:
>>> DW ethernet controller on AXS10x hangs sometimes after SW reset, so
>>> add temporary quirk to reset DW ethernet controller IP core.
>>> This quirk can be removed after axs10x reset driver
>>> (see http://patchwork.ozlabs.org/patch/800273/)
>>> or simple reset driver
>>> (see https://patchwork.kernel.org/patch/9903375/)
>>> will be available in upstream.
>>>
>>> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
>> Added to for-next !
>>
>> Thx,
> Hi Vineet,
>
> Please specify if you have plans to add this patch to 4.14?
>
> I'm asking because we mostly need this quirk in 4.14 - I hope generic simple
> reset driver will be available in 4.15.

New code can't be added during the merge window ! I've applied it locally and it 
will happen after rc1 is out !

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-09-08 17:31 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-06 18:21 [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP Eugeniy Paltsev
2017-09-06 18:21 ` Eugeniy Paltsev
2017-09-06 19:54 ` Vineet Gupta
2017-09-06 19:54   ` Vineet Gupta
2017-09-08 17:14   ` Eugeniy Paltsev
2017-09-08 17:14     ` Eugeniy Paltsev
2017-09-08 17:31     ` Vineet Gupta
2017-09-08 17:31       ` Vineet Gupta

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.