From: onlywig@gmail.com (Wig C)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: dts: Add initial Pistachio i.mx6q board support.
Date: Sat, 9 Sep 2017 20:45:10 +0800 [thread overview]
Message-ID: <1504961110-9878-1-git-send-email-onlywig@gmail.com> (raw)
In-Reply-To: <1504949308-13552-1-git-send-email-onlywig@gmail.com>
On Sat, Sep 9, 2017 at 6:28 AM, Wig C <onlywig@gmail.com> wrote:
> +&usdhc2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usdhc2>;
> + bus-width = <4>;
> + vmmc-supply = <&wlan_en_reg>;
> + no-1-8-v;
> + keep-power-in-suspend;
> + non-removable;
> + cap-power-off-card;
As I mentioned previously the indentation is not correct here.
You should use tab instead of spaces.
checkpatch also complains about it:
WARNING: please, no spaces at the start of a line
#699: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:654:
+ non-removable;$
WARNING: please, no spaces at the start of a line
#700: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:655:
+ cap-power-off-card;$
Hello Fabio:
I will fix this on next patch, sorry I miss it.
> +&wdog1 {
> + status = "okay";
> +};
Why don't you use like this as you intended in the original patch?
&wdog1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_wdog>;
fsl,ext-reset-output;
status = "okay";
};
My original patch has never support hardware watch dog as following link:
https://www.spinics.net/lists/kernel/msg2594724.html
I used soft reset on Pistachio, sorry for cause your misunderstand, and
thanks for your kindly correction.
Wig
WARNING: multiple messages have this Message-ID (diff)
From: Wig C <onlywig-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: fabio.estevam-3arQi8VN3Tc@public.gmane.org
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v3] ARM: dts: Add initial Pistachio i.mx6q board support.
Date: Sat, 9 Sep 2017 20:45:10 +0800 [thread overview]
Message-ID: <1504961110-9878-1-git-send-email-onlywig@gmail.com> (raw)
In-Reply-To: <1504949308-13552-1-git-send-email-onlywig-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Sat, Sep 9, 2017 at 6:28 AM, Wig C <onlywig-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> +&usdhc2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usdhc2>;
> + bus-width = <4>;
> + vmmc-supply = <&wlan_en_reg>;
> + no-1-8-v;
> + keep-power-in-suspend;
> + non-removable;
> + cap-power-off-card;
As I mentioned previously the indentation is not correct here.
You should use tab instead of spaces.
checkpatch also complains about it:
WARNING: please, no spaces at the start of a line
#699: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:654:
+ non-removable;$
WARNING: please, no spaces at the start of a line
#700: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:655:
+ cap-power-off-card;$
Hello Fabio:
I will fix this on next patch, sorry I miss it.
> +&wdog1 {
> + status = "okay";
> +};
Why don't you use like this as you intended in the original patch?
&wdog1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_wdog>;
fsl,ext-reset-output;
status = "okay";
};
My original patch has never support hardware watch dog as following link:
https://www.spinics.net/lists/kernel/msg2594724.html
I used soft reset on Pistachio, sorry for cause your misunderstand, and
thanks for your kindly correction.
Wig
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Wig C <onlywig@gmail.com>
To: fabio.estevam@nxp.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
shawnguo@kernel.org, kernel@pengutronix.de,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3] ARM: dts: Add initial Pistachio i.mx6q board support.
Date: Sat, 9 Sep 2017 20:45:10 +0800 [thread overview]
Message-ID: <1504961110-9878-1-git-send-email-onlywig@gmail.com> (raw)
In-Reply-To: <1504949308-13552-1-git-send-email-onlywig@gmail.com>
On Sat, Sep 9, 2017 at 6:28 AM, Wig C <onlywig@gmail.com> wrote:
> +&usdhc2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usdhc2>;
> + bus-width = <4>;
> + vmmc-supply = <&wlan_en_reg>;
> + no-1-8-v;
> + keep-power-in-suspend;
> + non-removable;
> + cap-power-off-card;
As I mentioned previously the indentation is not correct here.
You should use tab instead of spaces.
checkpatch also complains about it:
WARNING: please, no spaces at the start of a line
#699: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:654:
+ non-removable;$
WARNING: please, no spaces at the start of a line
#700: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:655:
+ cap-power-off-card;$
Hello Fabio:
I will fix this on next patch, sorry I miss it.
> +&wdog1 {
> + status = "okay";
> +};
Why don't you use like this as you intended in the original patch?
&wdog1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_wdog>;
fsl,ext-reset-output;
status = "okay";
};
My original patch has never support hardware watch dog as following link:
https://www.spinics.net/lists/kernel/msg2594724.html
I used soft reset on Pistachio, sorry for cause your misunderstand, and
thanks for your kindly correction.
Wig
next prev parent reply other threads:[~2017-09-09 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 9:28 [PATCH v3] ARM: dts: Add initial Pistachio i.mx6q board support Wig C
2017-09-09 9:28 ` Wig C
2017-09-09 11:48 ` Fabio Estevam
2017-09-09 11:48 ` Fabio Estevam
2017-09-09 12:45 ` Wig C [this message]
2017-09-09 12:45 ` Wig C
2017-09-09 12:45 ` Wig C
2017-09-09 12:48 ` Fabio Estevam
2017-09-09 12:48 ` Fabio Estevam
2017-09-09 12:48 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504961110-9878-1-git-send-email-onlywig@gmail.com \
--to=onlywig@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.