From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
Colin Ian King <colin.king@canonical.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text
Date: Fri, 22 Sep 2017 10:46:21 +0000 [thread overview]
Message-ID: <1506077181.12311.39.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1709221206050.3170@hadrien>
On Fri, 2017-09-22 at 12:06 +0200, Julia Lawall wrote:
>
> On Fri, 22 Sep 2017, Colin Ian King wrote:
>
> > On 22/09/17 11:03, Joe Perches wrote:
> > > On Fri, 2017-09-22 at 09:23 +0200, Julia Lawall wrote:
> > > >
> > > > On Thu, 21 Sep 2017, Colin King wrote:
> > > >
> > > > > From: Colin Ian King <colin.king@canonical.com>
> > > > >
> > > > > Don't populate const array ac_to_fifo on the stack in an inlined
> > > > > function, instead make it static. Makes the object code smaller
> > > > > by over 800 bytes:
> > > > >
> > > > > text data bss dec hex filename
> > > > > 159029 33154 1216 193399 2f377 4965-mac.o
> > > > >
> > > > > text data bss dec hex filename
> > > > > 158122 33250 1216 192588 2f04c 4965-mac.o
> > > > >
> > > > > (gcc version 7.2.0 x86_64)
> > > >
> > > > Gcc 7 must be much more aggressive about inlining than gcc 4. Here is the
> > > > change that I got on this file:
> > > >
> > > > text data bss dec hex filename
> > > > - 76346 1494 152 77992 130a8 drivers/net/wireless/intel/iwlegacy/4965-mac.o
> > > > + 76298 1494 152 77944 13078 drivers/net/wireless/intel/iwlegacy/4965-mac.o
> > > > decrease of 48
> > >
> > > More likely different CONFIG options.
> > >
> > > e.g. allyesconfig vs defconfig with wireless
> > >
> >
> > yup, I used allyesconfig
>
> Mine is also allyesconfig.
Odd.
Here is what I get: (Sorry, no gcc-7)
gcc4: gcc-4.9 (Ubuntu 4.9.4-2ubuntu1) 4.9.4
gcc5: gcc-5 (Ubuntu 5.4.1-8ubuntu1) 5.4.1 20170304
gcc6: gcc-6 (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406
$ size drivers/net/wireless/intel/iwlegacy/4965-mac.o*
text data bss dec hex filename
118559 1766 152 120477 1d69d drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc4.allyesconfig.new
118623 1766 152 120541 1d6dd drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc4.allyesconfig.old
51595 1156 0 52751 ce0f drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc4.defconfig.new
51659 1156 0 52815 ce4f drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc4.defconfig.old
141956 29790 1216 172962 2a3a2 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc5.allyesconfig.new
142671 29702 1216 173589 2a615 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc5.allyesconfig.old
51733 1156 0 52889 ce99 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc5.defconfig.new
51813 1156 0 52969 cee9 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc5.defconfig.old
152991 29790 1216 183997 2cebd drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc6.allyesconfig.new
153722 29702 1216 184640 2d140 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc6.allyesconfig.old
51813 1156 0 52969 cee9 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc6.defconfig.new
51893 1156 0 53049 cf39 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc6.defconfig.old
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
Colin Ian King <colin.king@canonical.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit
Date: Fri, 22 Sep 2017 03:46:21 -0700 [thread overview]
Message-ID: <1506077181.12311.39.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1709221206050.3170@hadrien>
On Fri, 2017-09-22 at 12:06 +0200, Julia Lawall wrote:
>
> On Fri, 22 Sep 2017, Colin Ian King wrote:
>
> > On 22/09/17 11:03, Joe Perches wrote:
> > > On Fri, 2017-09-22 at 09:23 +0200, Julia Lawall wrote:
> > > >
> > > > On Thu, 21 Sep 2017, Colin King wrote:
> > > >
> > > > > From: Colin Ian King <colin.king@canonical.com>
> > > > >
> > > > > Don't populate const array ac_to_fifo on the stack in an inlined
> > > > > function, instead make it static. Makes the object code smaller
> > > > > by over 800 bytes:
> > > > >
> > > > > text data bss dec hex filename
> > > > > 159029 33154 1216 193399 2f377 4965-mac.o
> > > > >
> > > > > text data bss dec hex filename
> > > > > 158122 33250 1216 192588 2f04c 4965-mac.o
> > > > >
> > > > > (gcc version 7.2.0 x86_64)
> > > >
> > > > Gcc 7 must be much more aggressive about inlining than gcc 4. Here is the
> > > > change that I got on this file:
> > > >
> > > > text data bss dec hex filename
> > > > - 76346 1494 152 77992 130a8 drivers/net/wireless/intel/iwlegacy/4965-mac.o
> > > > + 76298 1494 152 77944 13078 drivers/net/wireless/intel/iwlegacy/4965-mac.o
> > > > decrease of 48
> > >
> > > More likely different CONFIG options.
> > >
> > > e.g. allyesconfig vs defconfig with wireless
> > >
> >
> > yup, I used allyesconfig
>
> Mine is also allyesconfig.
Odd.
Here is what I get: (Sorry, no gcc-7)
gcc4: gcc-4.9 (Ubuntu 4.9.4-2ubuntu1) 4.9.4
gcc5: gcc-5 (Ubuntu 5.4.1-8ubuntu1) 5.4.1 20170304
gcc6: gcc-6 (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406
$ size drivers/net/wireless/intel/iwlegacy/4965-mac.o*
text data bss dec hex filename
118559 1766 152 120477 1d69d drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc4.allyesconfig.new
118623 1766 152 120541 1d6dd drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc4.allyesconfig.old
51595 1156 0 52751 ce0f drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc4.defconfig.new
51659 1156 0 52815 ce4f drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc4.defconfig.old
141956 29790 1216 172962 2a3a2 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc5.allyesconfig.new
142671 29702 1216 173589 2a615 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc5.allyesconfig.old
51733 1156 0 52889 ce99 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc5.defconfig.new
51813 1156 0 52969 cee9 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc5.defconfig.old
152991 29790 1216 183997 2cebd drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc6.allyesconfig.new
153722 29702 1216 184640 2d140 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc6.allyesconfig.old
51813 1156 0 52969 cee9 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc6.defconfig.new
51893 1156 0 53049 cf39 drivers/net/wireless/intel/iwlegacy/4965-mac.o.gcc6.defconfig.old
next prev parent reply other threads:[~2017-09-22 10:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 22:56 [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/pl Colin King
2017-09-21 22:56 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Colin King
2017-09-22 6:00 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: tex Johannes Berg
2017-09-22 6:00 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Johannes Berg
2017-09-22 7:23 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text Julia Lawall
2017-09-22 7:23 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Julia Lawall
2017-09-22 10:03 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text Joe Perches
2017-09-22 10:03 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Joe Perches
2017-09-22 10:05 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text Colin Ian King
2017-09-22 10:05 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Colin Ian King
2017-09-22 10:06 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text Julia Lawall
2017-09-22 10:06 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Julia Lawall
2017-09-22 10:46 ` Joe Perches [this message]
2017-09-22 10:46 ` Joe Perches
2017-09-22 10:54 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text Julia Lawall
2017-09-22 10:54 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Julia Lawall
2017-09-22 9:56 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: tex Stanislaw Gruszka
2017-09-22 9:56 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Stanislaw Gruszka
2017-09-22 10:32 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: tex Kalle Valo
2017-09-22 10:32 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Kalle Valo
2017-09-25 8:29 ` iwlegacy: make const array static to shink object code size Kalle Valo
2017-09-25 8:29 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506077181.12311.39.camel@perches.com \
--to=joe@perches.com \
--cc=colin.king@canonical.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.