From: Kalle Valo <kvalo@codeaurora.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: iwlegacy: make const array static to shink object code size
Date: Mon, 25 Sep 2017 08:29:49 +0000 [thread overview]
Message-ID: <20170925082949.EF68E60719@smtp.codeaurora.org> (raw)
In-Reply-To: <20170921225630.21916-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const array ac_to_fifo on the stack in an inlined
> function, instead make it static. Makes the object code smaller
> by over 800 bytes:
>
> text data bss dec hex filename
> 159029 33154 1216 193399 2f377 4965-mac.o
>
> text data bss dec hex filename
> 158122 33250 1216 192588 2f04c 4965-mac.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
Patch applied to wireless-drivers-next.git, thanks.
9b029e178ea1 iwlegacy: make const array static to shink object code size
--
https://patchwork.kernel.org/patch/9964889/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: iwlegacy: make const array static to shink object code size
Date: Mon, 25 Sep 2017 08:29:49 +0000 (UTC) [thread overview]
Message-ID: <20170925082949.EF68E60719@smtp.codeaurora.org> (raw)
In-Reply-To: <20170921225630.21916-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const array ac_to_fifo on the stack in an inlined
> function, instead make it static. Makes the object code smaller
> by over 800 bytes:
>
> text data bss dec hex filename
> 159029 33154 1216 193399 2f377 4965-mac.o
>
> text data bss dec hex filename
> 158122 33250 1216 192588 2f04c 4965-mac.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
Patch applied to wireless-drivers-next.git, thanks.
9b029e178ea1 iwlegacy: make const array static to shink object code size
--
https://patchwork.kernel.org/patch/9964889/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-09-25 8:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 22:56 [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/pl Colin King
2017-09-21 22:56 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Colin King
2017-09-22 6:00 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: tex Johannes Berg
2017-09-22 6:00 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Johannes Berg
2017-09-22 7:23 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text Julia Lawall
2017-09-22 7:23 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Julia Lawall
2017-09-22 10:03 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text Joe Perches
2017-09-22 10:03 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Joe Perches
2017-09-22 10:05 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text Colin Ian King
2017-09-22 10:05 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Colin Ian King
2017-09-22 10:06 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text Julia Lawall
2017-09-22 10:06 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Julia Lawall
2017-09-22 10:46 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text Joe Perches
2017-09-22 10:46 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Joe Perches
2017-09-22 10:54 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text Julia Lawall
2017-09-22 10:54 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Julia Lawall
2017-09-22 9:56 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: tex Stanislaw Gruszka
2017-09-22 9:56 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Stanislaw Gruszka
2017-09-22 10:32 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: tex Kalle Valo
2017-09-22 10:32 ` [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Kalle Valo
2017-09-25 8:29 ` Kalle Valo [this message]
2017-09-25 8:29 ` iwlegacy: make const array static to shink object code size Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925082949.EF68E60719@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.