All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hannes Reinecke <hare@suse.de>,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups
Date: Wed, 04 Oct 2017 12:33:12 +0200	[thread overview]
Message-ID: <1507113192.22324.1.camel@suse.com> (raw)
In-Reply-To: <20171001080003.GD11554@lst.de>

On Sun, 2017-10-01 at 10:00 +0200, Christoph Hellwig wrote:
> While this looks okay-ish to me I really don't want people confused
> with three variants of add_disk, we really need to consolidate
> our helpers there a bit..
> 

Can you give me a hint what you'd like to see?

Martin

-- 
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

WARNING: multiple messages have this Message-ID (diff)
From: mwilck@suse.com (Martin Wilck)
Subject: [PATCH 1/2] block: genhd: add device_add_disk_with_groups
Date: Wed, 04 Oct 2017 12:33:12 +0200	[thread overview]
Message-ID: <1507113192.22324.1.camel@suse.com> (raw)
In-Reply-To: <20171001080003.GD11554@lst.de>

On Sun, 2017-10-01@10:00 +0200, Christoph Hellwig wrote:
> While this looks okay-ish to me I really don't want people confused
> with three variants of add_disk, we really need to consolidate
> our helpers there a bit..
> 

Can you give me a hint what you'd like to see?

Martin

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)

  reply	other threads:[~2017-10-04 10:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28 19:36 [PATCH 1/2] block: genhd: add device_add_disk_with_groups Martin Wilck
2017-09-28 19:36 ` Martin Wilck
2017-09-28 19:36 ` [PATCH 2/2] nvme: use device_add_disk_with_groups() Martin Wilck
2017-09-28 19:36   ` Martin Wilck
2017-09-29 19:27   ` Schremmer, Steven
2017-09-29 19:27     ` Schremmer, Steven
2017-09-29 19:27     ` Schremmer, Steven
2017-09-29 23:00   ` Keith Busch
2017-09-29 23:00     ` Keith Busch
2017-09-29 19:27 ` [PATCH 1/2] block: genhd: add device_add_disk_with_groups Schremmer, Steven
2017-09-29 19:27   ` Schremmer, Steven
2017-09-29 19:27   ` Schremmer, Steven
2017-09-29 22:59 ` Keith Busch
2017-09-29 22:59   ` Keith Busch
2017-10-04 10:46   ` Martin Wilck
2017-10-04 10:46     ` Martin Wilck
2017-10-01  8:00 ` Christoph Hellwig
2017-10-01  8:00   ` Christoph Hellwig
2017-10-04 10:33   ` Martin Wilck [this message]
2017-10-04 10:33     ` Martin Wilck
2017-10-02 22:46 ` Sagi Grimberg
2017-10-02 22:46   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507113192.22324.1.camel@suse.com \
    --to=mwilck@suse.com \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jthumshirn@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.