From: Keith Busch <keith.busch@intel.com>
To: Martin Wilck <mwilck@suse.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, Martin Wilck <mwilck@suse.de>
Subject: Re: [PATCH 2/2] nvme: use device_add_disk_with_groups()
Date: Fri, 29 Sep 2017 17:00:07 -0600 [thread overview]
Message-ID: <20170929230006.GQ8463@localhost.localdomain> (raw)
In-Reply-To: <20170928193637.24707-2-mwilck@suse.com>
On Thu, Sep 28, 2017 at 09:36:37PM +0200, Martin Wilck wrote:
> By using device_add_disk_with_groups(), we can avoid the race
> condition with udev rule processing, because no udev event will
> be triggered before all attributes are available.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
Looks good.
Reviewed-by: Keith Busch <keith.busch@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 2/2] nvme: use device_add_disk_with_groups()
Date: Fri, 29 Sep 2017 17:00:07 -0600 [thread overview]
Message-ID: <20170929230006.GQ8463@localhost.localdomain> (raw)
In-Reply-To: <20170928193637.24707-2-mwilck@suse.com>
On Thu, Sep 28, 2017@09:36:37PM +0200, Martin Wilck wrote:
> By using device_add_disk_with_groups(), we can avoid the race
> condition with udev rule processing, because no udev event will
> be triggered before all attributes are available.
>
> Signed-off-by: Martin Wilck <mwilck at suse.com>
Looks good.
Reviewed-by: Keith Busch <keith.busch at intel.com>
next prev parent reply other threads:[~2017-09-29 23:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 19:36 [PATCH 1/2] block: genhd: add device_add_disk_with_groups Martin Wilck
2017-09-28 19:36 ` Martin Wilck
2017-09-28 19:36 ` [PATCH 2/2] nvme: use device_add_disk_with_groups() Martin Wilck
2017-09-28 19:36 ` Martin Wilck
2017-09-29 19:27 ` Schremmer, Steven
2017-09-29 19:27 ` Schremmer, Steven
2017-09-29 19:27 ` Schremmer, Steven
2017-09-29 23:00 ` Keith Busch [this message]
2017-09-29 23:00 ` Keith Busch
2017-09-29 19:27 ` [PATCH 1/2] block: genhd: add device_add_disk_with_groups Schremmer, Steven
2017-09-29 19:27 ` Schremmer, Steven
2017-09-29 19:27 ` Schremmer, Steven
2017-09-29 22:59 ` Keith Busch
2017-09-29 22:59 ` Keith Busch
2017-10-04 10:46 ` Martin Wilck
2017-10-04 10:46 ` Martin Wilck
2017-10-01 8:00 ` Christoph Hellwig
2017-10-01 8:00 ` Christoph Hellwig
2017-10-04 10:33 ` Martin Wilck
2017-10-04 10:33 ` Martin Wilck
2017-10-02 22:46 ` Sagi Grimberg
2017-10-02 22:46 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929230006.GQ8463@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mwilck@suse.com \
--cc=mwilck@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.