From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Timur Tabi <timur@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
thierry.reding@gmail.com, Stephen Boyd <sboyd@codeaurora.org>,
david.brown@linaro.org, andy.gross@linaro.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 1/4] Revert "gpio: set up initial state from .get_direction()"
Date: Tue, 31 Oct 2017 11:08:46 +0200 [thread overview]
Message-ID: <1509440926.10233.77.camel@linux.intel.com> (raw)
In-Reply-To: <1509396602-1936-2-git-send-email-timur@codeaurora.org>
On Mon, 2017-10-30 at 15:49 -0500, Timur Tabi wrote:
> This reverts commit 72d3200061776264941be1b5a9bb8e926b3b30a5.
>
> We cannot blindly query the direction of all GPIOs when the pins are
> first registered. The get_direction callback normally triggers a
> read/write to hardware, but we shouldn't be touching the hardware for
> an individual GPIO until after it's been properly requested.
>
> + /* REVISIT: most hardware initializes GPIOs as inputs
> (often
> + * with pullups enabled) so power usage is minimized.
> Linux
> + * code should set the gpio direction first thing;
> but until
> + * it does, and in case chip->get_direction is not
> set, we may
> + * expose the wrong direction in sysfs.
> + */
Can you preserve the style and indentation of the commit?
Does checkpatch warn you about style? (It's apparently not a net
subsystem)
> + desc->flags = !chip->direction_input ? (1 <<
> FLAG_IS_OUT) : 0;
> }
>
> #ifdef CONFIG_PINCTRL
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] Revert "gpio: set up initial state from .get_direction()"
Date: Tue, 31 Oct 2017 11:08:46 +0200 [thread overview]
Message-ID: <1509440926.10233.77.camel@linux.intel.com> (raw)
In-Reply-To: <1509396602-1936-2-git-send-email-timur@codeaurora.org>
On Mon, 2017-10-30 at 15:49 -0500, Timur Tabi wrote:
> This reverts commit 72d3200061776264941be1b5a9bb8e926b3b30a5.
>
> We cannot blindly query the direction of all GPIOs when the pins are
> first registered. The get_direction callback normally triggers a
> read/write to hardware, but we shouldn't be touching the hardware for
> an individual GPIO until after it's been properly requested.
>
> + /* REVISIT: most hardware initializes GPIOs as inputs
> (often
> + * with pullups enabled) so power usage is minimized.
> Linux
> + * code should set the gpio direction first thing;
> but until
> + * it does, and in case chip->get_direction is not
> set, we may
> + * expose the wrong direction in sysfs.
> + */
Can you preserve the style and indentation of the commit?
Does checkpatch warn you about style? (It's apparently not a net
subsystem)
> + desc->flags = !chip->direction_input ? (1 <<
> FLAG_IS_OUT) : 0;
> }
>
> #ifdef CONFIG_PINCTRL
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-10-31 9:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 20:49 [PATCH 0/4] [v6] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-10-30 20:49 ` Timur Tabi
2017-10-30 20:49 ` [PATCH 1/4] Revert "gpio: set up initial state from .get_direction()" Timur Tabi
2017-10-30 20:49 ` Timur Tabi
2017-10-31 9:08 ` Andy Shevchenko [this message]
2017-10-31 9:08 ` Andy Shevchenko
2017-10-31 12:28 ` Timur Tabi
2017-10-31 12:28 ` Timur Tabi
2017-10-31 12:33 ` Fabio Estevam
2017-10-31 12:33 ` Fabio Estevam
2017-10-31 12:36 ` Timur Tabi
2017-10-31 12:36 ` Timur Tabi
2017-10-31 12:34 ` Andy Shevchenko
2017-10-31 12:34 ` Andy Shevchenko
2017-10-30 20:50 ` [PATCH 2/4] gpiolib: add bitmask for valid GPIO lines Timur Tabi
2017-10-30 20:50 ` Timur Tabi
2017-10-31 9:12 ` Andy Shevchenko
2017-10-31 9:12 ` Andy Shevchenko
2017-10-31 18:54 ` Timur Tabi
2017-10-31 18:54 ` Timur Tabi
2017-10-31 19:05 ` Andy Shevchenko
2017-10-31 19:05 ` Andy Shevchenko
2017-10-30 20:50 ` [PATCH 3/4] [v6] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
2017-10-30 20:50 ` Timur Tabi
2017-10-30 20:50 ` [PATCH 4/4] [v3] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002 Timur Tabi
2017-10-30 20:50 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509440926.10233.77.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sboyd@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.