All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
To: "broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
	<kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	"fabio.estevam-3arQi8VN3Tc@public.gmane.org"
	<fabio.estevam-3arQi8VN3Tc@public.gmane.org>
Subject: Re: [PATCH v2 1/4] spi: imx: GPIO based chip selects should not be required
Date: Tue, 31 Oct 2017 16:57:42 +0000	[thread overview]
Message-ID: <1509469061.5473.16.camel@impinj.com> (raw)
In-Reply-To: <20171031111919.gocl7wwrhkwnxrya-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>

On Tue, 2017-10-31 at 11:19 +0000, Mark Brown wrote:
> On Thu, Oct 26, 2017 at 06:08:38PM -0700, Trent Piepho wrote:
> > The driver will fail to load if no gpio chip selects are specified,
> > this patch changes this so that it no longer fails.
> > 
> > It's possible to use all native chip selects, in which case there is
> > no reason to have a gpio chip select array.  This is what happens if
> > the *optional* device tree property "cs-gpios" is omitted.
> 
> Do the native chip selects actually work usefully on this hardware?
> There used to be problems with it wanting to do things like bounce the
> chip select on every word which made it extremely difficult to use with
> Linux.

Still are annoying, but on the device we have connected to it, it ends
up working as desired.

I've not thoroughly investigated this hardware to find the details. 
IIRC, the designware SPI on Altera SoCFPGA had the same issue, but it
was a flaw in the driver and I was able to fix it.  I've come to expect
it, as every new SPI master I use doesn't work properly in some
different way.

WARNING: multiple messages have this Message-ID (diff)
From: tpiepho@impinj.com (Trent Piepho)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] spi: imx: GPIO based chip selects should not be required
Date: Tue, 31 Oct 2017 16:57:42 +0000	[thread overview]
Message-ID: <1509469061.5473.16.camel@impinj.com> (raw)
In-Reply-To: <20171031111919.gocl7wwrhkwnxrya@sirena.co.uk>

On Tue, 2017-10-31 at 11:19 +0000, Mark Brown wrote:
> On Thu, Oct 26, 2017 at 06:08:38PM -0700, Trent Piepho wrote:
> > The driver will fail to load if no gpio chip selects are specified,
> > this patch changes this so that it no longer fails.
> > 
> > It's possible to use all native chip selects, in which case there is
> > no reason to have a gpio chip select array.  This is what happens if
> > the *optional* device tree property "cs-gpios" is omitted.
> 
> Do the native chip selects actually work usefully on this hardware?
> There used to be problems with it wanting to do things like bounce the
> chip select on every word which made it extremely difficult to use with
> Linux.

Still are annoying, but on the device we have connected to it, it ends
up working as desired.

I've not thoroughly investigated this hardware to find the details. 
IIRC, the designware SPI on Altera SoCFPGA had the same issue, but it
was a flaw in the driver and I was able to fix it.  I've come to expect
it, as every new SPI master I use doesn't work properly in some
different way.

  parent reply	other threads:[~2017-10-31 16:57 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27  1:08 [PATCH v2 0/4] Fix for imx-spi CS GPIOs Trent Piepho
2017-10-27  1:08 ` Trent Piepho
     [not found] ` <20171027010841.28624-1-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-27  1:08   ` [PATCH v2 1/4] spi: imx: GPIO based chip selects should not be required Trent Piepho
2017-10-27  1:08     ` Trent Piepho
     [not found]     ` <20171027010841.28624-2-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-31 11:19       ` Mark Brown
2017-10-31 11:19         ` Mark Brown
     [not found]         ` <20171031111919.gocl7wwrhkwnxrya-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-10-31 16:57           ` Trent Piepho [this message]
2017-10-31 16:57             ` Trent Piepho
     [not found]             ` <1509469061.5473.16.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-02 15:14               ` Mark Brown
2017-11-02 15:14                 ` Mark Brown
     [not found]                 ` <20171102151439.6dpfud7a5vtc27dy-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-11-03 17:53                   ` Trent Piepho
2017-11-03 17:53                     ` Trent Piepho
     [not found]                     ` <1509731639.5473.60.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-03 18:37                       ` Mark Brown
2017-11-03 18:37                         ` Mark Brown
     [not found]                         ` <20171103183700.spnqbagr4q7fth4k-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-11-03 19:18                           ` Trent Piepho
2017-11-03 19:18                             ` Trent Piepho
     [not found]                             ` <1509736735.5473.87.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-03 19:36                               ` Mark Brown
2017-11-03 19:36                                 ` Mark Brown
     [not found]                                 ` <20171103193649.jcoiy3raefikko2h-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-11-03 20:09                                   ` Trent Piepho
2017-11-03 20:09                                     ` Trent Piepho
     [not found]                                     ` <1509739759.5473.93.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-03 20:11                                       ` Mark Brown
2017-11-03 20:11                                         ` Mark Brown
2017-11-06  7:32                               ` Sascha Hauer
2017-11-06  7:32                                 ` Sascha Hauer
     [not found]                                 ` <20171106073246.efcz7r2vnymz3me7-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-11-06 19:20                                   ` Trent Piepho
2017-11-06 19:20                                     ` Trent Piepho
2017-10-27  1:08   ` [PATCH v2 2/4] spi: imx: Fix failure path leak on GPIO request error Trent Piepho
2017-10-27  1:08     ` Trent Piepho
2017-10-27  1:08   ` [PATCH v2 3/4] spi: imx: Don't require platform data chipselect array Trent Piepho
2017-10-27  1:08     ` Trent Piepho
     [not found]     ` <20171027010841.28624-4-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-27 11:14       ` Oleksij Rempel
2017-10-27 11:14         ` Oleksij Rempel
2017-10-27  1:08   ` [PATCH v2 4/4] ARM: imx: Update spi_imx platform data to reflect current state Trent Piepho
2017-10-27  1:08     ` Trent Piepho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509469061.5473.16.camel@impinj.com \
    --to=tpiepho-cgc2codaahdqt0dzr+alfa@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.