From: Trond Myklebust <trondmy@primarydata.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jlayton@kernel.org" <jlayton@kernel.org>,
"bfields@fieldses.org" <bfields@fieldses.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"dvyukov@google.com" <dvyukov@google.com>,
"anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "syzkaller@googlegroups.com" <syzkaller@googlegroups.com>
Subject: Re: sunrpc: infinite unkillable console spam in xs_tcp_setup_socket
Date: Fri, 24 Nov 2017 17:34:04 +0000 [thread overview]
Message-ID: <1511544841.14300.4.camel@primarydata.com> (raw)
In-Reply-To: <CACT4Y+bXN5vHCcwEk9NYbPe=RXmweMK09g=nW5D5ww+PTegL5w@mail.gmail.com>
T24gTW9uLCAyMDE3LTExLTIwIGF0IDE0OjAyICswMTAwLCBEbWl0cnkgVnl1a292IHdyb3RlOg0K
PiBIZWxsbywNCj4gDQo+IFRoZSBmb2xsb3dpbmcgcHJvZ3JhbSB0cmlnZ2VycyBpbmZpbml0ZSBz
dHJlYW0gb2YgdGhlIGZvbGxvd2luZw0KPiBvdXRwdXQNCj4gb24gY29uc29sZS4gVGhlIHByb2dy
YW0gaXMgdW5raWxsYWJsZSBhbmQgdGhpcyBlZmZlY3RpdmVseSBicmluZ3MgdGhlDQo+IG1hY2hp
bmUgZG93bjoNCj4gDQo+IA0KPiAqKiAxNiBwcmludGsgbWVzc2FnZXMgZHJvcHBlZCAqKiBbMTI4
NzUuMDIyOTE3XSB4c190Y3Bfc2V0dXBfc29ja2V0Og0KPiBjb25uZWN0IHJldHVybmVkIHVuaGFu
ZGxlZCBlcnJvciAtMTEzDQo+DQoNCkRvZXMgdGhlIGZvbGxvd2luZyBmaXggdGhlIGlzc3VlPw0K
DQo4PC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
DQpGcm9tIGY0OGQzZjAxZGY0NWY1MGYwMTQ1MDYwZjUyNzJjY2YxYWVhODU1YWMgTW9uIFNlcCAx
NyAwMDowMDowMCAyMDAxDQpGcm9tOiBUcm9uZCBNeWtsZWJ1c3QgPHRyb25kLm15a2xlYnVzdEBw
cmltYXJ5ZGF0YS5jb20+DQpEYXRlOiBGcmksIDI0IE5vdiAyMDE3IDEyOjAwOjI0IC0wNTAwDQpT
dWJqZWN0OiBbUEFUQ0hdIFNVTlJQQzogQWxsb3cgY29ubmVjdCB0byByZXR1cm4gRUhPU1RVTlJF
QUNIDQoNClJlcG9ydGVkLWJ5OiBEbWl0cnkgVnl1a292IDxkdnl1a292QGdvb2dsZS5jb20+DQpT
aWduZWQtb2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3QgPHRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0
YS5jb20+DQotLS0NCiBuZXQvc3VucnBjL3hwcnRzb2NrLmMgfCAxICsNCiAxIGZpbGUgY2hhbmdl
ZCwgMSBpbnNlcnRpb24oKykNCg0KZGlmZiAtLWdpdCBhL25ldC9zdW5ycGMveHBydHNvY2suYyBi
L25ldC9zdW5ycGMveHBydHNvY2suYw0KaW5kZXggNGRhZDVkYTM4OGQ2Li44Y2I0MGY4ZmZhNWIg
MTAwNjQ0DQotLS0gYS9uZXQvc3VucnBjL3hwcnRzb2NrLmMNCisrKyBiL25ldC9zdW5ycGMveHBy
dHNvY2suYw0KQEAgLTI0MzcsNiArMjQzNyw3IEBAIHN0YXRpYyB2b2lkIHhzX3RjcF9zZXR1cF9z
b2NrZXQoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQ0KIAljYXNlIC1FQ09OTlJFRlVTRUQ6DQog
CWNhc2UgLUVDT05OUkVTRVQ6DQogCWNhc2UgLUVORVRVTlJFQUNIOg0KKwljYXNlIC1FSE9TVFVO
UkVBQ0g6DQogCWNhc2UgLUVBRERSSU5VU0U6DQogCWNhc2UgLUVOT0JVRlM6DQogCQkvKg0KLS0g
DQoyLjE0LjMNCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRh
aW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg==
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trondmy@primarydata.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jlayton@kernel.org" <jlayton@kernel.org>,
"bfields@fieldses.org" <bfields@fieldses.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"dvyukov@google.com" <dvyukov@google.com>,
"anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "syzkaller@googlegroups.com" <syzkaller@googlegroups.com>
Subject: Re: sunrpc: infinite unkillable console spam in xs_tcp_setup_socket
Date: Fri, 24 Nov 2017 17:34:04 +0000 [thread overview]
Message-ID: <1511544841.14300.4.camel@primarydata.com> (raw)
In-Reply-To: <CACT4Y+bXN5vHCcwEk9NYbPe=RXmweMK09g=nW5D5ww+PTegL5w@mail.gmail.com>
On Mon, 2017-11-20 at 14:02 +0100, Dmitry Vyukov wrote:
> Hello,
>
> The following program triggers infinite stream of the following
> output
> on console. The program is unkillable and this effectively brings the
> machine down:
>
>
> ** 16 printk messages dropped ** [12875.022917] xs_tcp_setup_socket:
> connect returned unhandled error -113
>
Does the following fix the issue?
8<-----------------------------------------------------
>From f48d3f01df45f50f0145060f5272ccf1aea855ac Mon Sep 17 00:00:00 2001
From: Trond Myklebust <trond.myklebust@primarydata.com>
Date: Fri, 24 Nov 2017 12:00:24 -0500
Subject: [PATCH] SUNRPC: Allow connect to return EHOSTUNREACH
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
---
net/sunrpc/xprtsock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 4dad5da388d6..8cb40f8ffa5b 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -2437,6 +2437,7 @@ static void xs_tcp_setup_socket(struct work_struct *work)
case -ECONNREFUSED:
case -ECONNRESET:
case -ENETUNREACH:
+ case -EHOSTUNREACH:
case -EADDRINUSE:
case -ENOBUFS:
/*
--
2.14.3
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trondmy@primarydata.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jlayton@kernel.org" <jlayton@kernel.org>,
"bfields@fieldses.org" <bfields@fieldses.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"dvyukov@google.com" <dvyukov@google.com>,
"anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "syzkaller@googlegroups.com" <syzkaller@googlegroups.com>
Subject: Re: sunrpc: infinite unkillable console spam in xs_tcp_setup_socket
Date: Fri, 24 Nov 2017 17:34:04 +0000 [thread overview]
Message-ID: <1511544841.14300.4.camel@primarydata.com> (raw)
In-Reply-To: <CACT4Y+bXN5vHCcwEk9NYbPe=RXmweMK09g=nW5D5ww+PTegL5w@mail.gmail.com>
On Mon, 2017-11-20 at 14:02 +0100, Dmitry Vyukov wrote:
> Hello,
>
> The following program triggers infinite stream of the following
> output
> on console. The program is unkillable and this effectively brings the
> machine down:
>
>
> ** 16 printk messages dropped ** [12875.022917] xs_tcp_setup_socket:
> connect returned unhandled error -113
>
Does the following fix the issue?
8<-----------------------------------------------------
From f48d3f01df45f50f0145060f5272ccf1aea855ac Mon Sep 17 00:00:00 2001
From: Trond Myklebust <trond.myklebust@primarydata.com>
Date: Fri, 24 Nov 2017 12:00:24 -0500
Subject: [PATCH] SUNRPC: Allow connect to return EHOSTUNREACH
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
---
net/sunrpc/xprtsock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 4dad5da388d6..8cb40f8ffa5b 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -2437,6 +2437,7 @@ static void xs_tcp_setup_socket(struct work_struct *work)
case -ECONNREFUSED:
case -ECONNRESET:
case -ENETUNREACH:
+ case -EHOSTUNREACH:
case -EADDRINUSE:
case -ENOBUFS:
/*
--
2.14.3
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
next prev parent reply other threads:[~2017-11-24 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 13:02 sunrpc: infinite unkillable console spam in xs_tcp_setup_socket Dmitry Vyukov
2017-11-24 17:34 ` Trond Myklebust [this message]
2017-11-24 17:34 ` Trond Myklebust
2017-11-24 17:34 ` Trond Myklebust
2017-11-28 10:00 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511544841.14300.4.camel@primarydata.com \
--to=trondmy@primarydata.com \
--cc=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.