From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Sohil Mehta <sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
Alex Williamson
<alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Ravi V Shankar
<ravi.v.shankar-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Gayatri Kammela
<gayatri.kammela-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v4 0/5] Add Intel IOMMU debugfs support
Date: Tue, 19 Dec 2017 23:25:10 +0200 [thread overview]
Message-ID: <1513718710.7000.230.camel@linux.intel.com> (raw)
In-Reply-To: <1513717687-82420-1-git-send-email-sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Tue, 2017-12-19 at 13:08 -0800, Sohil Mehta wrote:
> Hi All,
>
> This series aims to add debugfs support for Intel IOMMU. It exposes
> IOMMU
> registers, internal context and dumps individual table entries to help
> debug
> Intel IOMMUs.
>
> The first patch does the ground work for the following patches by
> creating a
> new Kconfig option - INTEL_IOMMU_DEBUG. It also reorganizes some Intel
> IOMMU
> data structures. The next four patches add debugfs support for IOMMU
> context
> internals, register contents, PASID internals, and Interrupt remapping
> in
> that order. The information can be accessed in sysfs at
> '/sys/kernel/debug/intel_iommu/'.
Perhaps you need to switch to SPDX license pointer.
I dunno if Thomas' patch with documentation how to do this made upstream
/ linux-next yet.
>
> Regards,
> Sohil
>
> Changes since v3:
> - Remove an unused function parameter from some of the functions
> - Fix checkpatch.pl warnings
> - Remove error reporting for debugfs_create_file functions
> - Fix unnecessary reprogramming of the context entries
> - Simplify and merge the show context and extended context patch into
> one
> - Remove redundant IOMMU null check under for_each_active_iommu
> - Update the commit title to be consistent
>
> Changes since v2:
> - Added a macro for seq file operations based on recommendation by
> Andy
> Shevchenko. The marco can be moved to seq_file.h at a future point
> - Changed the debugfs file names to more relevant ones
> - Added information for MTRR registers in the regset file
>
> Changes since v1:
> - Fixed seq_printf formatting
> - Handled the case when Interrupt remapping is not enabled
>
> Gayatri Kammela (4):
> iommu/vt-d: Add debugfs support for Intel IOMMU internals
> iommu/vt-d: Add debugfs support to show context internals
> iommu/vt-d: Add debugfs support to show register contents
> iommu/vt-d: Add debugfs support to show Pasid table contents
>
> Sohil Mehta (1):
> iommu/vt-d: Add debugfs support for Interrupt remapping
>
> drivers/iommu/Kconfig | 10 ++
> drivers/iommu/Makefile | 1 +
> drivers/iommu/intel-iommu-debug.c | 355
> ++++++++++++++++++++++++++++++++++++++
> drivers/iommu/intel-iommu.c | 35 +---
> drivers/iommu/intel-svm.c | 8 -
> include/linux/intel-iommu.h | 34 ++++
> include/linux/intel-svm.h | 10 +-
> 7 files changed, 416 insertions(+), 37 deletions(-)
> create mode 100644 drivers/iommu/intel-iommu-debug.c
>
--
Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sohil Mehta <sohil.mehta@intel.com>,
Joerg Roedel <joro@8bytes.org>,
Alex Williamson <alex.williamson@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Ashok Raj <ashok.raj@intel.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Gayatri Kammela <gayatri.kammela@intel.com>,
Ravi V Shankar <ravi.v.shankar@intel.com>,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH v4 0/5] Add Intel IOMMU debugfs support
Date: Tue, 19 Dec 2017 23:25:10 +0200 [thread overview]
Message-ID: <1513718710.7000.230.camel@linux.intel.com> (raw)
In-Reply-To: <1513717687-82420-1-git-send-email-sohil.mehta@intel.com>
On Tue, 2017-12-19 at 13:08 -0800, Sohil Mehta wrote:
> Hi All,
>
> This series aims to add debugfs support for Intel IOMMU. It exposes
> IOMMU
> registers, internal context and dumps individual table entries to help
> debug
> Intel IOMMUs.
>
> The first patch does the ground work for the following patches by
> creating a
> new Kconfig option - INTEL_IOMMU_DEBUG. It also reorganizes some Intel
> IOMMU
> data structures. The next four patches add debugfs support for IOMMU
> context
> internals, register contents, PASID internals, and Interrupt remapping
> in
> that order. The information can be accessed in sysfs at
> '/sys/kernel/debug/intel_iommu/'.
Perhaps you need to switch to SPDX license pointer.
I dunno if Thomas' patch with documentation how to do this made upstream
/ linux-next yet.
>
> Regards,
> Sohil
>
> Changes since v3:
> - Remove an unused function parameter from some of the functions
> - Fix checkpatch.pl warnings
> - Remove error reporting for debugfs_create_file functions
> - Fix unnecessary reprogramming of the context entries
> - Simplify and merge the show context and extended context patch into
> one
> - Remove redundant IOMMU null check under for_each_active_iommu
> - Update the commit title to be consistent
>
> Changes since v2:
> - Added a macro for seq file operations based on recommendation by
> Andy
> Shevchenko. The marco can be moved to seq_file.h at a future point
> - Changed the debugfs file names to more relevant ones
> - Added information for MTRR registers in the regset file
>
> Changes since v1:
> - Fixed seq_printf formatting
> - Handled the case when Interrupt remapping is not enabled
>
> Gayatri Kammela (4):
> iommu/vt-d: Add debugfs support for Intel IOMMU internals
> iommu/vt-d: Add debugfs support to show context internals
> iommu/vt-d: Add debugfs support to show register contents
> iommu/vt-d: Add debugfs support to show Pasid table contents
>
> Sohil Mehta (1):
> iommu/vt-d: Add debugfs support for Interrupt remapping
>
> drivers/iommu/Kconfig | 10 ++
> drivers/iommu/Makefile | 1 +
> drivers/iommu/intel-iommu-debug.c | 355
> ++++++++++++++++++++++++++++++++++++++
> drivers/iommu/intel-iommu.c | 35 +---
> drivers/iommu/intel-svm.c | 8 -
> include/linux/intel-iommu.h | 34 ++++
> include/linux/intel-svm.h | 10 +-
> 7 files changed, 416 insertions(+), 37 deletions(-)
> create mode 100644 drivers/iommu/intel-iommu-debug.c
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-12-19 21:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 21:08 [PATCH v4 0/5] Add Intel IOMMU debugfs support Sohil Mehta
2017-12-19 21:08 ` Sohil Mehta
[not found] ` <1513717687-82420-1-git-send-email-sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-12-19 21:08 ` [PATCH v4 1/5] iommu/vt-d: Add debugfs support for Intel IOMMU internals Sohil Mehta
2017-12-19 21:08 ` Sohil Mehta
2017-12-19 21:08 ` [PATCH v4 2/5] iommu/vt-d: Add debugfs support to show context internals Sohil Mehta
2017-12-19 21:08 ` Sohil Mehta
2017-12-19 21:08 ` [PATCH v4 3/5] iommu/vt-d: Add debugfs support to show register contents Sohil Mehta
2017-12-19 21:08 ` Sohil Mehta
2017-12-19 21:08 ` [PATCH v4 4/5] iommu/vt-d: Add debugfs support to show Pasid table contents Sohil Mehta
2017-12-19 21:08 ` Sohil Mehta
2017-12-19 21:08 ` [PATCH v4 5/5] iommu/vt-d: Add debugfs support for Interrupt remapping Sohil Mehta
2017-12-19 21:08 ` Sohil Mehta
[not found] ` <1513717687-82420-6-git-send-email-sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-12-19 21:30 ` Andy Shevchenko
2017-12-19 21:30 ` Andy Shevchenko
[not found] ` <1513719020.7000.234.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-12-20 0:42 ` Mehta, Sohil
2017-12-20 0:42 ` Mehta, Sohil
2017-12-19 21:25 ` Andy Shevchenko [this message]
2017-12-19 21:25 ` [PATCH v4 0/5] Add Intel IOMMU debugfs support Andy Shevchenko
[not found] ` <1513718710.7000.230.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-12-20 1:47 ` Mehta, Sohil
2017-12-20 1:47 ` Mehta, Sohil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513718710.7000.230.camel@linux.intel.com \
--to=andriy.shevchenko-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=gayatri.kammela-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ravi.v.shankar-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.