Re: [PATCH] skb destructor enhancement idea

["David S. Miller" <davem@redhat.com>]

Will writes:
 > We are currently using this change in a low-level packet monitoring module so we can
 > allocate our own packet memory and get called back when the skb is done moving
 > through the stack. It seems like it should be useful to allow network drivers to
 > implement their own device-specific memory management and thus reduce mem copying
 > overhead, too.
 > 
 > Any driver people want to try it out and see if they can make their driver use it to
 > reduce copying?
 > 
 > Any comments on the idea in general?

I think the idea totally stinks.

It puts a new shared cache line (the spinlock) into the hot path of
SKB allocation and freeing on SMP.

Add an ifdef and the knobs you need to the skb struct directly just
like netfilter does.

Later,
David S. Miller
davem@redhat.com