All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Will <will@egregious.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] skb destructor enhancement idea
Date: Mon, 25 Jun 2001 16:12:25 -0700 (PDT)	[thread overview]
Message-ID: <15159.50521.360970.127378@pizda.ninka.net> (raw)
In-Reply-To: <20010625155016.B17735@egregious.net>
In-Reply-To: <20010618134644.A5938@egregious.net> <20010618145331.A32166@wacko.asicdesigners.com> <20010621161349.A27654@egregious.net> <20010625140613.A17207@egregious.net> <15159.48229.326223.682824@pizda.ninka.net> <20010625155016.B17735@egregious.net>


Will writes:
 > > Add an ifdef and the knobs you need to the skb struct directly just
 > > like netfilter does.
 > 
 > So I should #ifdef throughout the tcp and socket code wherever skb's 'destructor' is
 > called to call mine as well? And multiply that by N driver writers who'd like to do
 > the same thing? Sounds messy...

Besides low-level packet frobbing, I can't think of any other
application.

In fact, more appropriate would be to extend netfilter to handle
low-level things as well as med/upper level things.

Then we wouldn't need driver specific things, this is my whole
point.  You're designing for yourself and nobody else.  When
people want to add things to sk_buff it usually is for a
not so well thought reason.

Later,
David S. Miller
davem@redhat.com

  reply	other threads:[~2001-06-25 23:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20010618134644.A5938@egregious.net>
     [not found] ` <20010618145331.A32166@wacko.asicdesigners.com>
     [not found]   ` <20010621161349.A27654@egregious.net>
2001-06-25 21:06     ` [PATCH] skb destructor enhancement idea Will
2001-06-25 22:34       ` David S. Miller
2001-06-25 22:50         ` Will
2001-06-25 23:12           ` David S. Miller [this message]
2001-06-26  8:35           ` When the FUD is all around (sniff) Luigi Genoni
2001-06-26 12:33             ` Alessandro Suardi
2001-06-27 21:08               ` Fabrice Gautier
2001-06-26 12:34             ` Alan Cox
2001-06-26 14:59               ` [OT] " Jordan Crouse
2001-06-26 15:02                 ` Alan Cox
2001-06-26 15:09                   ` Jonathan Lundell
2001-06-26 17:41                     ` Rob Landley
2001-06-26 15:06                 ` Jonathan Lundell
2001-06-26 15:28                 ` Luigi Genoni
2001-06-26 22:47               ` lk
2001-06-27 12:44               ` Marco Colombo
2001-06-26 14:19             ` Stephen Satchell
2001-06-26 14:38             ` Stephen Satchell
2001-06-26 15:16             ` Jonathan Corbet
2001-06-26 16:43               ` Rik van Riel
2001-06-26 17:00               ` Kip Macy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15159.50521.360970.127378@pizda.ninka.net \
    --to=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=will@egregious.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.