From: Joe Perches <joe@perches.com>
To: "Jörg Rödel" <joro@8bytes.org>,
"SF Markus Elfring" <elfring@users.sourceforge.net>
Cc: iommu@lists.linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Intel-IOMMU: Delete an error message for a failed memory allocation in init_dmars()
Date: Sun, 21 Jan 2018 01:37:52 +0000 [thread overview]
Message-ID: <1516498672.24895.2.camel@perches.com> (raw)
In-Reply-To: <20180120194004.GC28161@8bytes.org>
On Sat, 2018-01-20 at 20:40 +0100, Jörg Rödel wrote:
> On Sat, Jan 20, 2018 at 03:55:37PM +0100, SF Markus Elfring wrote:
> > Do you need any more background information for this general
> > transformation pattern?
>
> No.
>
> > Do you find the Linux allocation failure report insufficient for this
> > use case?
>
> Yes, because it can't tell me what the code was trying to allocate.
While Markus' commit messages are nearly universally terrible,
is there really any signficant value in knowing when any
particular OOM condition occurs other than the subsystem that
became OOM?
You're going to be hosed in any case.
Why isn't the generic OOM stack dump good enough?
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: "Jörg Rödel" <joro@8bytes.org>,
"SF Markus Elfring" <elfring@users.sourceforge.net>
Cc: iommu@lists.linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Intel-IOMMU: Delete an error message for a failed memory allocation in init_dmars()
Date: Sat, 20 Jan 2018 17:37:52 -0800 [thread overview]
Message-ID: <1516498672.24895.2.camel@perches.com> (raw)
In-Reply-To: <20180120194004.GC28161@8bytes.org>
On Sat, 2018-01-20 at 20:40 +0100, Jörg Rödel wrote:
> On Sat, Jan 20, 2018 at 03:55:37PM +0100, SF Markus Elfring wrote:
> > Do you need any more background information for this general
> > transformation pattern?
>
> No.
>
> > Do you find the Linux allocation failure report insufficient for this
> > use case?
>
> Yes, because it can't tell me what the code was trying to allocate.
While Markus' commit messages are nearly universally terrible,
is there really any signficant value in knowing when any
particular OOM condition occurs other than the subsystem that
became OOM?
You're going to be hosed in any case.
Why isn't the generic OOM stack dump good enough?
next prev parent reply other threads:[~2018-01-21 1:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 13:00 [PATCH] Intel-IOMMU: Delete an error message for a failed memory allocation in init_dmars() SF Markus Elfring
2018-01-20 13:00 ` SF Markus Elfring
2018-01-20 13:00 ` SF Markus Elfring
[not found] ` <def26d40-37d3-d594-e17c-53e40a3034b7-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2018-01-20 13:34 ` Jörg Rödel
2018-01-20 13:34 ` Jörg Rödel
2018-01-20 13:34 ` Jörg Rödel
[not found] ` <20180120133452.GB28161-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-01-20 14:55 ` SF Markus Elfring
2018-01-20 14:55 ` SF Markus Elfring
2018-01-20 14:55 ` SF Markus Elfring
[not found] ` <6b452dfb-b2fc-2417-26b3-bbcdf11ed06f-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2018-01-20 19:40 ` Jörg Rödel
2018-01-20 19:40 ` Jörg Rödel
2018-01-20 19:40 ` Jörg Rödel
2018-01-21 1:37 ` Joe Perches [this message]
2018-01-21 1:37 ` Joe Perches
[not found] ` <1516498672.24895.2.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2018-01-21 7:19 ` Jörg Rödel
2018-01-21 7:19 ` Jörg Rödel
2018-01-21 7:19 ` Jörg Rödel
[not found] ` <20180121071903.GD28161-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-01-21 19:37 ` Joe Perches
2018-01-21 19:37 ` Joe Perches
2018-01-21 19:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516498672.24895.2.camel@perches.com \
--to=joe@perches.com \
--cc=dwmw2@infradead.org \
--cc=elfring@users.sourceforge.net \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.