From: "Jörg Rödel" <joro@8bytes.org>
To: SF Markus Elfring
<elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] Intel-IOMMU: Delete an error message for a failed memory allocation in init_dmars()
Date: Sat, 20 Jan 2018 13:34:52 +0000 [thread overview]
Message-ID: <20180120133452.GB28161@8bytes.org> (raw)
In-Reply-To: <def26d40-37d3-d594-e17c-53e40a3034b7-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
On Sat, Jan 20, 2018 at 02:00:13PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 20 Jan 2018 13:51:49 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
NACK on this one and the other two IOMMU patches you sent. The messages
give the user/developer useful information about what the memory that
failed to allocate would have been used for.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: "Jörg Rödel" <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: SF Markus Elfring
<elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] Intel-IOMMU: Delete an error message for a failed memory allocation in init_dmars()
Date: Sat, 20 Jan 2018 14:34:52 +0100 [thread overview]
Message-ID: <20180120133452.GB28161@8bytes.org> (raw)
In-Reply-To: <def26d40-37d3-d594-e17c-53e40a3034b7-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
On Sat, Jan 20, 2018 at 02:00:13PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
> Date: Sat, 20 Jan 2018 13:51:49 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
NACK on this one and the other two IOMMU patches you sent. The messages
give the user/developer useful information about what the memory that
failed to allocate would have been used for.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: "Jörg Rödel" <joro@8bytes.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: iommu@lists.linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Intel-IOMMU: Delete an error message for a failed memory allocation in init_dmars()
Date: Sat, 20 Jan 2018 14:34:52 +0100 [thread overview]
Message-ID: <20180120133452.GB28161@8bytes.org> (raw)
In-Reply-To: <def26d40-37d3-d594-e17c-53e40a3034b7@users.sourceforge.net>
On Sat, Jan 20, 2018 at 02:00:13PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 20 Jan 2018 13:51:49 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
NACK on this one and the other two IOMMU patches you sent. The messages
give the user/developer useful information about what the memory that
failed to allocate would have been used for.
Joerg
next prev parent reply other threads:[~2018-01-20 13:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 13:00 [PATCH] Intel-IOMMU: Delete an error message for a failed memory allocation in init_dmars() SF Markus Elfring
2018-01-20 13:00 ` SF Markus Elfring
2018-01-20 13:00 ` SF Markus Elfring
[not found] ` <def26d40-37d3-d594-e17c-53e40a3034b7-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2018-01-20 13:34 ` Jörg Rödel [this message]
2018-01-20 13:34 ` Jörg Rödel
2018-01-20 13:34 ` Jörg Rödel
[not found] ` <20180120133452.GB28161-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-01-20 14:55 ` SF Markus Elfring
2018-01-20 14:55 ` SF Markus Elfring
2018-01-20 14:55 ` SF Markus Elfring
[not found] ` <6b452dfb-b2fc-2417-26b3-bbcdf11ed06f-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2018-01-20 19:40 ` Jörg Rödel
2018-01-20 19:40 ` Jörg Rödel
2018-01-20 19:40 ` Jörg Rödel
2018-01-21 1:37 ` Joe Perches
2018-01-21 1:37 ` Joe Perches
[not found] ` <1516498672.24895.2.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2018-01-21 7:19 ` Jörg Rödel
2018-01-21 7:19 ` Jörg Rödel
2018-01-21 7:19 ` Jörg Rödel
[not found] ` <20180121071903.GD28161-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-01-21 19:37 ` Joe Perches
2018-01-21 19:37 ` Joe Perches
2018-01-21 19:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180120133452.GB28161@8bytes.org \
--to=joro@8bytes.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.