From: "Ji-Ze Hong \(Peter Hong\)" <hpeter@gmail.com>
To: johan@kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw,
"Ji-Ze Hong \(Peter Hong\)" <hpeter+linux_kernel@gmail.com>
Subject: [1/5] USB: serial: f81232: clear overrun flag
Date: Mon, 22 Jan 2018 15:58:43 +0800 [thread overview]
Message-ID: <1516607927-8887-1-git-send-email-hpeter+linux_kernel@gmail.com> (raw)
The F81232 will report data and LSR with bulk like following format:
bulk-in data: [LSR(1Byte)+DATA(1Byte)][LSR(1Byte)+DATA(1Byte)]...
LSR will auto clear frame/parity/break error flag when reading by H/W,
but overrrun will only cleared when reading LSR. So this patch add a
worker to read LSR when OE.
Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
---
drivers/usb/serial/f81232.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index 96036f87b1de..46836041c50e 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -41,12 +41,14 @@ MODULE_DEVICE_TABLE(usb, id_table);
#define FIFO_CONTROL_REGISTER (0x02 + SERIAL_BASE_ADDRESS)
#define LINE_CONTROL_REGISTER (0x03 + SERIAL_BASE_ADDRESS)
#define MODEM_CONTROL_REGISTER (0x04 + SERIAL_BASE_ADDRESS)
+#define LINE_STATUS_REGISTER (0x05 + SERIAL_BASE_ADDRESS)
#define MODEM_STATUS_REGISTER (0x06 + SERIAL_BASE_ADDRESS)
struct f81232_private {
struct mutex lock;
u8 modem_control;
u8 modem_status;
+ struct work_struct lsr_work;
struct work_struct interrupt_work;
struct usb_serial_port *port;
};
@@ -282,6 +284,7 @@ static void f81232_read_int_callback(struct urb *urb)
static void f81232_process_read_urb(struct urb *urb)
{
struct usb_serial_port *port = urb->context;
+ struct f81232_private *priv = usb_get_serial_port_data(port);
unsigned char *data = urb->transfer_buffer;
char tty_flag;
unsigned int i;
@@ -315,6 +318,7 @@ static void f81232_process_read_urb(struct urb *urb)
if (lsr & UART_LSR_OE) {
port->icount.overrun++;
+ schedule_work(&priv->lsr_work);
tty_insert_flip_char(&port->port, 0,
TTY_OVERRUN);
}
@@ -623,6 +627,21 @@ static void f81232_interrupt_work(struct work_struct *work)
f81232_read_msr(priv->port);
}
+static void f81232_lsr_worker(struct work_struct *work)
+{
+ struct f81232_private *priv;
+ struct usb_serial_port *port;
+ int status;
+ u8 tmp;
+
+ priv = container_of(work, struct f81232_private, lsr_work);
+ port = priv->port;
+
+ status = f81232_get_register(port, LINE_STATUS_REGISTER, &tmp);
+ if (status)
+ dev_warn(&port->dev, "read LSR failed: %d\n", status);
+}
+
static int f81232_port_probe(struct usb_serial_port *port)
{
struct f81232_private *priv;
@@ -633,6 +652,7 @@ static int f81232_port_probe(struct usb_serial_port *port)
mutex_init(&priv->lock);
INIT_WORK(&priv->interrupt_work, f81232_interrupt_work);
+ INIT_WORK(&priv->lsr_work, f81232_lsr_worker);
usb_set_serial_port_data(port, priv);
WARNING: multiple messages have this Message-ID (diff)
From: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
To: johan@kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw,
"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: [PATCH 1/5] USB: serial: f81232: clear overrun flag
Date: Mon, 22 Jan 2018 15:58:43 +0800 [thread overview]
Message-ID: <1516607927-8887-1-git-send-email-hpeter+linux_kernel@gmail.com> (raw)
The F81232 will report data and LSR with bulk like following format:
bulk-in data: [LSR(1Byte)+DATA(1Byte)][LSR(1Byte)+DATA(1Byte)]...
LSR will auto clear frame/parity/break error flag when reading by H/W,
but overrrun will only cleared when reading LSR. So this patch add a
worker to read LSR when OE.
Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
---
drivers/usb/serial/f81232.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index 96036f87b1de..46836041c50e 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -41,12 +41,14 @@ MODULE_DEVICE_TABLE(usb, id_table);
#define FIFO_CONTROL_REGISTER (0x02 + SERIAL_BASE_ADDRESS)
#define LINE_CONTROL_REGISTER (0x03 + SERIAL_BASE_ADDRESS)
#define MODEM_CONTROL_REGISTER (0x04 + SERIAL_BASE_ADDRESS)
+#define LINE_STATUS_REGISTER (0x05 + SERIAL_BASE_ADDRESS)
#define MODEM_STATUS_REGISTER (0x06 + SERIAL_BASE_ADDRESS)
struct f81232_private {
struct mutex lock;
u8 modem_control;
u8 modem_status;
+ struct work_struct lsr_work;
struct work_struct interrupt_work;
struct usb_serial_port *port;
};
@@ -282,6 +284,7 @@ static void f81232_read_int_callback(struct urb *urb)
static void f81232_process_read_urb(struct urb *urb)
{
struct usb_serial_port *port = urb->context;
+ struct f81232_private *priv = usb_get_serial_port_data(port);
unsigned char *data = urb->transfer_buffer;
char tty_flag;
unsigned int i;
@@ -315,6 +318,7 @@ static void f81232_process_read_urb(struct urb *urb)
if (lsr & UART_LSR_OE) {
port->icount.overrun++;
+ schedule_work(&priv->lsr_work);
tty_insert_flip_char(&port->port, 0,
TTY_OVERRUN);
}
@@ -623,6 +627,21 @@ static void f81232_interrupt_work(struct work_struct *work)
f81232_read_msr(priv->port);
}
+static void f81232_lsr_worker(struct work_struct *work)
+{
+ struct f81232_private *priv;
+ struct usb_serial_port *port;
+ int status;
+ u8 tmp;
+
+ priv = container_of(work, struct f81232_private, lsr_work);
+ port = priv->port;
+
+ status = f81232_get_register(port, LINE_STATUS_REGISTER, &tmp);
+ if (status)
+ dev_warn(&port->dev, "read LSR failed: %d\n", status);
+}
+
static int f81232_port_probe(struct usb_serial_port *port)
{
struct f81232_private *priv;
@@ -633,6 +652,7 @@ static int f81232_port_probe(struct usb_serial_port *port)
mutex_init(&priv->lock);
INIT_WORK(&priv->interrupt_work, f81232_interrupt_work);
+ INIT_WORK(&priv->lsr_work, f81232_lsr_worker);
usb_set_serial_port_data(port, priv);
--
2.7.4
next reply other threads:[~2018-01-22 7:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 7:58 Ji-Ze Hong (Peter Hong) [this message]
2018-01-22 7:58 ` [PATCH 1/5] USB: serial: f81232: clear overrun flag Ji-Ze Hong (Peter Hong)
-- strict thread matches above, loose matches on Subject: below --
2018-01-22 7:58 [2/5] USB: serial: f81232: add high baud rate support Ji-Ze Hong (Peter Hong)
2018-01-22 7:58 ` [PATCH 2/5] " Ji-Ze Hong (Peter Hong)
2018-01-22 7:58 [3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin Ji-Ze Hong (Peter Hong)
2018-01-22 7:58 ` [PATCH 3/5] " Ji-Ze Hong (Peter Hong)
2018-01-22 7:58 [4/5] USB: serial: f81232: implement break control Ji-Ze Hong (Peter Hong)
2018-01-22 7:58 ` [PATCH 4/5] " Ji-Ze Hong (Peter Hong)
2018-01-22 7:58 [5/5] USB: serial: f81232: fix bulk_in/out size Ji-Ze Hong (Peter Hong)
2018-01-22 7:58 ` [PATCH 5/5] " Ji-Ze Hong (Peter Hong)
2018-01-22 10:06 [1/5] USB: serial: f81232: clear overrun flag Oliver Neukum
2018-01-22 10:06 ` [PATCH 1/5] " Oliver Neukum
2018-01-22 14:55 [2/5] USB: serial: f81232: add high baud rate support Andy Shevchenko
2018-01-22 14:55 ` [PATCH 2/5] " Andy Shevchenko
2018-01-23 1:50 [1/5] USB: serial: f81232: clear overrun flag Ji-Ze Hong (Peter Hong)
2018-01-23 1:50 ` [PATCH 1/5] " Ji-Ze Hong (Peter Hong)
2018-01-23 2:08 [2/5] USB: serial: f81232: add high baud rate support Ji-Ze Hong (Peter Hong)
2018-01-23 2:08 ` [PATCH 2/5] " Ji-Ze Hong (Peter Hong)
2018-01-30 3:30 [2/5] " Johan Hovold
2018-01-30 3:30 ` [PATCH 2/5] " Johan Hovold
2018-01-30 3:57 [3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin Johan Hovold
2018-01-30 3:57 ` [PATCH 3/5] " Johan Hovold
2018-01-30 4:11 [5/5] USB: serial: f81232: fix bulk_in/out size Johan Hovold
2018-01-30 4:11 ` [PATCH 5/5] " Johan Hovold
2018-02-01 3:13 [3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin Ji-Ze Hong (Peter Hong)
2018-02-01 3:13 ` [PATCH 3/5] " Ji-Ze Hong (Peter Hong)
2018-02-01 5:50 [5/5] USB: serial: f81232: fix bulk_in/out size Ji-Ze Hong (Peter Hong)
2018-02-01 5:50 ` [PATCH 5/5] " Ji-Ze Hong (Peter Hong)
2018-02-04 1:46 [3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin Johan Hovold
2018-02-04 1:46 ` [PATCH 3/5] " Johan Hovold
2018-02-04 1:50 [5/5] USB: serial: f81232: fix bulk_in/out size Johan Hovold
2018-02-04 1:50 ` [PATCH 5/5] " Johan Hovold
2018-02-08 9:17 [3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin Ji-Ze Hong (Peter Hong)
2018-02-08 9:17 ` [PATCH 3/5] " Ji-Ze Hong (Peter Hong)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516607927-8887-1-git-send-email-hpeter+linux_kernel@gmail.com \
--to=hpeter@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.