All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong \(Peter Hong\)" <hpeter@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	peter_hong@fintek.com.tw,
	"Ji-Ze Hong \(Peter Hong\)" <hpeter+linux_kernel@gmail.com>
Subject: [5/5] USB: serial: f81232: fix bulk_in/out size
Date: Tue, 30 Jan 2018 15:11:50 +1100	[thread overview]
Message-ID: <20180130041150.GC3434@localhost> (raw)

On Mon, Jan 22, 2018 at 03:58:47PM +0800, Ji-Ze Hong (Peter Hong) wrote:
> Fix Fintek F81232 bulk_in/out size to 64/16 according to the spec.
> http://html.alldatasheet.com/html-pdf/406315/FINTEK/F81232/1762/8/F81232.html
> 
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
> ---
>  drivers/usb/serial/f81232.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
> index a054f69446fd..f3ee537d643c 100644
> --- a/drivers/usb/serial/f81232.c
> +++ b/drivers/usb/serial/f81232.c
> @@ -769,8 +769,7 @@ static struct usb_serial_driver f81232_device = {
>  	},
>  	.id_table =		id_table,
>  	.num_ports =		1,
> -	.bulk_in_size =		256,
> -	.bulk_out_size =	256,
> +	.bulk_out_size =	16,

These fields control the URB buffer sizes and defaults to the corresponding
endpoint max-packet size, which would be 16 for all endpoints according
to the datasheet above.

So it seems you should really be setting bulk_in_size to 64 here (and
possibly leave bulk_out_size unset) as that would appear to match your
device buffer sizes.

Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	peter_hong@fintek.com.tw,
	"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH 5/5] USB: serial: f81232: fix bulk_in/out size
Date: Tue, 30 Jan 2018 15:11:50 +1100	[thread overview]
Message-ID: <20180130041150.GC3434@localhost> (raw)
In-Reply-To: <1516607927-8887-5-git-send-email-hpeter+linux_kernel@gmail.com>

On Mon, Jan 22, 2018 at 03:58:47PM +0800, Ji-Ze Hong (Peter Hong) wrote:
> Fix Fintek F81232 bulk_in/out size to 64/16 according to the spec.
> http://html.alldatasheet.com/html-pdf/406315/FINTEK/F81232/1762/8/F81232.html
> 
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
> ---
>  drivers/usb/serial/f81232.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
> index a054f69446fd..f3ee537d643c 100644
> --- a/drivers/usb/serial/f81232.c
> +++ b/drivers/usb/serial/f81232.c
> @@ -769,8 +769,7 @@ static struct usb_serial_driver f81232_device = {
>  	},
>  	.id_table =		id_table,
>  	.num_ports =		1,
> -	.bulk_in_size =		256,
> -	.bulk_out_size =	256,
> +	.bulk_out_size =	16,

These fields control the URB buffer sizes and defaults to the corresponding
endpoint max-packet size, which would be 16 for all endpoints according
to the datasheet above.

So it seems you should really be setting bulk_in_size to 64 here (and
possibly leave bulk_out_size unset) as that would appear to match your
device buffer sizes.

Johan

             reply	other threads:[~2018-01-30  4:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30  4:11 Johan Hovold [this message]
2018-01-30  4:11 ` [PATCH 5/5] USB: serial: f81232: fix bulk_in/out size Johan Hovold
  -- strict thread matches above, loose matches on Subject: below --
2018-02-08  9:17 [3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin Ji-Ze Hong (Peter Hong)
2018-02-08  9:17 ` [PATCH 3/5] " Ji-Ze Hong (Peter Hong)
2018-02-04  1:50 [5/5] USB: serial: f81232: fix bulk_in/out size Johan Hovold
2018-02-04  1:50 ` [PATCH 5/5] " Johan Hovold
2018-02-04  1:46 [3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin Johan Hovold
2018-02-04  1:46 ` [PATCH 3/5] " Johan Hovold
2018-02-01  5:50 [5/5] USB: serial: f81232: fix bulk_in/out size Ji-Ze Hong (Peter Hong)
2018-02-01  5:50 ` [PATCH 5/5] " Ji-Ze Hong (Peter Hong)
2018-02-01  3:13 [3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin Ji-Ze Hong (Peter Hong)
2018-02-01  3:13 ` [PATCH 3/5] " Ji-Ze Hong (Peter Hong)
2018-01-30  3:57 [3/5] " Johan Hovold
2018-01-30  3:57 ` [PATCH 3/5] " Johan Hovold
2018-01-30  3:30 [2/5] USB: serial: f81232: add high baud rate support Johan Hovold
2018-01-30  3:30 ` [PATCH 2/5] " Johan Hovold
2018-01-23  2:08 [2/5] " Ji-Ze Hong (Peter Hong)
2018-01-23  2:08 ` [PATCH 2/5] " Ji-Ze Hong (Peter Hong)
2018-01-23  1:50 [1/5] USB: serial: f81232: clear overrun flag Ji-Ze Hong (Peter Hong)
2018-01-23  1:50 ` [PATCH 1/5] " Ji-Ze Hong (Peter Hong)
2018-01-22 14:55 [2/5] USB: serial: f81232: add high baud rate support Andy Shevchenko
2018-01-22 14:55 ` [PATCH 2/5] " Andy Shevchenko
2018-01-22 10:06 [1/5] USB: serial: f81232: clear overrun flag Oliver Neukum
2018-01-22 10:06 ` [PATCH 1/5] " Oliver Neukum
2018-01-22  7:58 [5/5] USB: serial: f81232: fix bulk_in/out size Ji-Ze Hong (Peter Hong)
2018-01-22  7:58 ` [PATCH 5/5] " Ji-Ze Hong (Peter Hong)
2018-01-22  7:58 [4/5] USB: serial: f81232: implement break control Ji-Ze Hong (Peter Hong)
2018-01-22  7:58 ` [PATCH 4/5] " Ji-Ze Hong (Peter Hong)
2018-01-22  7:58 [3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin Ji-Ze Hong (Peter Hong)
2018-01-22  7:58 ` [PATCH 3/5] " Ji-Ze Hong (Peter Hong)
2018-01-22  7:58 [2/5] USB: serial: f81232: add high baud rate support Ji-Ze Hong (Peter Hong)
2018-01-22  7:58 ` [PATCH 2/5] " Ji-Ze Hong (Peter Hong)
2018-01-22  7:58 [1/5] USB: serial: f81232: clear overrun flag Ji-Ze Hong (Peter Hong)
2018-01-22  7:58 ` [PATCH 1/5] " Ji-Ze Hong (Peter Hong)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180130041150.GC3434@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpeter+linux_kernel@gmail.com \
    --cc=hpeter@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter_hong@fintek.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.