From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Sinan Kaya <okaya@codeaurora.org>,
dmaengine <dmaengine@vger.kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Vinod Koul <vinod.koul@intel.com>
Subject: [v2,2/6] ACPI / bus: Do not traverse through non-existed device table
Date: Mon, 05 Feb 2018 17:56:47 +0200 [thread overview]
Message-ID: <1517846207.22495.28.camel@linux.intel.com> (raw)
On Sun, 2018-02-04 at 08:18 +0100, Rafael J. Wysocki wrote:
> On Thu, Feb 1, 2018 at 9:45 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, 2018-02-01 at 22:40 +0200, Andy Shevchenko wrote:
> > > On Thu, 2018-02-01 at 15:32 -0500, Sinan Kaya wrote:
> > > > On 2/1/2018 3:20 PM, Andy Shevchenko wrote:
> > > > > When __acpi_match_device() is called it would be possible to
> > > > > have
> > > > > ACPI ID table a MULL pointer. To avoid potential dereference,
> > > >
> > > > NULL
> > >
> > > Thanks, will fix later.
> > >
> > > > Why not bail out here immediately if ids is null?
> > >
> > > Because of the code which wasn't in context of this patch.
> > >
> > > See also patch 1 in the series.
> > >
> > > It's about how acpi_driver_match_device() uses it.
> >
> > Btw, it makes device_get_match_data() to work properly on PRP0001
> > kind
> > of devices.
>
> Maybe combine this one with the [1/6] then, it would make it somewhat
> easier to follow what's going on.
Sure, I will fold in.
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Sinan Kaya <okaya@codeaurora.org>,
dmaengine <dmaengine@vger.kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH v2 2/6] ACPI / bus: Do not traverse through non-existed device table
Date: Mon, 05 Feb 2018 17:56:47 +0200 [thread overview]
Message-ID: <1517846207.22495.28.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0gBzP+QGs5zj25N7DQpBnAyqzmDeeVL4mjK1cns4Jyh1g@mail.gmail.com>
On Sun, 2018-02-04 at 08:18 +0100, Rafael J. Wysocki wrote:
> On Thu, Feb 1, 2018 at 9:45 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, 2018-02-01 at 22:40 +0200, Andy Shevchenko wrote:
> > > On Thu, 2018-02-01 at 15:32 -0500, Sinan Kaya wrote:
> > > > On 2/1/2018 3:20 PM, Andy Shevchenko wrote:
> > > > > When __acpi_match_device() is called it would be possible to
> > > > > have
> > > > > ACPI ID table a MULL pointer. To avoid potential dereference,
> > > >
> > > > NULL
> > >
> > > Thanks, will fix later.
> > >
> > > > Why not bail out here immediately if ids is null?
> > >
> > > Because of the code which wasn't in context of this patch.
> > >
> > > See also patch 1 in the series.
> > >
> > > It's about how acpi_driver_match_device() uses it.
> >
> > Btw, it makes device_get_match_data() to work properly on PRP0001
> > kind
> > of devices.
>
> Maybe combine this one with the [1/6] then, it would make it somewhat
> easier to follow what's going on.
Sure, I will fold in.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next reply other threads:[~2018-02-05 15:56 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 15:56 Andy Shevchenko [this message]
2018-02-05 15:56 ` [PATCH v2 2/6] ACPI / bus: Do not traverse through non-existed device table Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2018-02-06 12:51 [v2,3/6] ACPI / bus: Remove checks in acpi_get_match_data() Andy Shevchenko
2018-02-06 12:51 ` [PATCH v2 3/6] " Andy Shevchenko
2018-02-05 16:54 [v2,3/6] " Rafael J. Wysocki
2018-02-05 16:54 ` [PATCH v2 3/6] " Rafael J. Wysocki
2018-02-05 16:53 [v2,4/6] ACPI / bus: Rename acpi_get_match_data() to acpi_device_get_match_data() Rafael J. Wysocki
2018-02-05 16:53 ` [PATCH v2 4/6] " Rafael J. Wysocki
2018-02-05 16:12 [v2,4/6] " Andy Shevchenko
2018-02-05 16:12 ` [PATCH v2 4/6] " Andy Shevchenko
2018-02-05 16:04 [v2,3/6] ACPI / bus: Remove checks in acpi_get_match_data() Andy Shevchenko
2018-02-05 16:04 ` [PATCH v2 3/6] " Andy Shevchenko
2018-02-05 15:59 [v2,2/6] ACPI / bus: Do not traverse through non-existed device table Andy Shevchenko
2018-02-05 15:59 ` [PATCH v2 2/6] " Andy Shevchenko
2018-02-05 15:56 [v2,1/6] ACPI / bus: Return error code from __acpi_match_device() in one case Andy Shevchenko
2018-02-05 15:56 ` [PATCH v2 1/6] " Andy Shevchenko
2018-02-04 14:06 [v2,5/6] dmaengine: hidma: Constify returned by device_get_match_data() value Andy Shevchenko
2018-02-04 14:06 ` [PATCH v2 5/6] " Andy Shevchenko
2018-02-04 7:23 [v2,4/6] ACPI / bus: Rename acpi_get_match_data() to acpi_device_get_match_data() Rafael J. Wysocki
2018-02-04 7:23 ` [PATCH v2 4/6] " Rafael J. Wysocki
2018-02-04 7:21 [v2,3/6] ACPI / bus: Remove checks in acpi_get_match_data() Rafael J. Wysocki
2018-02-04 7:21 ` [PATCH v2 3/6] " Rafael J. Wysocki
2018-02-04 7:18 [v2,2/6] ACPI / bus: Do not traverse through non-existed device table Rafael J. Wysocki
2018-02-04 7:18 ` [PATCH v2 2/6] " Rafael J. Wysocki
2018-02-04 7:16 [v2,1/6] ACPI / bus: Return error code from __acpi_match_device() in one case Rafael J. Wysocki
2018-02-04 7:16 ` [PATCH v2 1/6] " Rafael J. Wysocki
2018-02-01 21:23 [v2,6/6] device property: Constify device_get_match_data() Sakari Ailus
2018-02-01 21:23 ` [PATCH v2 6/6] " Sakari Ailus
2018-02-01 20:46 [v2,3/6] ACPI / bus: Remove checks in acpi_get_match_data() Andy Shevchenko
2018-02-01 20:46 ` [PATCH v2 3/6] " Andy Shevchenko
2018-02-01 20:45 [v2,2/6] ACPI / bus: Do not traverse through non-existed device table Andy Shevchenko
2018-02-01 20:45 ` [PATCH v2 2/6] " Andy Shevchenko
2018-02-01 20:40 [v2,2/6] " Andy Shevchenko
2018-02-01 20:40 ` [PATCH v2 2/6] " Andy Shevchenko
2018-02-01 20:40 [v2,6/6] device property: Constify device_get_match_data() Sinan Kaya
2018-02-01 20:40 ` [PATCH v2 6/6] " Sinan Kaya
2018-02-01 20:38 [v2,6/6] " Andy Shevchenko
2018-02-01 20:38 ` [PATCH v2 6/6] " Andy Shevchenko
2018-02-01 20:35 [v2,6/6] " Sinan Kaya
2018-02-01 20:35 ` [PATCH v2 6/6] " Sinan Kaya
2018-02-01 20:32 [v2,2/6] ACPI / bus: Do not traverse through non-existed device table Sinan Kaya
2018-02-01 20:32 ` [PATCH v2 2/6] " Sinan Kaya
2018-02-01 20:20 [v2,6/6] device property: Constify device_get_match_data() Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 6/6] " Andy Shevchenko
2018-02-01 20:20 [v2,5/6] dmaengine: hidma: Constify returned by device_get_match_data() value Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 5/6] " Andy Shevchenko
2018-02-01 20:20 [v2,4/6] ACPI / bus: Rename acpi_get_match_data() to acpi_device_get_match_data() Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 4/6] " Andy Shevchenko
2018-02-01 20:20 [v2,3/6] ACPI / bus: Remove checks in acpi_get_match_data() Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 3/6] " Andy Shevchenko
2018-02-01 20:20 [v2,2/6] ACPI / bus: Do not traverse through non-existed device table Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 2/6] " Andy Shevchenko
2018-02-01 20:20 [v2,1/6] ACPI / bus: Return error code from __acpi_match_device() in one case Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 1/6] " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517846207.22495.28.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.